300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread)

[zathras]

Seems like I am slipping out on Exodus dev vesting every now and then by one willet (colloquial term or official btw?).

Must be rounding, will check my types and formulas to see what I can come up with.

Thanks
Zathras

[1714952821]

1714952821

[1714952821]

1714952821

[Bitoy]

Seems like I am slipping out on Exodus dev vesting every now and then by one willet (colloquial term or official btw?).

Must be rounding, will check my types and formulas to see what I can come up with.

Thanks
Zathras

Zathras,

Maybe we can remove the Exodus address from the consensus % calculations since we are getting from different sources and there will be a block difference somewhere.  One willet difference in the exodus address is not a problem.


 

[Bitoy]

I'm having a problem parsing this multisig transaction

http://blockexplorer.com/tx/309cfaa34c85326dd483544a130f4c1337c29599b720538acbc68fa28dced0ff

There seems to be 3 multisig
 
027fff7acd96c7a4c36ab7515ce5c25d49caf9bd16084a2b1eeccde30dc6c8c995 028710f318fa37e6d84c5f6f0d830d73104d00d4da7e539c8ad7f30689c9f25c95 0264e9d0d88cc3defc8855cabdb31d362747292f815149c72464847dfb2c034c95

I tried the 1st 2 but the transaction came out invalid.

Do we have to use  "peek and decode" here also?




 

[zathras]

Hey Bitoy,

That's a normal Class B transaction - first multisig is sender (for redemption), second and third multisigs are 1st and 2nd packet.

Which part are you having problems with mate & I'll do my best to help.

Thanks
Zathras

Code:

Console.WriteLine(mlib.decryptmastercoinpacket("1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n", 1, "8710f318fa37e6d84c5f6f0d830d73104d00d4da7e539c8ad7f30689c9f25c"))
010000001400000002000000000BEBC20000000000000003DB0A0000000000

Console.WriteLine(mlib.decryptmastercoinpacket("1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n", 2, "64e9d0d88cc3defc8855cabdb31d362747292f815149c72464847dfb2c034c"))
020003E8000000000000000000000000000000000000000000000000000000

Code:

select TXID,FROMADD,TYPE,VALID,CURTYPE,SALEAMOUNT from transactions_processed where TXID='309cfaa34c85326dd483544a130f4c1337c29599b720538acbc68fa28dced0ff'
309cfaa34c85326dd483544a130f4c1337c29599b720538acbc68fa28dced0ff	1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n	selloffer	1	2	200000000

[Bitoy]

Hey Bitoy,

That's a normal Class B transaction - first multisig is sender (for redemption), second and third multisigs are 1st and 2nd packet.

Thanks Zathras,

I'll get 2nd and 3rd multisigs and see what happens. 

(Blockchain.org is down = Mymastercoins is down =(

[grazcoin]

wallet + DEx update:

Good news:
Tutorial for masterchain.info's cool Hybrid web wallet (TM) that does bitcoin/mastercoin sending as well as Distributed Exchange operations is available on:
https://masterchain.info/downloads/masterchain_tutorial.pdf

What it CAN do:

• Show balances of MSC/TMSC/BTC for each of your addresses (just add them to the wallet)
• Initiate a send/sell of each of the funds on the wallet
• Suggest wallet addresses when clicking ACCEPT on an sell offer
• Generate a correct PAY transaction after the offer got accepted

What it CANNOT (yet) do:

• Sync wallet with server is not yet implemented. It means that the wallet is kept only locally in your browser. To re-create it, add the addresses to a new wallet

Few technical details:

• All view pages are rendered locally on your browser using json data from the server (or from your filesystem). The json files are static (so no problem for 1M users together, since users bring their own CPUs)
• Wallet is kept in browser storage. No private information is stored. A secure mechanism to keep the wallet data online will be later introduced
• Wallet operations are done using a POST request from the server to:
  
  • /wallet/validateaddr/
  • /wallet/send/
  • /wallet/sell/
  • /wallet/accept/
    
• At this point, the tx gets the bitcion network using pushtx of blockchain.info (will be later changed)
  

Testing:        
Not enough testing has been done. There are still sharp edges, and some hick-ups.
Example are available in the tutorial.
There is still enough work to get to consensus on DEx.


Sources:
https://github.com/grazcoin/mastercoin-tools

Note:
the wallet is not a cold wallet, but a cool wallet ;-)

[dacoinminster]

wallet + DEx update:

Good news:
Tutorial for masterchain.info's cool Hybrid web wallet (TM) that does bitcoin/mastercoin sending as well as Distributed Exchange operations is available on:
https://masterchain.info/downloads/masterchain_tutorial.pdf

What it CAN do:

• Show balances of MSC/TMSC/BTC for each of your addresses (just add them to the wallet)
• Initiate a send/sell of each of the funds on the wallet
• Suggest wallet addresses when clicking ACCEPT on an sell offer
• Generate a correct PAY transaction after the offer got accepted

What it CANNOT (yet) do:

• Sync wallet with server is not yet implemented. It means that the wallet is kept only locally in your browser. To re-create it, add the addresses to a new wallet

Few technical details:

• All view pages are rendered locally on your browser using json data from the server (or from your filesystem). The json files are static (so no problem for 1M users together, since users bring their own CPUs)
• Wallet is kept in browser storage. No private information is stored. A secure mechanism to keep the wallet data online will be later introduced
• Wallet operations are done using a POST request from the server to:
  
  • /wallet/validateaddr/
  • /wallet/send/
  • /wallet/sell/
  • /wallet/accept/
    
• At this point, the tx gets the bitcion network using pushtx of blockchain.info (will be later changed)
  

Testing:        
Not enough testing has been done. There are still sharp edges, and some hick-ups.
Example are available in the tutorial.
There is still enough work to get to consensus on DEx.


Sources:
https://github.com/grazcoin/mastercoin-tools

Note:
the wallet is not a cold wallet, but a cool wallet ;-)

 Whoa!

That is a big step forward!!

Everybody please remember that we are giving a way a HUGE 50 BTC bounty (over $40k at current prices) for testing alone in addition to the even larger down payment on the distributed exchange work on 1/22. Testing this implementation is a great opportunity to earn some of that cash. Talk about fast, easy money!!

[aTriz]

Nice!

Sent my first transaction through the site:
https://blockchain.info/tx/bf9d9904a3797a36b42213e45974c9ee5a7a759147fef79c1648dc62cdc13b19


Also made a Sell offer but I believe I found a bug under "Price per coin" it won't let me type in a decimal, so I went to sell at .003 and instead it listed the sell offer at 3 BTC after typing in 003.

Update: I found that you must type 0 before typing in a decimal, I was attempting to put in .003 which didn't work but when typing in 0.003, it works perfect.


There is no way to cancel orders correct?

[zathras]

Bitoy (and others). The spec mentions that the amount used in a Selling Order should be reserved and thus removed from the balance. I did a consensus check between us and I think you are not doing that yet. Because of this its harder to compare numbers; could you check your output and see if you could build in reserved funds to your solution?

Hey Tachikoma,

I already do the above but still struggling to locate differences between us from comparisons - are you already doing the above?

For example let's look at 1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm, they got 107.12380845 TMSC from Exodus, bought & sold exactly 1 TMSC, sent & received exactly 1 TMSC.  Thus balance is still exactly 107.12380845.

However the address has an active selling order with 1 TMSC reserved.  Thus the balance should be 106.12380845 TMSC + 1 TMSC reserved.

Your final balance & verification API still provide 107.12380845 though (which lacks consensus with my 106.12380845 TMSC state). 





Is this a bug your end or am I missing something? (haven't slept much in the last couple of days so it may be something obvious

Thanks
Zathras

Atriz - I actually think the above is yours - I thought 3BTC for 1TMSC was a bit strong!!!   Protocol wise you cancel a sell by creating another sell with a sale amount of zero.  To change you simply do another sell offer (you can only have one sell open at any one time).  Not sure how that applies to Graz's implementation though, he'd have to advise you there.

[grazcoin]

Nice!

Sent my first transaction through the site:
https://blockchain.info/tx/bf9d9904a3797a36b42213e45974c9ee5a7a759147fef79c1648dc62cdc13b19


Also made a Sell offer but I believe I found a bug under "Price per coin" it won't let me type in a decimal, so I went to sell at .003 and instead it listed the sell offer at 3 BTC after typing in 003.

Update: I found that you must type 0 before typing in a decimal, I was attempting to put in .003 which didn't work but when typing in 0.003, it works perfect.


There is no way to cancel orders correct?

I could accept also format of .003, but for now only 0.003 is considered as valid.
To cancel an order, you create the same order with amount 0.
I am not sure that version that runs now on the website parses it correctly.

[aTriz]

Alright thanks for the reply's fellas,

The address I listed above zathras is indeed mine The one sent and received was with Bitoy when we were testing his wallet.

The transaction that I listed earlier: https://blockchain.info/tx/bf9d9904a3797a36b42213e45974c9ee5a7a759147fef79c1648dc62cdc13b19
I sent 1 TSMC over to address 1Bfg1HgA5fxxXpb3y5CmPvM47s321r2EA9 which isn't showing up on anything. Maybe you smarter minds can tell me what I did wrong here

So I believe if the 1 TSMC which was sent to my buddy was indeed valid then
my correct balance: 105.12380845 TMSC + 1 TMSC reserved.

Keep up the good work!

[Tachikoma]

Bitoy (and others). The spec mentions that the amount used in a Selling Order should be reserved and thus removed from the balance. I did a consensus check between us and I think you are not doing that yet. Because of this its harder to compare numbers; could you check your output and see if you could build in reserved funds to your solution?

Hey Tachikoma,

I already do the above but still struggling to locate differences between us from comparisons - are you already doing the above?

For example let's look at 1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm, they got 107.12380845 TMSC from Exodus, bought & sold exactly 1 TMSC, sent & received exactly 1 TMSC.  Thus balance is still exactly 107.12380845.

However the address has an active selling order with 1 TMSC reserved.  Thus the balance should be 106.12380845 TMSC + 1 TMSC reserved.

Your final balance & verification API still provide 107.12380845 though (which lacks consensus with my 106.12380845 TMSC state).  





Is this a bug your end or am I missing something? (haven't slept much in the last couple of days so it may be something obvious

Thanks
Zathras

Atriz - I actually think the above is yours - I thought 3BTC for 1TMSC was a bit strong!!!  Protocol wise you cancel a sell by creating another sell with a sale amount of zero.  To change you simply do another sell offer (you can only have one sell open at any one time).  Not sure how that applies to Graz's implementation though, he'd have to advise you there.

This is indeed a problem. I think it has to do with my internal address rewrite I did two weeks ago, it basically adds a caching layer on top of the address balances. I forgot to update my specs after this rewrite however so it's possible I introduced a new bug I did not catch.

I've barely had any time this week to do anything but I'm hoping to get some time over the weekend to check this out.  

Edit:

aTriz; bf9d9904a3797a36b42213e45974c9ee5a7a759147fef79c1648dc62cdc13b19 is a Selling Offer, a very pricey one at that

Edit 2:

Found the problem. I kinda removed a large feature with my last rewrite. Initially I could insert a transaction at any moment in time without having to start from the Exodus. Every feature could calculate based on the latest block height. The new balance cache feature does not support this function at all. I monkey patched it for selling offers but the point where I really need to do a total rewrite is getting nearer and nearer

Edit 3:
It should be fixed now. Although I really need to do a full import soon to make sure everything still works from start to finish. Is there a place where we could list all our verification API locations by the way? I keep asking you guys for them but forgetting to write them down.

[Bitoy]

Zathras,

What is the URL of your verification api?

I'll reparse today and run the consensus check to tsmc.


Edit
Mine is at
http://mymastercoins.com/jaddress.aspx?currency_id=2

[Tachikoma]

MyMastercoin vs MSCE Test differences

If you guys can give me a attribute I can supply to your address verification URLs I can add yours as well.

Code:

Bitboy has -0.1 for 1F73UPD5xBKgTSRd8q6QhuncVmDnJAHxYV but Mastercoin explorer has 0
Bitboy has 0.106 for 1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc but Mastercoin explorer has 0.006
Bitboy has 0.9 for 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL but Mastercoin explorer has 1.25
Bitboy has 106.12380845 for 1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm but Mastercoin explorer has 107.12380845
Bitboy has 8.47471458 for 1J2svn2GxYx9LPrpCLFikmzn9kkrXBrk8B but Mastercoin explorer has 10.47471458
Bitboy has -9.89899999 for 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj but Mastercoin explorer has 0
Bitboy has 0.7 for 17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX but Mastercoin explorer has 0.5
Bitboy has 18.0 for 1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n but Mastercoin explorer has 22
Bitboy has -0.1001 for 1Q7soqFvsSkhNy5GdVw1oSm9KVpgzHA9Zk but Mastercoin explorer has 0
Bitboy has -0.08797911 for 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ but Mastercoin explorer has 1
Bitboy has 71.00112399 for 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb but Mastercoin explorer has 38.91312399
Bitboy has -0.00000001 for 1PaPeaZKfNzc7uD8VvXLKyEbxc3roHNzEn but Mastercoin explorer has 0
Bitboy has -80.0 for 15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd but Mastercoin explorer has 70
Bitboy has -10.0 for 1EdAjiApS5cCpHdH4RKPMab1xmMVRWjLvk but Mastercoin explorer has 0
Bitboy has 1.8253 for 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN but Mastercoin explorer has 2.9643
Bitboy has 8.0 for 1MCHESTbJhJK27Ygqj4qKkx4Z4ZxhnP826 but Mastercoin explorer has 9
Bitboy has 0.0 for 1EYe3HxCA9txmN9pfEADctC7v69wi3TbMC but Mastercoin explorer has 0.2
Bitboy has -1.0 for 1MCHESTxYkPSLoJ57WBQot7vz3xkNahkcb but Mastercoin explorer has 0
Bitboy has 1.537 for 18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT but Mastercoin explorer has 0.2
Bitboy has 0.0 for 1EZUnr8NW6fYpHnnunxe5AmFxQsZrNrGET but Mastercoin explorer has 0.2
Bitboy has  for 13NRX88EZbS5q81x6XFrTECzrciPREo821 but Mastercoin explorer has 536.90527669
Bitboy has 0.02 for 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j but Mastercoin explorer has 0.096
Bitboy has 0.4 for 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P but Mastercoin explorer has 0

[Tachikoma]

Tachikoma, since the verification API is your baby, how do you want to play this? First JSON attribute/value pair perhaps?

I think we have two options:

1.
Add a new URI: /mastercoin_verify/information
This could initially return just the block height but we could other important details here later.

In example:

Code:

{"block_height": "280987"}

2.
Change the original APIs to not return a array anymore; but a hash with an extra :meta attribute. The actual return data would get added to a data key.
For instance:

http://mastercoin-explorer.com/mastercoin_verify/addresses

Code:

{"meta": {"block_height": "280987"}, "data":[{"address":"1Q1JfWShLNiX48TXt8GyYthVx9fFfaqnDm","balance":"7.05"},{"address":"1EZm7hqAXYNMp1dPTkQqxYo8jc3rmGMFdK","balance":"1831.6"},{"address":"1EXs6bGwHu2v5YPUUH6MxEqsUs8W8dJrMa","balance":"0.0"},{"address":"1294N6qtFriRdt7Ky1G9RXMMH3sc81YpMz","balance":"29.6207"}...]

I can't decide which implementation I like better so please vote away

[jakecnn]

I would like to help testing, but need some TMSC to do so.

mj6chHZSra8bevTdZe1B8TaQKbJVCxfsaS

1FCXBCeJmYgcutaqSp7QcnzLgpK6fd8swa

Thanks!

[Tachikoma]

Sent you some: 6f01da6f16d102ab6bc5588801eff1ad8029add17ce15bec2ba9dbaf6047a505

[Bebopzzz]

Great job work Grazcoin, the masterchain.info site looks very good.

I was trying to make a sell offer for some MSC but when I tried verifying it said no pubkey on blockchain, it's probably a newb question but what did I do wrong?

Also there is a possible typo when I enter sell offer details for any transaction it says - Amount for sell - should be Amount for sale.

[Bitoy]

MyMastercoin vs MSCE Test differences

If you guys can give me a attribute I can supply to your address verification URLs I can add yours as well.

Code:

Bitboy has -0.1 for 1F73UPD5xBKgTSRd8q6QhuncVmDnJAHxYV but Mastercoin explorer has 0
Bitboy has 0.106 for 1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc but Mastercoin explorer has 0.006
Bitboy has 0.9 for 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL but Mastercoin explorer has 1.25
Bitboy has 106.12380845 for 1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm but Mastercoin explorer has 107.12380845
Bitboy has 8.47471458 for 1J2svn2GxYx9LPrpCLFikmzn9kkrXBrk8B but Mastercoin explorer has 10.47471458
Bitboy has -9.89899999 for 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj but Mastercoin explorer has 0
Bitboy has 0.7 for 17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX but Mastercoin explorer has 0.5
Bitboy has 18.0 for 1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n but Mastercoin explorer has 22
Bitboy has -0.1001 for 1Q7soqFvsSkhNy5GdVw1oSm9KVpgzHA9Zk but Mastercoin explorer has 0
Bitboy has -0.08797911 for 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ but Mastercoin explorer has 1
Bitboy has 71.00112399 for 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb but Mastercoin explorer has 38.91312399
Bitboy has -0.00000001 for 1PaPeaZKfNzc7uD8VvXLKyEbxc3roHNzEn but Mastercoin explorer has 0
Bitboy has -80.0 for 15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd but Mastercoin explorer has 70
Bitboy has -10.0 for 1EdAjiApS5cCpHdH4RKPMab1xmMVRWjLvk but Mastercoin explorer has 0
Bitboy has 1.8253 for 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN but Mastercoin explorer has 2.9643
Bitboy has 8.0 for 1MCHESTbJhJK27Ygqj4qKkx4Z4ZxhnP826 but Mastercoin explorer has 9
Bitboy has 0.0 for 1EYe3HxCA9txmN9pfEADctC7v69wi3TbMC but Mastercoin explorer has 0.2
Bitboy has -1.0 for 1MCHESTxYkPSLoJ57WBQot7vz3xkNahkcb but Mastercoin explorer has 0
Bitboy has 1.537 for 18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT but Mastercoin explorer has 0.2
Bitboy has 0.0 for 1EZUnr8NW6fYpHnnunxe5AmFxQsZrNrGET but Mastercoin explorer has 0.2
Bitboy has  for 13NRX88EZbS5q81x6XFrTECzrciPREo821 but Mastercoin explorer has 536.90527669
Bitboy has 0.02 for 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j but Mastercoin explorer has 0.096
Bitboy has 0.4 for 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P but Mastercoin explorer has 0

Tachikoma,

I think you have it backwards.

ex.

Mastercoin has -0.1 for 1F73UPD5xBKgTSRd8q6QhuncVmDnJAHxYV but Bitboy has 0

[Tachikoma]

Great job work Grazcoin, the masterchain.info site looks very good.

I was trying to make a sell offer for some MSC but when I tried verifying it said no pubkey on blockchain, it's probably a newb question but what did I do wrong?

My guess would be the following:

Your address has never been used before on the Bitcoin blockchain. Because of this Masterchain.info doesn't know your public key and can't create the transaction for you. Using this address to spent an output would probably solve this issue.

Graz uses the opposite approach that I'm using; that is I ask you for the public key. His solution is probably better since most people wouldn't know how to retrieve their public key. But perhaps he could add my solution as backup in case this happens.

Edit: Actually; you can already give your public key, the label said so. My bad!

Edit 2: Graz: This error should probably be a little more descriptive.