300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread)

[Bitoy]

Mine show only 22 differences.

Code:

MM=0 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P ME=0.4
MM=0.096 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j ME=0.02
MM=536.90527669 13NRX88EZbS5q81x6XFrTECzrciPREo821 ME=0
MM=0.2 1EZUnr8NW6fYpHnnunxe5AmFxQsZrNrGET ME=0
MM=0.2 18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT ME=1.537
MM=0 1MCHESTxYkPSLoJ57WBQot7vz3xkNahkcb ME=-1
MM=0.2 1EYe3HxCA9txmN9pfEADctC7v69wi3TbMC ME=0
MM=9 1MCHESTbJhJK27Ygqj4qKkx4Z4ZxhnP826 ME=8
MM=2.9643 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN ME=1.8253
MM=0 1EdAjiApS5cCpHdH4RKPMab1xmMVRWjLvk ME=-10
MM=70 15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd ME=-80
MM=0 1PaPeaZKfNzc7uD8VvXLKyEbxc3roHNzEn ME=-1E-08
MM=70.91312399 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb ME=71.00112399
MM=1 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ ME=-0.08797911
MM=0 1Q7soqFvsSkhNy5GdVw1oSm9KVpgzHA9Zk ME=-0.1001
MM=20 1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n ME=18
MM=0 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj ME=-9.89899999
MM=9.47471458 1J2svn2GxYx9LPrpCLFikmzn9kkrXBrk8B ME=8.47471458
MM=107.12380845 1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm ME=106.12380845
MM=1.2 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL ME=0.9
MM=0.006 1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc ME=0.106
MM=0 1F73UPD5xBKgTSRd8q6QhuncVmDnJAHxYV ME=-0.1

[Tachikoma]

MyMastercoin vs MSCE Test differences

If you guys can give me a attribute I can supply to your address verification URLs I can add yours as well.

Code:

Bitboy has -0.1 for 1F73UPD5xBKgTSRd8q6QhuncVmDnJAHxYV but Mastercoin explorer has 0
Bitboy has 0.106 for 1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc but Mastercoin explorer has 0.006
Bitboy has 0.9 for 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL but Mastercoin explorer has 1.25
Bitboy has 106.12380845 for 1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm but Mastercoin explorer has 107.12380845
Bitboy has 8.47471458 for 1J2svn2GxYx9LPrpCLFikmzn9kkrXBrk8B but Mastercoin explorer has 10.47471458
Bitboy has -9.89899999 for 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj but Mastercoin explorer has 0
Bitboy has 0.7 for 17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX but Mastercoin explorer has 0.5
Bitboy has 18.0 for 1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n but Mastercoin explorer has 22
Bitboy has -0.1001 for 1Q7soqFvsSkhNy5GdVw1oSm9KVpgzHA9Zk but Mastercoin explorer has 0
Bitboy has -0.08797911 for 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ but Mastercoin explorer has 1
Bitboy has 71.00112399 for 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb but Mastercoin explorer has 38.91312399
Bitboy has -0.00000001 for 1PaPeaZKfNzc7uD8VvXLKyEbxc3roHNzEn but Mastercoin explorer has 0
Bitboy has -80.0 for 15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd but Mastercoin explorer has 70
Bitboy has -10.0 for 1EdAjiApS5cCpHdH4RKPMab1xmMVRWjLvk but Mastercoin explorer has 0
Bitboy has 1.8253 for 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN but Mastercoin explorer has 2.9643
Bitboy has 8.0 for 1MCHESTbJhJK27Ygqj4qKkx4Z4ZxhnP826 but Mastercoin explorer has 9
Bitboy has 0.0 for 1EYe3HxCA9txmN9pfEADctC7v69wi3TbMC but Mastercoin explorer has 0.2
Bitboy has -1.0 for 1MCHESTxYkPSLoJ57WBQot7vz3xkNahkcb but Mastercoin explorer has 0
Bitboy has 1.537 for 18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT but Mastercoin explorer has 0.2
Bitboy has 0.0 for 1EZUnr8NW6fYpHnnunxe5AmFxQsZrNrGET but Mastercoin explorer has 0.2
Bitboy has  for 13NRX88EZbS5q81x6XFrTECzrciPREo821 but Mastercoin explorer has 536.90527669
Bitboy has 0.02 for 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j but Mastercoin explorer has 0.096
Bitboy has 0.4 for 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P but Mastercoin explorer has 0

Tachikoma,

I think you have it backwards.

ex.

Mastercoin has -0.1 for 1F73UPD5xBKgTSRd8q6QhuncVmDnJAHxYV but Bitboy has 0

Shizzle me dizzle, you are right. I should not monkey patch stuff apparently... Might need to revert it. Checking it out.

[Bebopzzz]

Great job work Grazcoin, the masterchain.info site looks very good.

I was trying to make a sell offer for some MSC but when I tried verifying it said no pubkey on blockchain, it's probably a newb question but what did I do wrong?

My guess would be the following:

Your address has never been used before on the Bitcoin blockchain. Because of this Masterchain.info doesn't know your public key and can't create the transaction for you. Using this address to spent an output would probably solve this issue.

Graz uses the opposite approach that I'm using; that is I ask you for the public key. His solution is probably better since most people wouldn't know how to retrieve their public key. But perhaps he could add my solution as backup in case this happens.

OK, will make a transaction and try again.

I agree that there should be an option to input a pubkey as a backup, just wondering would the fact that you would have to enter your address and pubkey be a security risk for any reason?

[Tachikoma]

Nope, without a private key nobody can sent a valid transaction in your name. The only risk you have is that the remote server creates a transaction to outputs owned by the server itself and not to the recipient you had in mind. This is why it's important to always check the raw transaction any remote service creates for you before sending it out into the world

[Tachikoma]

Bitboy has 0.106 for 1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc but Mastercoin explorer has 0.006
Bitboy has 1.2 for 182osbPxCo88oaSX4ReJwUr9uAcchmJVaL but Mastercoin explorer has 1.25
Bitboy has 20.0 for 1HfXDX3ALapNebQC8stTdd5zK7kiCgvX9n but Mastercoin explorer has 22
Bitboy has 9.47471458 for 1J2svn2GxYx9LPrpCLFikmzn9kkrXBrk8B but Mastercoin explorer has 10.47471458
Bitboy has 0.7 for 17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX but Mastercoin explorer has 0.5
Bitboy has 1.00002089 for 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ but Mastercoin explorer has 1
Bitboy has 89.00112399 for 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb but Mastercoin explorer has 38.91312399
Bitboy has 1.8273 for 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN but Mastercoin explorer has 2.9643
Bitboy has 0.0 for 1EYe3HxCA9txmN9pfEADctC7v69wi3TbMC but Mastercoin explorer has 0.2
Bitboy has 1.537 for 18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT but Mastercoin explorer has 0.2
Bitboy has 0.0 for 1EZUnr8NW6fYpHnnunxe5AmFxQsZrNrGET but Mastercoin explorer has 0.2
Bitboy has  for 13NRX88EZbS5q81x6XFrTECzrciPREo821 but Mastercoin explorer has 536.90527669
Bitboy has 0.02 for 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j but Mastercoin explorer has 0.096
Bitboy has 0.4 for 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P but Mastercoin explorer has 0

This looks better. Not everything appears to be DEx related though, which is good

[Bitoy]

For the address 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P   

Mymastercoins has 0 TMSC.     

Master Explorer has  .4 TMSC
Due to the following simple send trans
95ce712e72c4ab26201d89bab21219f090a9ee873b5edab375a3b416cb1509de
0a8be4a7e57ee12e30695a3d34c17959ec7fe5931ce06ccac88f262e2d4a30cb


MyMastercoin implementation
95ce712e72c4ab26201d89bab21219f090a9ee873b5edab375a3b416cb1509de is a simple send to 1EZUnr8NW6fYpHnnunxe5AmFxQsZrNrGET
0a8be4a7e57ee12e30695a3d34c17959ec7fe5931ce06ccac88f262e2d4a30cb is a simple send to 1EYe3HxCA9txmN9pfEADctC7v69wi3TbMC

[Bitoy]

This is a very fast synch only 10 address left (from 22 a few minutes ago =)

MM=0 1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P ME=0.4
MM=0.096 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j ME=0.02
MM=536.90527669 13NRX88EZbS5q81x6XFrTECzrciPREo821 ME=0
MM=0.2 1EZUnr8NW6fYpHnnunxe5AmFxQsZrNrGET ME=0
MM=0.2 18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT ME=1.537
MM=0.2 1EYe3HxCA9txmN9pfEADctC7v69wi3TbMC ME=0
MM=2.9643 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN ME=1.8273
MM=70.91312399 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb ME=89.00112399
MM=1 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ ME=1.00002089
MM=0.006 1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc ME=0.106

[Tachikoma]

Fixed Exodus!

[Bitoy]

Tachikoma,

Please check
8d47449b082ffe6f6b2adad327591778c43bf984e84062fb1cb13320b47ccbbd

I'm also getting this as invalid.

Date: 1/11/2014 5:20:31 AM      
Remarks: Sender 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j doesn't have 0.1 TMSC. Bal:0.096 Sale:0 Pend:0      


Edit
Only 8 address left to sync

MM=0.096 1C2H7U2d7XuB61GZvD7CUgfNRaUHKhh91j ME=0.02
MM=536.90527669 13NRX88EZbS5q81x6XFrTECzrciPREo821 ME=0
MM=0.2 18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT ME=1.537
MM=2.9643 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN ME=1.8273
MM=70.91312399 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb ME=89.00112399
MM=1 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ ME=1.00002089
MM=106.12380845 1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm ME=107.12380845
MM=0.006 1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc ME=0.106

[Bitoy]

Tachikoma,

http://mastercoin-explorer.com/transactions/189e0d3f4c4cdc04a70a71d7bcb78ad3c4685220d5931d58ab811443e87afba6

Amount Bought is 1.088
But you Amount Accepted is 1.08802089

1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ

[aTriz]

Nice!

Sent my first transaction through the site:
https://blockchain.info/tx/bf9d9904a3797a36b42213e45974c9ee5a7a759147fef79c1648dc62cdc13b19


Also made a Sell offer but I believe I found a bug under "Price per coin" it won't let me type in a decimal, so I went to sell at .003 and instead it listed the sell offer at 3 BTC after typing in 003.

Update: I found that you must type 0 before typing in a decimal, I was attempting to put in .003 which didn't work but when typing in 0.003, it works perfect.


There is no way to cancel orders correct?

I could accept also format of .003, but for now only 0.003 is considered as valid.
To cancel an order, you create the same order with amount 0.
I am not sure that version that runs now on the website parses it correctly.

I tried to create the same order with amount 0 but after submitting the sell order I still see the 3 BTC sell order. Hopefully no one makes a mistake and buy's it on accident, though if they do I will fully refund them heh.

[zathras]

Blast these differing timezones!!!!!  Last hackathon was great because of the real-time collaboration (rather than back and forth over the forums where I reply while you guys are sleeping & then vice versa lol).

I think we should do another for DEx consensus as soon as we can arrange it

On the topic of consensus - I'm also keen to get the block time in there ASAP because we keep slipping on consensus not due to failure but due to update speed.  With the block time in there I can 'grey out' results that aren't as of the latest block and exclude them from consensus score calculation.

Tachikoma - you mentioned a couple of options - I like 1 (the information URI) as that gives us a lot of flexibility to add other attributes as we discover their utility.  Also did you know you've got a negative balance on one of the addresses?  Hehe love the monkey patching ref - if that was a crime I'd be strung up

Bitoy - think you're behind mate.



Also I'm going to live v2 even though the pull that validates the ambiguous transactions is still outstanding - since you guys have all already validated those transactions, I can only assume it's going to get merged in some form or other (masterchest.info v1 (prod) still invalidates them per current spec)

Thanks
Zathras

[grazcoin]

Tachikoma - the balance of 12QcQmKr7TaPNSHV4g2Nts3nvQAHwKN9cF is (-1)
http://mastercoin-explorer.com/addresses/12QcQmKr7TaPNSHV4g2Nts3nvQAHwKN9cF
It means that you already partially accept DEx for mastercoins (although feature is not yet available), and you also allow negative balances ;-)
Grazoin

[grazcoin]

Great job work Grazcoin, the masterchain.info site looks very good.

I was trying to make a sell offer for some MSC but when I tried verifying it said no pubkey on blockchain, it's probably a newb question but what did I do wrong?

My guess would be the following:

Your address has never been used before on the Bitcoin blockchain. Because of this Masterchain.info doesn't know your public key and can't create the transaction for you. Using this address to spent an output would probably solve this issue.

Graz uses the opposite approach that I'm using; that is I ask you for the public key. His solution is probably better since most people wouldn't know how to retrieve their public key. But perhaps he could add my solution as backup in case this happens.

OK, will make a transaction and try again.

I agree that there should be an option to input a pubkey as a backup, just wondering would the fact that you would have to enter your address and pubkey be a security risk for any reason?

Indeed. For addresses that never signed anything on the blockchain - there is no way to retrieve the public key, so you should enter the public key yourself.
Once you do, the transaction can be generated.

[grazcoin]

Nice!

Sent my first transaction through the site:
https://blockchain.info/tx/bf9d9904a3797a36b42213e45974c9ee5a7a759147fef79c1648dc62cdc13b19


Also made a Sell offer but I believe I found a bug under "Price per coin" it won't let me type in a decimal, so I went to sell at .003 and instead it listed the sell offer at 3 BTC after typing in 003.

Update: I found that you must type 0 before typing in a decimal, I was attempting to put in .003 which didn't work but when typing in 0.003, it works perfect.


There is no way to cancel orders correct?

I could accept also format of .003, but for now only 0.003 is considered as valid.
To cancel an order, you create the same order with amount 0.
I am not sure that version that runs now on the website parses it correctly.

I tried to create the same order with amount 0 but after submitting the sell order I still see the 3 BTC sell order. Hopefully no one makes a mistake and buy's it on accident, though if they do I will fully refund them heh.

I will fix that parsing whenever I get to it (hopefully on the weekend).
Can you please give the tx hash so I don't have to look for it?

[dacoinminster]

The guys from engine.co found a potential race condition where the user could accidentally create a new sell order when they were trying to change an old one, because the old one had already been bought.

At my suggestion, Marv made this pull request to add a 2-confirmation time limit after a sale is complete before that address can initiate a new sell offer: https://github.com/mastercoin-MSC/spec/pull/38

I'm posting here because not respecting the time limit will lead to consensus divergence, so I want to make sure everybody is aware of it.

Thanks!

[zathras]

Quick note to say v2 is now live (https://masterchest.info).

The major point for v2 is of course DEx support, there are a few other bits and pieces (like test MSC consensus monitoring) along with the new simplified Class A transaction parsing model.

I'm fully expecting there to be some bugs at first, please do let me know if you come across anything incorrect or unexpected.

Thanks
Zathras

[aTriz]

Nice!

Sent my first transaction through the site:
https://blockchain.info/tx/bf9d9904a3797a36b42213e45974c9ee5a7a759147fef79c1648dc62cdc13b19


Also made a Sell offer but I believe I found a bug under "Price per coin" it won't let me type in a decimal, so I went to sell at .003 and instead it listed the sell offer at 3 BTC after typing in 003.

Update: I found that you must type 0 before typing in a decimal, I was attempting to put in .003 which didn't work but when typing in 0.003, it works perfect.


There is no way to cancel orders correct?

I could accept also format of .003, but for now only 0.003 is considered as valid.
To cancel an order, you create the same order with amount 0.
I am not sure that version that runs now on the website parses it correctly.

I tried to create the same order with amount 0 but after submitting the sell order I still see the 3 BTC sell order. Hopefully no one makes a mistake and buy's it on accident, though if they do I will fully refund them heh.

I will fix that parsing whenever I get to it (hopefully on the weekend).
Can you please give the tx hash so I don't have to look for it?

d21633ba23f70118185227be58a63527675641ad37967e2aa461559f577aec43


Also zathras v2 is another step closer to DEx

[btc1987]

很牛b的样子 围观 一下

[Tachikoma]

The guys from engine.co found a potential race condition where the user could accidentally create a new sell order when they were trying to change an old one, because the old one had already been bought.

At my suggestion, Marv made this pull request to add a 2-confirmation time limit after a sale is complete before that address can initiate a new sell offer: https://github.com/mastercoin-MSC/spec/pull/38

I'm posting here because not respecting the time limit will lead to consensus divergence, so I want to make sure everybody is aware of it.

Thanks!

Perhaps it's the lack of sleep but I don't like the fact that this has been merged already, up till now everything we did was democratic. Shouldn't we discuss such a major change in the protocol before merging it? I would appreciate it if at least some examples could be given in how this is suppose to work before and after the merge.