300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread)

[grazcoin]

A step towards DEx consensus!

masterchain.info got a DEx update.
The orderbook (TMSC) can be found here:
https://masterchain.info/index.html?currency=TMSC&filter=sell

An example for updated sell offer transaction (sell offer version 0001 with action 02) is here:
https://masterchain.info/selloffer.html?tx=fdebcfcaf4d7bceddd206dc1f334d7c5ccb7a6890c0cfe9d7926be6d7d5e2f58&currency=TMSC
You can check the field "Updating offer" to see the previous depracated offer.

On the address
https://masterchain.info/Address.html?addr=1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb&currency=TMSC
You could see among the sell offers the live and the depracated ones.

My consensus checker still checks MSC, but I will add TMSC. It seems already MSC consensus is broken.
https://masterchain.info/general/difference.json

Let's get first to MSC consensus, break the TMSC consensus with complicated buy/sells (1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb did a good job) and fix it!

[grazcoin]

It seems already MSC consensus is broken.
https://masterchain.info/general/difference.json

I just go over the (MSC) differences one by one.
The first difference (12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7) is due to the tx:
725210a6bfea06e4aa9a582602d758db920eff9c720aca380d6e77c08a4108ac

My parsing says:
invalid mastercoin tx (failed all peek and decode levels)

My code was implemented after https://github.com/mastercoin-MSC/spec/issues/29
https://github.com/grazcoin/mastercoin-tools/blob/master/msc_utils_parsing.py#L181
Level 1, 2 and 3 failed.

I assume you have the updated version:
https://github.com/mastercoin-MSC/spec/#class-a-transactions-also-known-as-the-original-method

correct?
If so, then I will update my code then.

[jeroenn13]

Mymastercoins Wallet v 2 released.

http://mymastercoins.com/MyMSCWallet.aspx

Posted a link at mastercointalk.org
Thank you for this wallet

[grazcoin]

Getting slowly back to consensus on MSC.
https://masterchain.info/general/difference.txt

What's left:

1EAPGcQWz5pwiK98Y8PzWyetqjawsQDRCj: masterchain 0.0; mymastercoins 0.0025; masterchest 0.0025;
1PVWtK1ATnvbRaRceLRH5xj8XV1LxUBu7n: masterchain 0.00011111; mymastercoins 0.00022222; masterchest 0.00022222;
16X6UDz6dMkVAAkWdY6HKe85o6EVAbzDtn: masterchain 0.00275; mymastercoins 0.00025; masterchest 0.00025;
1HbEJjzhU52sjqyhs1KP7L8MXJdFXMhzBM: masterchain 0.0; mymastercoins 0.0005; masterchest 0.0005;
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.0; mymastercoins 0.00014118; masterchest 0.00014118;
1K6JtSvrHtyFmxdtGZyZEF7ydytTGqasNc: masterchain 0.000875; mymastercoins 0.000375; masterchest 0.000375;
1MaStErt4XsYHPwfrN9TpgdURLhHTdMenH: masterchain 17952.5523665; mymastercoins 17952.5521142; masterchest 17952.5521142;

At least part of it is due to validity of transaction with BIP11/BIP16 inputs.
We already agreed to invalidate them after a discussion:
Zathras agreed: https://bitcointalk.org/index.php?topic=292628.msg3644277#msg3644277
Tachikoma agreed: https://bitcointalk.org/index.php?topic=292628.msg3640210#msg3640210

examples for such a tx:
https://blockchain.info/tx/6d68b101c8b92b38c02595a084aa5c8b0308c4f2f5714070d7656251075dbbcf
https://blockchain.info/tx/5a6ebc8fb1969f4d79af34006affd69aa0cac5c25bf9e434aec6333f5f71926e

Currently, those tx are still valid:
https://masterchest.info/lookuptx.aspx?txid=6d68b101c8b92b38c02595a084aa5c8b0308c4f2f5714070d7656251075dbbcf
Same on http://mymastercoins.com/

Zathras, Bitoy - can you please update?

[grazcoin]

You may find consensus checkers for both MSC and TMSC here:

In text format:
https://masterchain.info/general/MSC-difference.txt
https://masterchain.info/general/TMSC-difference.txt

In json format:
https://masterchain.info/general/MSC-difference.json
https://masterchain.info/general/TMSC-difference.json

(the previous https://masterchain.info/general/difference.json is now a link to https://masterchain.info/general/MSC-difference.json)

The difference of MSC is already shrinking, but the TMSC difference seems large.

The first problem that I have seen is J.R. last TMSC set of transactions before the bounty 2 payment.
It seems mymastercoins and masterchest assume exodus address does not have enough TMSC. This causes a long chain of failures.

https://masterchest.info/lookuptx.aspx?txid=f641c18f98b242a791c3e3a06661474794ac27d196b02704179a36a8c6234737
same on http://mymastercoins.com/Default.aspx

btw - is there a way in mymastercoins to give a direct link to transaction?

comments?

[grazcoin]

The first problem that I have seen is J.R. last TMSC set of transactions before the bounty 2 payment.
https://masterchest.info/lookuptx.aspx?txid=f641c18f98b242a791c3e3a06661474794ac27d196b02704179a36a8c6234737

Zathras said that the current agreement is that no TMSC are awarded to the exodus address. It means that this transaction is indeed invalid.
masterchain.info got updated.

Now https://masterchain.info/general/TMSC-difference.txt has still many lines.

The first one is:
1MCHESTbJhJK27Ygqj4qKkx4Z4ZxhnP826: masterchain 9.0; mymastercoins 8.0; masterchest 8.0;

on masterchest:
https://masterchest.info/lookupadd.aspx?address=1MCHESTbJhJK27Ygqj4qKkx4Z4ZxhnP826
we can see that 2 sell offers were given one ofter the other, but they are both considered as valid:

https://masterchest.info/lookuptx.aspx?txid=a6578d96c62f95db8dafcc3b1ef66e3cbbfc37246386e1a6e5827d316c533d02
https://masterchest.info/lookuptx.aspx?txid=21055eae2c3b4d900755378f099fe06d7f28666a4156c8449a46493ecd86a8d4

masterchain.info invalidates the second, as only one sell offer is allowed per address.
https://masterchain.info/selloffer.html?tx=21055eae2c3b4d900755378f099fe06d7f28666a4156c8449a46493ecd86a8d4
(hover over "invalid" to get invalidation reason).

am I correct?

[Magic8Ball]

I tried using the faucet to get my first Mastercoin, but got only test Mastercoins 
https://masterchest.info/lookupadd.aspx?address=13Q6qSEHxhspYW5wUAbeXcCrTUmJ36PMty

[jeroenn13]

I tried using the faucet to get my first Mastercoin, but got only test Mastercoins 
https://masterchest.info/lookupadd.aspx?address=13Q6qSEHxhspYW5wUAbeXcCrTUmJ36PMty

That could mean you have used the faucet before and received real MSC.
You will receive MSC and TMSC once.

[Magic8Ball]

I tried using the faucet to get my first Mastercoin, but got only test Mastercoins  
https://masterchest.info/lookupadd.aspx?address=13Q6qSEHxhspYW5wUAbeXcCrTUmJ36PMty

That could mean you have used the faucet before and received real MSC.
You will receive MSC and TMSC once.

I have not. This was the first time I tried.
The message I got at the end after all the verification showed only Test Mastercoin.

On Mastercointalk forum too I can not log in. I keep getting this message 'Your account is still awaiting admin approval.'

[jeroenn13]

I tried using the faucet to get my first Mastercoin, but got only test Mastercoins  
https://masterchest.info/lookupadd.aspx?address=13Q6qSEHxhspYW5wUAbeXcCrTUmJ36PMty

That could mean you have used the faucet before and received real MSC.
You will receive MSC and TMSC once.

I have not. This was the first time I tried.
The message I got at the end after all the verification showed only Test Mastercoin.

On Mastercointalk forum too I can not log in. I keep getting this message 'Your account is still awaiting admin approval.'

This could be caused by registration through VPN (Anti Spam filter), you are accepted now.

[dacoinminster]

From the dev mailing list:

Ron, Craig, and I have been trying to get a more standardized method for collecting your work summaries and mutual feedback for the monthly $100k milestone bounties.

On 3/1, we'll start collecting your work summaries for the month of February.

YOUR WORK SUMMARIES ARE DUE WITHIN 5 DAYS (3/6/2013 0:00:00 GMT) to qualify for bounty payout. You can check out the form for submitting your work summaries here:

https://docs.google.com/forms/d/12RJqahjVjwRi2xXHKbhJurb4d7uWK21ZxD7EZIlMzuI/viewform

On 3/6, and 3/7 I will update our feedback form to include the appropriate names. YOU WILL THEN HAVE UNTIL 3/12/2014 0:00:00 GMT to complete the feedback form. This is also required to get a payout.

Based on feedback data, I should be able to start making BTC payments by 3/17, with MSC payments shortly thereafter.

You can see what the feedback form will look like here (seeded with names from last round, in the order I got work summaries from people):

https://docs.google.com/forms/d/1Q2ltuJiWAxBfoUYTbJYBA1REb3xwhFokgm9thLXm9Tw/viewform

You'll note that we have changed from direct percentage evaluations to a grading Q&A (the output of which will yield a percentage for each person).

Please take a look at this now, as we will be using these forms very soon (you can enter fake data to see the next page, but please don't actually submit any data with them yet!).

Thanks!

The rules of the contest have not changed, and you should review them (OP of this thread) before using the forms.

[grazcoin]

The rules of the contest have not changed, and you should review them (OP of this thread) before using the forms.

Part of the rules are:

The goal of this contest is to implement a distributed bitcoin/mastercoin exchange.

It seems that the 300 BTC bounty now splits over more subjects (e.g. web wallets, graphical design, RBBs(?)), leaving for the DEx a smaller bounty.
A more fair approach would be a separate bounty for new subjects, while keeping the original DEx bounty as is.
In any case, it should be clear what is covered under the new rules and which percentage gets any subject (as obviously the focus of the contest has changed).

[grazcoin]

Consensus update:

MSC consensus exists between masterchain and masterchest:
https://masterchain.info/general/MSC-difference.txt

MSC consensus check at 27 Feb 2014 13:33:12 GMT
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.0; mymastercoins 0.00014118; masterchest 0.0;
1PVWtK1ATnvbRaRceLRH5xj8XV1LxUBu7n: masterchain 0.00011111; mymastercoins 0.00022222; masterchest 0.00011111;
1MaStErt4XsYHPwfrN9TpgdURLhHTdMenH: masterchain 18421.886487; mymastercoins 18421.8862347; masterchest 18421.886487;
1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P: masterchain 11214.1127123; mymastercoins 11214.594834; masterchest 11214.1127123;

TMSC consensus got *much* closer (taking out mymastercoins, as the last fix is not yet deployed):

TMSC consensus check at 27 Feb 2014 13:17:04 GMT
1CKPYQPiVKMBEHqWco9sNNLNeTCjGSxfrn: masterchain 2.0; masterchest 0.0;
1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S: masterchain 0.01; masterchest 0.0;
17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX: masterchain 0.500611; masterchest 0.700111;
15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd: masterchain 210.0; masterchest 70.0;
1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV: masterchain 41.47875062; masterchest 48.98688888;
16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN: masterchain 2.6663; masterchest 2.9643;
18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT: masterchain 0.2; masterchest 0.0;
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb: masterchain 0.01924938; masterchest 43.91422223;
13NRX88EZbS5q81x6XFrTECzrciPREo821: masterchain 555.90527669; masterchest 516.90527669;
13Km3M4qXJ1sx7nXzMfh7nqvowhzhJfxHY: masterchain 1.0; masterchest 0.0;

[prophetx]

FYI

BITCOIN TRANSACTION MALLEABILITY AND MASTERCOIN by Peter Todd

http://blog.mastercoin.org/2014/02/27/transaction-malleability-and-mastercoin/

Many of you are probably wondering how the transaction malleability problem affects Mastercoin; in short it doesn’t. However understanding why it doesn’t is worthwhile. First of all, let’s quickly go over what transaction malleability is: In Bitcoin transactions are often referred to by the cryptographic hash of the actual data in the transaction, often called the txid...

[dacoinminster]

The end of February is here. If you have worked on any element of our distributed exchange, engaged in testing, worked on the spec, laid the groundwork for smart property, or did something nifty for the project you'd like to be considered for the general innovations bounty, please fill out this form:

https://docs.google.com/forms/d/12RJqahjVjwRi2xXHKbhJurb4d7uWK21ZxD7EZIlMzuI/viewform

YOUR WORK SUMMARIES ARE DUE WITHIN 5 DAYS (3/6/2013 0:00:00 GMT) to qualify for bounty payout. Please do this early, and do it well, to ensure your maximum possible payout.

Thanks!

[grazcoin]

We have consensus on MSC, but with TMSC there are still some differences.
I mark with color the one which is different from the others.
There are 2 addresses where the values are totally different.
Except for this:
masterchain - 1 miss
mymastercoins - 3 misses
masterchest - 5 misses

TMSC consensus check at 28 Feb 2014 22:40:22 GMT
14Q2NNiF5YzDZCjo7vrBuHdbZcmHRJyW3j: masterchain 0.315; mymastercoins 0.308; masterchest 0.315;
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6: masterchain 0.082; mymastercoins 0.089; masterchest 0.08199999; (+ rounding problem?)
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb: masterchain 6.12345; mymastercoins 2.2345679;  masterchest 16.91534621; (all different)
15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd: masterchain 70.0; mymastercoins 70.0; masterchest 220.0;
1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ: masterchain 0.0; mymastercoins 1.0; masterchest 1.0;
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.09886999; mymastercoins 0.09886999; masterchest 0.09887;
1GtTPepFqS8MWZzFKsE62bNowY2LZos8Lq: masterchain 4.01088888; mymastercoins 4.01088888; masterchest 4.0108889; (rounding problem?)
1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV: masterchain 35.37455; mymastercoins 38.88135379; masterchest 49.12022221; (all different)
17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX: masterchain 0.700111; mymastercoins 0.700111; masterchest 0.70458333;
1gYs2kC58J7aRBRJ7CYqysBpYoT7b5i8H: masterchain 50.0; mymastercoins 0.0; masterchest 50.0;
13NRX88EZbS5q81x6XFrTECzrciPREo821: masterchain 536.90527669; mymastercoins 536.90527669; masterchest 555.90527669;

[zathras]

We still have consensus on MSC, but with TMSC there are still some differences.
I mark with color the one which is different from the others.
There are 2 addresses where the values are totally different.
Except for this:
masterchain - 1 miss
mymastercoins - 3 misses
masterchest - 5 misses

TMSC consensus check at 28 Feb 2014 22:40:22 GMT
14Q2NNiF5YzDZCjo7vrBuHdbZcmHRJyW3j: masterchain 0.315; mymastercoins 0.308; masterchest 0.315;
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6: masterchain 0.082; mymastercoins 0.089; masterchest 0.08199999; (+ rounding problem?)
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb: masterchain 6.12345; mymastercoins 2.2345679;  masterchest 16.91534621; (all different)
15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd: masterchain 70.0; mymastercoins 70.0; masterchest 220.0;
1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ: masterchain 0.0; mymastercoins 1.0; masterchest 1.0;
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.09886999; mymastercoins 0.09886999; masterchest 0.09887;
1GtTPepFqS8MWZzFKsE62bNowY2LZos8Lq: masterchain 4.01088888; mymastercoins 4.01088888; masterchest 4.0108889; (rounding problem?)
1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV: masterchain 35.37455; mymastercoins 38.88135379; masterchest 49.12022221; (all different)
17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX: masterchain 0.700111; mymastercoins 0.700111; masterchest 0.70458333;
1gYs2kC58J7aRBRJ7CYqysBpYoT7b5i8H: masterchain 50.0; mymastercoins 0.0; masterchest 50.0;
13NRX88EZbS5q81x6XFrTECzrciPREo821: masterchain 536.90527669; mymastercoins 536.90527669; masterchest 555.90527669;

Hey Graz,

Quick note on one of these - I sent an email around:
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.09886999; mymastercoins 0.09886999; masterchest 0.09887;
Sent 5 sell offers, all of them invalid because there is no amount of bitcoins desired on any of them (ie they're all selling 0.00000001 TMSC for zero).  
Spec says this value has a minimum value of 1.  Thus all those sells are invalid.

Some others will be affected by the decision on minfee (as I currently invalidate a zero value).  Graz & Bitoy I believe are for allowing zero values for minfee, Marv suggested dust but as Graz pointed out cross purposes there.  I believe the bitcoin devs are going to be lowering default fees to so we need to factor that in.

J.R. could you make a quick call on this so we can move on?  Simple question, can minimum fee in sell offers be zero valued?

Thanks guys
Zathras

[dacoinminster]

Yeah, 0 required fee is fine. It's up to the seller. The only need for the fee is when somebody is trying to attack the system with spam to gum up the works, so at times when things are flowing smoothly the minimum fee might not even be needed.

[Bitoy]

I sent the transactions for these 2 addresses and below is the trail of how I got the balance

http://mymastercoins.com/viewaddresstrans.aspx?address=1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb
http://mymastercoins.com/viewaddresstrans.aspx?address=1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV


Some strange trans sent is a 1000 tmsc sell offer although address has only a few tmsc.  According to specs it is valid and assumed that the seller is selling all of it.

I'm currently checking zathras trans.

Graz,
How can I see the test msc transactions?  I tried
https://masterchain.info/Address.html?addr=1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV

But only msc is listed

[dexX7]

https://masterchain.info/Address.html?addr=1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV&currency=TMSC