300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread)

[Bitoy]

Only 3 Addresses left for consensus =)   (Mymastercoins wil be updated today, again reparsing everything.)

MM=0.082 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 MCHAIN=0.053
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHAIN=45.498
MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=3.00124938

MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHEST=1.11111112
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHEST=47.38688888

[1714701102]

1714701102

[Bitoy]

Grazcoin,

In Tx
8b2deeb03c2590bbc6698ab3d663eb920e8bb7e89437a7984a54b8d0154d6741
It says "Depracated Sell Offer"   What does this mean?

https://masterchain.info/Address.html?addr=1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6&currency=TMSC


This is tx difference in address 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6.   

[Bitoy]

Zathras,

Please check
https://masterchest.info/lookupadd.aspx?address=1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S
Current Final Balance .01

This transaction is invalid because "BTC Desired" is 0
d063437a4735b3fdb1f6d44af745257b193ce1acffe32b80457d502c5bc65635

The Tx belos is therefore still  valid
a116be62025ad134f6e071605a577d3e5fb2c8d8e7a86068a520383b1c00b3e3
Sell offer is 0.001

Final Balance is 0.009  (0.01 - .001 )

[Bitoy]

Mymastercoins.com updated and reparsed. Differences


 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6   MCHAIN=0.053          MCHEST=0.082             MM=0.072
 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV   MCHAIN=45.498         MCHEST=47.38688888  MM=38.88135379
 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=3.00124938 MCHEST=1.11111112    MM=2.2345679
 1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S MCHAIN=0.01            MCHEST=0.01               MM=0.009

[Bitoy]

Zathras,

For 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6

This tx has btc desired = 0 which is invalid.
786bc231878df369c6c5f14fe795d5b7623148357d77558578c5a3b28b35584a

It therefore makes this sell offer still open .
1b8572009435e554a68fc640f43efa50c9117f6881813ae56eab5b10f9b3fd53

[Bitoy]

Grazcoin,

For 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb

Our difference is this tx
20f6bc00fe792a063021f24b7194ceab9c23afa457a126ab2164edf63f39083e

https://masterchain.info/simplesend.html?tx=20f6bc00fe792a063021f24b7194ceab9c23afa457a126ab2164edf63f39083e&currency=MSC

In your site is says invalid because balance is too low.

Here is the sequence

2/19/2014 5:45:20 PM sell offer 44.80423511    0.01792169   44.78631342   1   20   .0002.  fdebcf
I posted a sell 1000 tmsc.  Since I only have 44.80423511 tmsc the system marked this as my reserves.

2/22/2014 4:54:47 PM. purchased 3.12345678 from 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV
Tx 0deafadbaebc770b9467305bfef36b2df11d4b60070f31b3a731c5d348c6381f
 this is a purchase and not included in the reserve

2/25/2014 5:22:56 PM  simple send 2 tmsc. 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV    tx 20f6bc
I then sent 2 tmsc which is valid bec. it is not covered by sell offer.

[grazcoin]

Grazcoin,

In Tx
8b2deeb03c2590bbc6698ab3d663eb920e8bb7e89437a7984a54b8d0154d6741
It says "Depracated Sell Offer"   What does this mean?

https://masterchain.info/Address.html?addr=1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6&currency=TMSC


This is tx difference in address 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6.   

Bitoy,

You can visit the transaction page on:
https://masterchain.info/selloffer.html?tx=8b2deeb03c2590bbc6698ab3d663eb920e8bb7e89437a7984a54b8d0154d6741&currency=TMSC
and see that "Depracated Sell Offer" means that it was replaced by an updated sell offer. Just follow the link of "Updated by sell offer" recursively.
Accepts which were done before the update are valid and can be paid (and it looks that the two were paid).

[grimentz]

My work in February:

All my work on the distributed exchange spec, code, and design:

* Implemented new full HTML5 wallet in demo.masterchain.info: https://demo.masterchain.info/wallet.html (users add addresses to wallet from address pages.) Currently supports >20 usability and security features and functions that facilitate DEx trading. Find detailed list in the next section.

* Created quick user guide for the wallet available at: https://demo.masterchain.info/Masterchain_wallet_01.pdf Please read the user guide (it is just page) as it includes the full description of my main body of work.

* Implemented HTML5 transactions form fully integrated with the wallet (import addresses and private keys from wallet) required for DEx testing.


All my work on dEX testing:

* I tested several standard DEx transaction dev.masterchain.info from the point of view of the wallet user: Initiated transactions from the wallet, verified that the transactions appear in the transaction history list of the wallet and reflected in the balance shown in the wallet.

* I continuously test the wallet of https://demo.masterchain.info/ on an array of >30 combinations of devices, screen sizes, resolutions and web browsers including 2 smart phones (iOS and Android) and 3 tablets. As also the developer of the wallet I never move forward with design and implementation directions that cannot be scaled to all screen sizes and be usable with both touch screens and mouse modes.

Other work I would like considered for the "General Innovation" bounty:

Started to investigate (working on a usable prototype) an adaptation of the HTML5 web wallet into a standalone Android application (following a direct request from management) that can be executed directly without browser. I am using <WebView> control and it is going well (Started on the 28th of February.)

[Bitoy]

Ok thanks.

The last sell offer is
1b8572009435e554a68fc640f43efa50c9117f6881813ae56eab5b10f9b3fd53
For  0.01 tmsc

Your reserve is 0.029 tmsc
https://masterchain.info/Address.html?addr=1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6&currency=TMSC

It should be 0.01 since we can only have 1 seller offer.

Bitoy,

You can visit the transaction page on:
https://masterchain.info/selloffer.html?tx=8b2deeb03c2590bbc6698ab3d663eb920e8bb7e89437a7984a54b8d0154d6741&currency=TMSC
and see that "Depracated Sell Offer" means that it was replaced by an updated sell offer. Just follow the link of "Updated by sell offer" recursively.
Accepts which were done before the update are valid and can be paid (and it looks that the two were paid).

[dacoinminster]

Sorry - I should have posted it on MastercoinTalk too. Here's the link to Ron's post there: http://mastercointalk.org/index.php?topic=184.msg345#msg345

You can view everything submitted so far here: https://docs.google.com/spreadsheets/d/175XceNMqPv6LNNosIj0MYdfUvm3MGUQuQQkvZFW6cOU/edit?usp=sharing

Humorously, the results spreadsheet does not include any info about WHO submitted the form. I naively assumed that it would give me the Google Account info. If you did not put your NAME or FORUM HANDLE in your submission, please update your submission to include that, so we know WHO to pay for your work.

I also did not include a form for BTC or MSC addresses, which was equally silly. Please add your address(es), otherwise I will just use the ones you gave me for the last contest.

Thanks,

-J.R.

[grazcoin]

Sorry - I should have posted it on MastercoinTalk too. Here's the link to Ron's post there: http://mastercointalk.org/index.php?topic=184.msg345#msg345

You can view everything submitted so far here: https://docs.google.com/spreadsheets/d/175XceNMqPv6LNNosIj0MYdfUvm3MGUQuQQkvZFW6cOU/edit?usp=sharing

Humorously, the results spreadsheet does not include any info about WHO submitted the form. I naively assumed that it would give me the Google Account info. If you did not put your NAME or FORUM HANDLE in your submission, please update your submission to include that, so we know WHO to pay for your work.

I also did not include a form for BTC or MSC addresses, which was equally silly. Please add your address(es), otherwise I will just use the ones you gave me for the last contest.

Thanks,

-J.R.

At least on my entry I have no write permissions, and the table looks empty - one has to scroll down a long way to see something.
I could repeat it here with my name and BTC/MSC address though.
Grazcoin

[grazcoin]

Grazcoin,

For 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb

Our difference is this tx
20f6bc00fe792a063021f24b7194ceab9c23afa457a126ab2164edf63f39083e

https://masterchain.info/simplesend.html?tx=20f6bc00fe792a063021f24b7194ceab9c23afa457a126ab2164edf63f39083e&currency=MSC

In your site is says invalid because balance is too low.

Indeed it needed a rescan.
Updated.

[grazcoin]

Ok thanks.

The last sell offer is
1b8572009435e554a68fc640f43efa50c9117f6881813ae56eab5b10f9b3fd53
For  0.01 tmsc

Your reserve is 0.029 tmsc
https://masterchain.info/Address.html?addr=1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6&currency=TMSC

It should be 0.01 since we can only have 1 seller offer.

Bitoy,

You can visit the transaction page on:
https://masterchain.info/selloffer.html?tx=8b2deeb03c2590bbc6698ab3d663eb920e8bb7e89437a7984a54b8d0154d6741&currency=TMSC
and see that "Depracated Sell Offer" means that it was replaced by an updated sell offer. Just follow the link of "Updated by sell offer" recursively.
Accepts which were done before the update are valid and can be paid (and it looks that the two were paid).

You are mostly correct.
It is important to note that after a sell offer update, there was still an accept running against the old sell offer.
The accepted part of the old sell offer required a reserve of 0.019, and the new one required 0.01 - in total 0.029.
Obviously my code did not release the 0.019 after the accept expired - I will check that.

EDIT:
fixed on https://github.com/grazcoin/mastercoin-tools/commit/2803ab4c7deaeeff2484113aef5952af6f5d46ee
now I have the same values.
Bitoy, Zathras - please make sure you have this short period when reserved goes up to 0.029.
I will generate such a scenario which tests exactly this case, e.g. a simple send during this short time which would have been valid if reserved does not include the running accept against the old sell offer, but it gets invalidated due to "balance too low" if the correct reserved funds are taken into consideration.

[dacoinminster]

At least on my entry I have no write permissions, and the table looks empty - one has to scroll down a long way to see something.
I could repeat it here with my name and BTC/MSC address though.
Grazcoin

Yeah, you can't edit the results spreadsheet, but you should be able to do the form again to update the spreadsheet.

Adam pointed out that I can add fields even after you guys start doing submissions, so I added fields for name and BTC/MSC addresses

[Bitoy]

Zathras,

Consensus is very near

For 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 The reserve is 0.01

786bc231878df369c6c5f14fe795d5b7623148357d77558578c5a3b28b35584a Is not a cancel sell.  It is invalid because btc desired is 0

1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S  The. Reserve is 0.001
d063437a4735b3fdb1f6d44af745257b193ce1acffe32b80457d502c5bc65635 Is not a cancel sell.  It is invalid because btc desired is 0


MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHEST=2.23456112
MM=0.009 1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S MCHEST=0.01
MM=0.072 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 MCHEST=0.082
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHEST=38.8813538

[Bitoy]

Zathras,

The only difference we have is rounding the calculations.

Ex. Payment tx
724fc55b3f65ea1659d537be068cd3012a192e0c027c936b5fd2adc9b8d2f04b

mymastercoins 0.01792169 TMSC            
Masterchest. 0.0179217


I calculate is as
Amounted of coin bought = round8decimals (btc paid * amount of coins to sell / btc desired)



MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHEST=2.23456112
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHEST=38.8813538

[dexX7]

I was curious how the different exchanges behave in a live comparison and did the following test:

• Create sell offer for 1 TMSC, price: 0.001 BTC/TMSC, required fee: 0.0001 BTC, block time: 5
• Send accept offer for 0.5 TMSC (0.0005 BTC)
• Send payment for 0.1 TMSC (= 0.0001 BTC)
• Send another payment for 0.1 TMSC (= 0.0001 BTC)

I noticed that there are several (visual) differences, e.g. mymastercoins shows two sales a 0.1 TMSC, masterchest combines that into one a 0.2 TMSC and masterchain shows two sales a 0.5 TMSC or one sale of 0.5 TMSC, depending on which side of the trade is observed.

Most notably: the final balance of the buyer is off by 0.1 TMSC on masterchain - it appears that the accept offer is considered as closed after the first payment got in, at least for one side of the trade:

https://masterchain.info/Address.html?addr=1LifmeXYHeUe2qdKWBGVwfbUCMMrwYtoMm&currency=TMSC (open accept: -0.5?)
https://masterchest.info/lookupadd.aspx?address=1LifmeXYHeUe2qdKWBGVwfbUCMMrwYtoMm


I made screenshots at the exact same moment of all related and relevant pages and it may be worth to take a look and do a side-by-side comparison: http://bitwatch.co/dextest/dex01.zip (or mirrored: http://imgur.com/a/VA1l0) Transaction ids and website links are listed and included in a text file in the zip.

All three websites needed a few minutes to actually show a new state, so is unclear to me what happens when. I have three questions:

How do you handle incoming transactions, e.g. treat them instantanious as valid, after x minutes or after n confirmations?

Assuming an "accept offer" locks the amount and reduces the amount up for sale - how are under payments handled?

How are multiple payments that are within the block time span after the accept offer handled?

[Bitoy]

When you create an Accept offer, MyMastercoins saves the Accept Offer Balance.

ex. Balance 0.0005 

Everytime you make a payment, the number of coins paid for is deducted from the Accept Offer balance until it is zero.

ex. 
Payment #1 0.0001    Balance 0.0004
Payment #2 0.0001    Balance 0.0003

I was curious how the different exchanges behave in a live comparison and did the following test:

• Create sell offer for 1 TMSC, price: 0.001 BTC/TMSC, required fee: 0.0001 BTC, block time: 5
• Send accept offer for 0.5 TMSC (0.0005 BTC)
• Send payment for 0.1 TMSC (= 0.0001 BTC)
• Send another payment for 0.1 TMSC (= 0.0001 BTC)

I noticed that there are several (visual) differences, e.g. mymastercoins shows two sales a 0.1 TMSC, masterchest combines that into one a 0.2 TMSC and masterchain shows two sales a 0.5 TMSC or one sale of 0.5 TMSC, depending on which side of the trade is observed.

Most notably: the final balance of the buyer is off by 0.1 TMSC on masterchain - it appears that the accept offer is considered as closed after the first payment got in, at least for one side of the trade:

https://masterchain.info/Address.html?addr=1LifmeXYHeUe2qdKWBGVwfbUCMMrwYtoMm&currency=TMSC (open accept: -0.5?)
https://masterchest.info/lookupadd.aspx?address=1LifmeXYHeUe2qdKWBGVwfbUCMMrwYtoMm


I made screenshots at the exact same moment of all related and relevant pages and it may be worth to take a look and do a side-by-side comparison: http://bitwatch.co/dextest/dex01.zip (or mirrored: http://imgur.com/a/VA1l0) Transaction ids and website links are listed and included in a text file in the zip.

All three websites needed a few minutes to actually show a new state, so is unclear to me what happens when. I have three questions:

How do you handle incoming transactions, e.g. treat them instantanious as valid, after x minutes or after n confirmations?

Assuming an "accept offer" locks the amount and reduces the amount up for sale - how are under payments handled?

How are multiple payments that are within the block time span after the accept offer handled?

[Bitoy]

Updated the Parsing.  Cancel is allowed even if BTC Desired=0

MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHEST=2.23456112
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHEST=38.8813538

Only rounding problems causing a difference.


MM=8.43 1LifmeXYHeUe2qdKWBGVwfbUCMMrwYtoMm MCHAIN=8.33
MM=0.082 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 MCHAIN=0.072
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHAIN=37.38688888
MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=4.23456112

[dexX7]

Everytime you make a payment, the number of coins paid for is deducted from the Accept Offer balance until it is zero.

I was thinking about potential abuse scenarios.

Is there anything that could be done for the case that someone with bad intentions submits a lot of accept offers for all available sales, then never pays or only pays a fraction and repeats this over and over again, every time a new sale is created or out of lock state to shutdown/freeze the complete order book?