assert(...) with side effects

[bytemaster]

In main.cpp the following line within ConnectBlock has side effects which would be skipped if -DNDEBUG were to be defined. 

Code:

assert(view.SetBestBlock(pindex->GetBlockHash())); 

Seems to me the code should be

Code:

bool success = view.SetBestBlock(pindex->GetBlockHash());
assert(success); 

[gmaxwell]

In main.cpp the following line within ConnectBlock has side effects which would be skipped if -DNDEBUG were to be defined.  

It should be, indeed, but we don't support compiling without asserts. This is a known wart. There are a couple of other similar places that ought to be fixed. I might as well go fix it.

[Mike Hearn]

It's probably better to just define a custom CHECK macro that is always active. It's better to crash the node in production than to enter an undefined state.