Nxt source code analysis (QA)

[User705]

Only a few GPUs.  Let's do a practical test.  Post or PM the instructions.  How many long should the attempt be?  Hours, days?  If it works then you'll have succeeded in proving Nxt to be worthless.

Consult the tables at:  http://hashcat.net/oclhashcat/

I'm not that technical.  I'll throw 1 rig of 7950s at it for a day or two if you provide instructions.

[1714743917]

1714743917

[1714743917]

1714743917

[1714743917]

1714743917

[1714743917]

1714743917

[1714743917]

1714743917

[msin]

OK, so you admit you are here just trying to figure out how to make a NXT copycat and have no intention of helping. Thanks for confirming my hunch. I am not sure what the right name for someone like you is. I won't miss anything valuable by ignoring you.

You do know the next generation enterprise got totally destroyed. May the force be with you.

James

Absolutely nothing wrong with a copy, if you can improve on the original.

However,  I am not even sure that there's anything worth copying here.

I haven't seen the spec.  and have no idea that it even works.

Why not become a contributor?  I know you have your reasons, and have to dedicate time on your own project, but you seem to know your Java well and I'm sure the group can get you a sizable bounty of Nxt for your input.  Perhaps help to fund your new project.

[ferment]

@Frictionless.  I see that you know what you're talking about with regard to programming.  In fact, you may very well be a brilliant programmer, but the problem is, no one cares.

Actually he's only demonstrated opinions on programming style and code structure. We haven't seen him present any code or analyze any specific line of code from the released source with meaningful critique. He's only demonstrated that he's read a couple of books or blog articles on code style.

Code speaks louder than words.

[lwilliams777]

@Frictionless.  I see that you know what you're talking about with regard to programming.  In fact, you may very well be a brilliant programmer, but the problem is, no one cares.

Actually he's only demonstrated opinions on programming style and code structure. We haven't seen him present any code or analyze any specific line of code from the released source with meaningful critique. He's only demonstrated that he's read a couple of books or blog articles on code style.

Code speaks louder than words.

+1

[ZeroTheGreat]

I am not sure what the right name for someone like you is.

A pocket troll.

[salsacz]

gaining transaction fee - Nxt mining - is on the line 6315+?

[Come-from-Beyond]

gaining transaction fee - Nxt mining - is on the line 6315+?

No

[salsacz]

if it's called "getBlock", then it's on 5137, but I don't know how you call mining there

[Come-from-Beyond]

if it's called "getBlock", then it's on 5137, but I don't know how you call mining there

generateBlock

[Jaguar0625]

There is also the potential for integer overflow in places like this:

Code:

			for (Map.Entry<Long, Transaction> transactionEntry : newTransactions.entrySet()) {
				
				Transaction transaction = transactionEntry.getValue();
				block.totalAmount += transaction.amount;
				block.totalFee += transaction.fee;
				block.payloadLength += transaction.getBytes().length;
				block.transactions[i++] = transactionEntry.getKey();
				
			}

Although I don't think it's exploitable. It looks like you're only using totalAmount and totalFee as checksums.

[liyi3c]

can anyone tell me what's the referencedTransaction used for? I just found it is used as conditions checking somewhere

[BloodyRookie]

One transaction may depend on another. So if Transaction T1 references Transaction T2 then T1 will not be confirmed until T2 is confirmed.

[mczarnek]

You guys can ignore FrictionlessCoin.. he's just trying to bring down the price so he can buy in cheaper

[Come-from-Beyond]

You guys can ignore FrictionlessCoin.. he's just trying to bring down the price so he can buy in cheaper

He is funny. I even unignored him again.

[delulo]

@Frictionless.  I see that you know what you're talking about with regard to programming.  In fact, you may very well be a brilliant programmer, but the problem is, no one cares.  Why?  Because you have taken it upon yourself as a right to criticize but have not contributed anything productive.  You haven't earned that right yet.  In order to earn the right to be heard you should contribute, even in small amount, not with criticism, but with real productive help.  Once you do that then you've earned the right to criticize and others will actually listen to you.  As it stands, people just think you are a jerk, and using Simon Crowell, a known jerk, as an example doesn't help your cause.  Simon Crowell may be rich and be a star power broker, but I believe he has very few "real" deep long lasting friendships, if any.  

You have not gone about this in an effective way.  If you had played this right you would have contributed in a huge way and others would have sung your praises and others would have gladly signed up for your next generation plan.  In fact they would have become your best sales people and you would have had more folks sign up to help with your development and vision.  But as it stands there are only a few willing to help you and your chances of developing a great system are slim to none.

Why would I contribute to what obviously looks like a Ponzi scheme?

You all first explain to me why this entire shenanigan is any different from a Ponzi scheme?

You are asking a lot of question here Frictionless. Maybe you can just answer on question yourself: Why are you spending so much time on bashing this?? Look at the frequency of your posts. And it's not only this thread. I would say 85% of the criticism on nxt comes from you. You are doing this all day!! Normally PR agencies are hired for such things...
Are you just taking personal satisfaction from from bringing other people's productive work down because you are (obviously) not very profound it doing productive things and have time for it because you are lying around at home unemployed (consider the amount of time you put in here). Or are you a professional trying to bring the price down to buy in cheap? I can not think of any other intention that would make sense. It certainly doesn't stem from worries about the code itself. Someone worried about the art of the code or people would not put his critique forward in such a hating and destructive manner!

[msin]

@Frictionless.  I see that you know what you're talking about with regard to programming.  In fact, you may very well be a brilliant programmer, but the problem is, no one cares.  Why?  Because you have taken it upon yourself as a right to criticize but have not contributed anything productive.  You haven't earned that right yet.  In order to earn the right to be heard you should contribute, even in small amount, not with criticism, but with real productive help.  Once you do that then you've earned the right to criticize and others will actually listen to you.  As it stands, people just think you are a jerk, and using Simon Crowell, a known jerk, as an example doesn't help your cause.  Simon Crowell may be rich and be a star power broker, but I believe he has very few "real" deep long lasting friendships, if any.  

You have not gone about this in an effective way.  If you had played this right you would have contributed in a huge way and others would have sung your praises and others would have gladly signed up for your next generation plan.  In fact they would have become your best sales people and you would have had more folks sign up to help with your development and vision.  But as it stands there are only a few willing to help you and your chances of developing a great system are slim to none.

Why would I contribute to what obviously looks like a Ponzi scheme?

You all first explain to me why this entire shenanigan is any different from a Ponzi scheme?

You are asking a lot of question here Frictionless. Maybe you can just answer on question yourself: Why are you spending so much time on bashing this?? Look at the frequency of your posts. And it's not only this thread. I would say 85% of the criticism on nxt comes from you. You are doing this all day!! Normally PR agencies are hired for such things...
Are you just taking personal satisfaction from from bringing other people's productive work down because you are (obviously) not very profound it doing productive things and have time for it because you are lying around at home unemployed (consider the amount of time you put in here). Or are you a professional trying to bring the price down to buy in cheap? I can not think of any other intention that would make sense. It certainly doesn't stem from worries about the code itself. Someone worried about the art of the code or people would not put his critique forward in such a hating and destructive manner!

I actually think some of his posts were productive in the sense that he was pointing out bugs.  He definitely has an agenda and strong knowledge of Java, I think we could give him a collective group hug and try to bring him on board with Nxt.  He could certainly profit from his observations and help the forum dev team here.

[delulo]

@Frictionless.  I see that you know what you're talking about with regard to programming.  In fact, you may very well be a brilliant programmer, but the problem is, no one cares.  Why?  Because you have taken it upon yourself as a right to criticize but have not contributed anything productive.  You haven't earned that right yet.  In order to earn the right to be heard you should contribute, even in small amount, not with criticism, but with real productive help.  Once you do that then you've earned the right to criticize and others will actually listen to you.  As it stands, people just think you are a jerk, and using Simon Crowell, a known jerk, as an example doesn't help your cause.  Simon Crowell may be rich and be a star power broker, but I believe he has very few "real" deep long lasting friendships, if any.  

You have not gone about this in an effective way.  If you had played this right you would have contributed in a huge way and others would have sung your praises and others would have gladly signed up for your next generation plan.  In fact they would have become your best sales people and you would have had more folks sign up to help with your development and vision.  But as it stands there are only a few willing to help you and your chances of developing a great system are slim to none.

Why would I contribute to what obviously looks like a Ponzi scheme?

You all first explain to me why this entire shenanigan is any different from a Ponzi scheme?

You are asking a lot of question here Frictionless. Maybe you can just answer on question yourself: Why are you spending so much time on bashing this?? Look at the frequency of your posts. And it's not only this thread. I would say 85% of the criticism on nxt comes from you. You are doing this all day!! Normally PR agencies are hired for such things...
Are you just taking personal satisfaction from from bringing other people's productive work down because you are (obviously) not very profound it doing productive things and have time for it because you are lying around at home unemployed (consider the amount of time you put in here). Or are you a professional trying to bring the price down to buy in cheap? I can not think of any other intention that would make sense. It certainly doesn't stem from worries about the code itself. Someone worried about the art of the code or people would not put his critique forward in such a hating and destructive manner!

I actually think some of his posts were productive in the sense that he was pointing out bugs.  He definitely has an agenda and strong knowledge of Java, I think we could give him a collective group hug and try to bring him on board with Nxt.  He could certainly profit from his observations and help the forum dev team here.

Sure. Agree. Open Arm for everyone
I was just wondering about the way and the extend one person presented criticism...

[ImmortAlex]

He definitely has an agenda and strong knowledge of Java, I think we could give him a collective group hug and try to bring him on board with Nxt.

I see he have knowledge in Java, but do not see any proof that it is strong.
He doesn't found any actual problem except well-known "one big file", "no unit tests", "empty catch blocks", "we all will die".

[ferment]

I actually think some of his posts were productive in the sense that he was pointing out bugs.  He definitely has an agenda and strong knowledge of Java, I think we could give him a collective group hug and try to bring him on board with Nxt.  He could certainly profit from his observations and help the forum dev team here.

He hasn't actually pointed out a single bug. All he has done is expressed opinions on code style and software project management. It's trolling.

Those of us who do real world software dev know that the issues that he brings up are stylistic "nice to haves" and can be fixed in a few days of refactoring. No big deal. Code structure, documentation, specs, tests, etc, etc are secondary to a working, innovative system.

Instead, we're focused on 3 types of problems:

1. Immediate/critical bugs causing improper functioning.
2. Attack vectors.
3. Logic flaws - injected or otherwise.

Given the track record of the core dev team (BCNext, C-f-b, Jean-Luc), none of his complaints bother me at all. I have some minor suggestions on process (like how to leverage my 100 nodes for testing), but I'm ok with how things are going given Jean-Luc's release tempo.

Everything in this thread and related ones have me extremely bullish on NXT.

[msin]

I actually think some of his posts were productive in the sense that he was pointing out bugs.  He definitely has an agenda and strong knowledge of Java, I think we could give him a collective group hug and try to bring him on board with Nxt.  He could certainly profit from his observations and help the forum dev team here.

He hasn't actually pointed out a single bug. All he has done is expressed opinions on code style and software project management. It's trolling.

Those of us who do real world software dev know that the issues that he brings up are stylistic "nice to haves" and can be fixed in a few days of refactoring. No big deal. Code structure, documentation, specs, tests, etc, etc are secondary to a working, innovative system.

Instead, we're focused on 3 types of problems:

1. Immediate/critical bugs causing improper functioning.
2. Attack vectors.
3. Logic flaws - injected or otherwise.

Given the track record of the core dev team (BCNext, C-f-b, Jean-Luc), none of his complaints bother me at all. I have some minor suggestions on process (like how to leverage my 100 nodes for testing), but I'm ok with how things are going given Jean-Luc's release tempo.

Everything in this thread and related ones have me extremely bullish on NXT.

Your work and the work of others here has me very bullish on Nxt as well!