Bitcoin Forum
November 09, 2024, 06:20:46 AM *
News: Latest Bitcoin Core release: 28.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: Multi-signature plugin for Electrum - How much would it cost to develop?  (Read 2755 times)
doolittle (OP)
Full Member
***
Offline Offline

Activity: 340
Merit: 101


View Profile
January 22, 2014, 05:30:36 AM
 #1

I am looking for security options to professionally manage BTC investor funds (a bit like the guys from Exante).
It would be extremely helpful to have Gui-based Multi-Sig functionality. How much effort would it be to create a plug-in for Electrum that could also be used by a non power-user? Can anybody point me to developers who are currently working on this or who are willing to work as contractors?
Or is there already and open-source solution I just do not know about?


 
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
January 22, 2014, 05:15:10 PM
 #2

Plugins offload the work of the client developers to others. Client developers should be working to expose the multisig functionality as much as possible.

I did suggest something different in another thread. An application, GUI or CLI, which takes a raw transaction hex (unsigned or partially signed), Json inputs, and an arbitrary private key and tries to sign the transaction

It must parse the redeem script and script pubkey to understand the type of address its dealing with, then see how many keys it can sign with, and return the raw signed transaction. If its fully signed, they can broadcast using any client. If its not fully signed, they pass it to the other parties.

Bitwasp Developer.
ThomasV
Moderator
Legendary
*
Offline Offline

Activity: 1896
Merit: 1353



View Profile WWW
January 22, 2014, 06:06:43 PM
 #3

I am currently working on such a plugin. Expect an announcement soon.

Electrum: the convenience of a web wallet, without the risks
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
January 22, 2014, 06:36:29 PM
 #4

I am currently working on such a plugin. Expect an announcement soon.

I'm eagerly waiting for it anyway.. Can it handle signing a transaction where only one of the keys used in the p2sh address is in the wallet (ie, one key is derived from a master public key? If this is the case I would ask users to download it to use bitwasp, until proper support comes in the clients.

I wish to generate multsig addresses deterministically from 3 users master public keys. Users need to be able to sign a transaction spending the funds in the multisig address, where they only have one key of the 3 in their wallet.

Any issues with the gap limit, or will your plugin account for this?

@ThomasV - could you test your plugin against something for me? Please see here: https://bitcointalk.org/index.php?topic=427368.msg4666722#msg4666722

Bitwasp Developer.
btcbot
Full Member
***
Offline Offline

Activity: 151
Merit: 105



View Profile
January 24, 2014, 05:42:38 AM
 #5

The Marketplace (a I2P SR clone) wrote an Electrum plugin for their transactions and use it today for their business.  The source is available at the forum, which unfortunately, you have to run I2P to get. 

http://www.reddit.com/r/themarketplace/comments/1tx26z/the_marketplace_simple_guide_with_pictures_latest/

Don't tip me... tip the Riseup folks who protect activists around the world.
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
January 24, 2014, 06:09:05 PM
 #6

I saw this alright, I do need to have a look at the internals again however I was told it doesn't rely on the electrum wallet, keypairs for multsig address creation are randomly generated and not deterministically derived from the seed.

I don't see the point in asking users to sign a plugin that will soon be out of date. Eventually, this will be much easier to do and across all clients, there will be support for BIP32, meaning they'll have to support signing transactions where only one of the required keys is available locally.

While on the lookout for something I can use, I think haskoin is going to be a great help, and a realistic option for people using bitwasp to use in the future. The reason being, is it supports BIP32 entirely, and handles multisig accounts well. It also allows stateless signatures to be computed, so if supplied with the transactions hex, and a non-wallet key for signing, it will sign it! I'm already using it to help test a PHP library for BIP32.

ThomasV has told me, once electrum has BIP32 accounts he will be in a better position to release the multisig plugin. They work well together.

Bitwasp Developer.
owockEznan
Newbie
*
Offline Offline

Activity: 5
Merit: 0


View Profile
January 29, 2014, 10:44:45 AM
 #7

Since I have written the vast majority of the multi-sig part of that plug-in, I feel I need to respond to this.

The plugin works by generating new recieve addresses (beyond the gap limit), and then giving the public key to the user. This is passed into the web site, which creates the P2SH address to send the coin to as well as presenting them with the redeemScript (so that they could verify with the person they were purchasing from that the address was with their public key as well).

When you need to complete a transaction, you are provided with json that looks like
Code:
{   
    "tx": Raw partialy signed transaction ,
    "pubKey": "public key that this needs to be signed with",
    "input" : {
        "txid": tx of funding transaction,
        "vout": vout of funding transaction ,
        "scriptPubKey": from the funding transaction,
        "redeemScript": the redeemscript
         },
    "wallet": thebitcoin 'address' that pubKey makes
}

The plugin then signs the transaction and allows you to broadcast it or save it. If you used the plugin to create the public key it needs, it will be found automatically. If you created a public key somewhere else when you created the escrow address, then you are prompted to supply private key that will be used to sign the transaction.

The main problem with the implementation is it mixes up your keys for making p2sh wallets and the keys you use to handle your coin. I've suggested to all the users they create a seperate wallet that is only used for signing transactions that is kept offline. A full BIP_32 implementation would be a lot nicer, but the plugin is essentially a quick and dirty hack which allows people to use the site without having to use bitcoin-qt.
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
January 30, 2014, 04:24:35 PM
 #8

Bip32 and multisig support each other very well. I'm excited about whoever gets to the solution first. Have you seen https://coinb.in/multisig? Its an awesome site, although yet to try it out with mine. It has all the parts it needs for multisig. I'm glad someone was finally able to do this, because signing should only be done by a specific wallet (eventually bip32) or just random keys which don't need to be imported to the client, and in fact shouldn't.

Just a thought, have you thought about adding a non-standard chain in the plugin (0 for normal address, 1 for change, and 2, which the plugin only uses to sign)? If the concern is its using keys that handle coins, and only need to be signed, taking advantage of deterministic generation would be good.

Your plugin would generate pubkeys along this chain, look for transactions to be signed with a key from this chain (as specified in the json)

My eventual plan is accept a bip32 chain, and use internal addresses for generating keys for multisig/signing transactions, and the external for receiving coin.
Addresses for keys come from other extended keys. Who needs a live wallet now!

Bitwasp Developer.
owockEznan
Newbie
*
Offline Offline

Activity: 5
Merit: 0


View Profile
January 31, 2014, 05:26:16 AM
 #9

I will admit this idea had not occurred to me, due to my poor knowledge of BIP_32. Most end-users I don't think use two wallets as I have suggested several times -- and that is a serious security problem. In fact, most of them don't even take the simple precaution of backing up important info like their Electrum seed or their PGP keys or generating a separate revocation certificate in case of key compromise or loss.

One of the problems in trying to get new features into this is I am not the developer of the plugin that is being used. I knew virtually nothing about bitcoin before working on Electrum except that it used ECC and that the proof of work was used to do away with a central authority for processing transactions. I spent many hours trying to get my output from Electrum to match byte for byte bitcoind's output before I realized that ECDSA isn't always deterministic! My goal at the outset was simply to be able to sign a transaction so I could complete it as a user of the site without having to download the entire blockchain. Since the devs of the site turned it into a plugin, I have only supplied patches on their forums for problems users have had. If I had known about that javascript-based site, I would've likely never worked on this at all. Of course, if I knew what I know now I would've likely used pybtctools to accomplish my goal.
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
January 31, 2014, 02:47:23 PM
 #10

"My goal at the outset was simply to be able to sign a transaction so I could complete it as a user of the site without having to download the entire blockchain"
"If I had known about that javascript-based site, I would've likely never worked on this at all"
Yeah, it has definitely just saved people a lot of work.

BIP32 will eventually be the standard in all clients, from what I gather, but 'eventually' is the important word here. Plenty have the support in them, but still haven't made the change.

Electrum makes use of various chains, but you'd nearly be best taking some stuff from pybitcointools to do the deterministic generation IMO. But you could have it so it uses iteration:2:mpk, and the way of generating the private key (adding integer representations of sha256 hashes) - 2 is chosen because electrum won't ever use that chain, but it makes perfect sense for signing. That way, you could accept a master public key on the website, and do away with asking users for a public key each time - that is if you get all users using the plugin. Could also use stuff from other chains to receive coin from the site.

Best off waiting for BIP32 probably. I'll be doing the same. It'll make it so easy!

Bitwasp Developer.
fran2k
Hero Member
*****
Offline Offline

Activity: 784
Merit: 500


View Profile WWW
July 13, 2014, 05:21:57 AM
 #11

I´m also very interested in this.

I just found some work from maraoz about multisig creation.

Also I though Armory was implementing this in the last alpha release.
runam0k
Legendary
*
Offline Offline

Activity: 1092
Merit: 1001


Touchdown


View Profile
July 16, 2014, 12:11:28 PM
 #12

Another bump for multisig.
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
July 16, 2014, 04:45:49 PM
 #13

I wrote a CLI script to sign multisignature tx's given a redeem script, raw transaction, and electrum seed. It looks up UTXO info if you're online, otherwise you need bitcoin core compatible JSON inputs data. I've only used it a small bit, it's mainly provided as example usage of my library. I posted about it a while ago but I expect people have reservations about entering their seed into PHP CLI scripts Smiley

https://github.com/Bit-Wasp/bitcoin-lib-php/blob/master/examples/electrum_sign_multisig.php




Bitwasp Developer.
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
July 19, 2014, 07:41:06 AM
 #14

I am currently working on such a plugin. Expect an announcement soon.

Any updates?

Bitwasp Developer.
fbueller
Sr. Member
****
Offline Offline

Activity: 412
Merit: 287


View Profile
July 24, 2014, 01:11:01 PM
 #15

Don't mean to triple post, but looks like there is an app for HD wallets and multisig transaction signing. Currently runs on android, and on the play store: Onchain.io's transaction signer - https://github.com/onchain/onchain-android

Works a charm, and really hoping to see more like it!

Bitwasp Developer.
dabura667
Sr. Member
****
Offline Offline

Activity: 475
Merit: 252


View Profile
July 24, 2014, 04:35:25 PM
 #16

Don't mean to triple post, but looks like there is an app for HD wallets and multisig transaction signing. Currently runs on android, and on the play store: Onchain.io's transaction signer - https://github.com/onchain/onchain-android

Works a charm, and really hoping to see more like it!

Copay is also great and it has an Android version + desktop browser plugin version.

My Tip Address:
1DXcHTJS2DJ3xDoxw22wCt11FeAsgfzdBU
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!