Bitcoin Forum
December 13, 2024, 08:47:53 PM *
News: Latest Bitcoin Core release: 28.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: [REQ] Adjustable comment length in coin control?  (Read 504 times)
Automatic (OP)
Full Member
***
Offline Offline

Activity: 238
Merit: 109


View Profile
March 08, 2014, 12:00:50 AM
Last edit: March 08, 2014, 12:14:42 AM by Automatic
 #1

As I like to pay using specific inputs, and, I only know those specific inputs by their comments, seeing this isn't all that useful:-


Selling $78 PayPal to who Mr. Coin Control!?! I don't want to spend the funds I bought off my real life friend to pay a known gambling/porn/other/not/so/socially/accepted site! I understand it's doing that to save space, but, really?



Look at all that wasted space that could be used for telling me the comment.

EDIT:- For reference, my commenting convention is:-
Code:
[Buying/Selling] [Product (Such as $50, "Google.com domain name", or, ฿5)] [Payment, such as Credit Card, Bitcoins, PayPal, etc...] [to/from] [alias (SiteIMetThemOnUID=TheirProfileUID] for [What I paid/got, opposite side of the trade as the second argument]

EDIT2:- Actually, while I'm at requesting stuff, a search feature would be nice too, so, I could filter the addresses to just ones that include "Bitcointalk", or, say I traded with "Satoshi" multiple times, I could search for "Satoshi" and find all the "Satoshi" transactions (That have "Satoshi" in the comments).

Actually, I just realized, I should probably actually just code it into Armory myself and then submit a push request, eh? Although, looking at your github history, you don't seem to accept many pull requests.

Please ask for a signed message from my on-site Bitcoin address (Check my profile) before doing any offsite trades with me.
etotheipi
Legendary
*
Offline Offline

Activity: 1428
Merit: 1093


Core Armory Developer


View Profile WWW
March 08, 2014, 12:41:12 AM
 #2

As I like to pay using specific inputs, and, I only know those specific inputs by their comments, seeing this isn't all that useful:-

<img>

Selling $78 PayPal to who Mr. Coin Control!?! I don't want to spend the funds I bought off my real life friend to pay a known gambling/porn/other/not/so/socially/accepted site! I understand it's doing that to save space, but, really?

<img>

Look at all that wasted space that could be used for telling me the comment.

Actually, I had been meaning to update that window to use a proper tableview, which would have customizable field lengths like you want.  It just never made priority, because tableviews require writing a tablemodel, and I was too lazy at the time to set it up all.  It should be done, though.  And wouldn't be hard.


EDIT2:- Actually, while I'm at requesting stuff, a search feature would be nice too, so, I could filter the addresses to just ones that include "Bitcointalk", or, say I traded with "Satoshi" multiple times, I could search for "Satoshi" and find all the "Satoshi" transactions (That have "Satoshi" in the comments).

We'd also like to have that at some point, but it would really complicate the main ledger.  We'd need a separate window that would pop up with the fitered/sorted view.  Again, very doable, just not a priority.  For now, if you really need it, you can export your transaction history from the "File" menu, and then open the output in Excel/OpenOffice to do the searching & sorting.  Obviously, not ideal, but it might be better than nothing.

Actually, I just realized, I should probably actually just code it into Armory myself and then submit a push request, eh? Although, looking at your github history, you don't seem to accept many pull requests.

I typically don't accept pull-requests directly, because most of them are super simple things that I can just fix myself, and I'm also trying to avoid mixing copyrights from a bunch of random people on the internet.  This project is 99.99%+ my own code, yet someone who contributes a couple lines might be able to claim some kind of mixed copyright.  So usually I just fix the bug that they identified in the pull request. 

However, if it's a substantial/large contribution, and you don't mind signing a copyright waiver, we'll happily merge it!  And usually we give a small reward in exchange for the signed waver -- the value is typically very small, but shows our gratitude and makes the waiver more legit (showing that both sides of the agreement are benefitting).

Founder and CEO of Armory Technologies, Inc.
Armory Bitcoin Wallet: Bringing cold storage to the average user!
Only use Armory software signed by the Armory Offline Signing Key (0x98832223)

Please donate to the Armory project by clicking here!    (or donate directly via 1QBDLYTDFHHZAABYSKGKPWKLSXZWCCJQBX -- yes, it's a real address!)
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!