The offshore banks are not offshore anymore. It's not the same as it was before with the international information exchanges program. Maybe less than 10% of the banks are still truly offshore, and you can be sure the percentage will reduce with the years coming.
Also when you have nothing to hide you have no use for an offshore bank account
Yup. Usually, Swiss bank accounts are the ones being used for money laundering and by plunderers who wish to keep their assets away from exposé and being sniffed by their own government, though governments can ask offshore banks to disclose some info regarding statements and balances if they are after one person who may have potentially done something fishy in terms of their finances and wealth.
Interest rates, accompanied with better service is what usually tempt people to open an offshore bank account, though if you're really not doing something bad, or don't really need to have a bank account abroad, why open an offshore one? I can only see an offshore bank being viable if one person intend to travel on the country where their bank account is opened to have easy access to cash and ATMs should they need it.