Bitcoin Forum
May 04, 2024, 03:43:52 PM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: What are the conditions for adding a new reference implementation to a BIP  (Read 198 times)
Coding Enthusiast (OP)
Legendary
*
Offline Offline

Activity: 1039
Merit: 2783


Bitcoin and C♯ Enthusiast


View Profile WWW
March 09, 2019, 07:23:03 AM
Merited by ABCbits (3)
 #1

Generally speaking what kind of conditions should an implementation meet to be added to a BIP as a reference implementation?

Specifically speaking In case of BIPs that already have implementations in certain language listed but the implementation is not so good. (I usually try to contact the developer and get the already existing code fixed but sometimes it is easier to make a new one rather than changing the old code.)

Projects List+Suggestion box
Donate: 1Q9s or bc1q
|
|
|
FinderOuter(0.19.1)Ann-git
Denovo(0.7.0)Ann-git
Bitcoin.Net(0.26.0)Ann-git
|
|
|
BitcoinTransactionTool(0.11.0)Ann-git
WatchOnlyBitcoinWallet(3.2.1)Ann-git
SharpPusher(0.12.0)Ann-git
1714837432
Hero Member
*
Offline Offline

Posts: 1714837432

View Profile Personal Message (Offline)

Ignore
1714837432
Reply with quote  #2

1714837432
Report to moderator
1714837432
Hero Member
*
Offline Offline

Posts: 1714837432

View Profile Personal Message (Offline)

Ignore
1714837432
Reply with quote  #2

1714837432
Report to moderator
Make sure you back up your wallet regularly! Unlike a bank account, nobody can help you if you lose access to your BTC.
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
1714837432
Hero Member
*
Offline Offline

Posts: 1714837432

View Profile Personal Message (Offline)

Ignore
1714837432
Reply with quote  #2

1714837432
Report to moderator
odolvlobo
Legendary
*
Offline Offline

Activity: 4298
Merit: 3214



View Profile
March 11, 2019, 07:16:35 AM
 #2

Generally speaking what kind of conditions should an implementation meet to be added to a BIP as a reference implementation?

Specifically speaking In case of BIPs that already have implementations in certain language listed but the implementation is not so good. (I usually try to contact the developer and get the already existing code fixed but sometimes it is easier to make a new one rather than changing the old code.)

BIPs are published on github (https://github.com/bitcoin/bips). Here is what the README says about submitting or modifying a BIP:

Quote
People wishing to submit BIPs, first should propose their idea or document to the bitcoin-dev@lists.linuxfoundation.org mailing list. After discussion, please open a PR. After copy-editing and acceptance, it will be published here.

Join an anti-signature campaign: Click ignore on the members of signature campaigns.
PGP Fingerprint: 6B6BC26599EC24EF7E29A405EAF050539D0B2925 Signing address: 13GAVJo8YaAuenj6keiEykwxWUZ7jMoSLt
Coding Enthusiast (OP)
Legendary
*
Offline Offline

Activity: 1039
Merit: 2783


Bitcoin and C♯ Enthusiast


View Profile WWW
March 11, 2019, 08:36:50 AM
 #3

@odolvlobo
That is not what I was looking for, I am not planning on modifying the BIP itself or submit a new one. Just the "implementations".
For example these are reference implementations for bech32 encoding, it lacks c#, or this has only one c# implementation and is pretty bad (IMO) because of its unnecessary complications.
So my question is if I wanted to submit my BIP39 implementation which I already have or maybe if I wanted to add the bech32 that doesn't exist, what are the things that I should consider? For example of the top of my head should it only be implementation of that particular BIP or can it be part of the bigger library having other stuff?

Projects List+Suggestion box
Donate: 1Q9s or bc1q
|
|
|
FinderOuter(0.19.1)Ann-git
Denovo(0.7.0)Ann-git
Bitcoin.Net(0.26.0)Ann-git
|
|
|
BitcoinTransactionTool(0.11.0)Ann-git
WatchOnlyBitcoinWallet(3.2.1)Ann-git
SharpPusher(0.12.0)Ann-git
odolvlobo
Legendary
*
Offline Offline

Activity: 4298
Merit: 3214



View Profile
March 11, 2019, 09:26:27 AM
 #4

@odolvlobo
That is not what I was looking for, I am not planning on modifying the BIP itself or submit a new one. Just the "implementations".
For example these are reference implementations for bech32 encoding, it lacks c#, or this has only one c# implementation and is pretty bad (IMO) because of its unnecessary complications.
So my question is if I wanted to submit my BIP39 implementation which I already have or maybe if I wanted to add the bech32 that doesn't exist, what are the things that I should consider? For example of the top of my head should it only be implementation of that particular BIP or can it be part of the bigger library having other stuff?

I assume that you would change the BIP and include links to your implementations. Anyway, if you can't get a good answer to your questions, you might contact luke-jr. He maintains the BIPs.

Join an anti-signature campaign: Click ignore on the members of signature campaigns.
PGP Fingerprint: 6B6BC26599EC24EF7E29A405EAF050539D0B2925 Signing address: 13GAVJo8YaAuenj6keiEykwxWUZ7jMoSLt
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!