Bitcoin Forum
December 01, 2021, 03:18:12 PM *
News: Latest Bitcoin Core release: 22.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: Remove Of AES-128 Code  (Read 168 times)
MagicByt3
Sr. Member
****
Offline Offline

Activity: 868
Merit: 435


<Insert No Fucks Given Here>


View Profile
June 10, 2019, 09:47:03 AM
 #1

I have been keeping eyes on the taproot development over on git and noticed this edit to the code.

Remove unused AES-128 code
https://github.com/sipa/bitcoin/commit/edc68d40e9689f74f4cdfba010691e9811786086

I wanted to know more about this removal and why some parts have been left and some have been removed also the explanation of the remove leave much to the imagination.

after looking back at some of the earlier code base it seems this feature was used in development for derivation path?

http://btc.yt/lxr/satoshi/ident?v=0.3.23&_i=SetKeyFromPassphrase&%21v=0.5.2

Code:
CCrypter::SetKeyFromPassphrase(const SecureString& strKeyData, const std::vector<unsigned char>& chSalt, const unsigned int nRounds, const unsigned int nDerivationMethod)

Why remove this code?
What effect will remove have (i.e what will the remove of the code effect or stop the use of)

Thanks  Wink

"If you don't believe it or don't get it, I don't have the time to try to convince you, sorry". Satoshi Nakamoto
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1638371892
Hero Member
*
Offline Offline

Posts: 1638371892

View Profile Personal Message (Offline)

Ignore
1638371892
Reply with quote  #2

1638371892
Report to moderator
1638371892
Hero Member
*
Offline Offline

Posts: 1638371892

View Profile Personal Message (Offline)

Ignore
1638371892
Reply with quote  #2

1638371892
Report to moderator
1638371892
Hero Member
*
Offline Offline

Posts: 1638371892

View Profile Personal Message (Offline)

Ignore
1638371892
Reply with quote  #2

1638371892
Report to moderator
achow101
Moderator
Legendary
*
expert
Offline Offline

Activity: 2646
Merit: 4354


Just writing some code


View Profile WWW
June 10, 2019, 08:24:46 PM
Merited by Foxpup (2)
 #2

What are you talking about? SetKeyFromPassphrase appears to be completely unrelated to this code.

AES-128 was removed because it is not being actively used. It's removal has no effect on Bitcoin Core, the wallet, or the security of the wallet. Removing it doesn't stop anything, it just cleans up the codebase so that there isn't some unused stuff.

MagicByt3
Sr. Member
****
Offline Offline

Activity: 868
Merit: 435


<Insert No Fucks Given Here>


View Profile
June 11, 2019, 09:14:40 AM
 #3

My mistake.

it was the reference to AES256 that I didn't read properly.

The AES-256 code is used in `CCrypter::Encrypt`/`CCrypter::Decrypt` (`src/wallet/cin crypter.cpp`). which is where I picked up the relation.

Thank for clearing that up.

"If you don't believe it or don't get it, I don't have the time to try to convince you, sorry". Satoshi Nakamoto
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!