Bitcoin Forum
November 16, 2024, 04:23:36 AM *
News: Check out the artwork 1Dq created to commemorate this forum's 15th anniversary
 
   Home   Help Search Login Register More  
Bitcoin Forum > Bitcoin > Development & Technical Discussion > Why was the 6th ServiceFlags bit skipped?
Pages: [1]
« previous topic next topic »
  Print  
Author Topic: Why was the 6th ServiceFlags bit skipped?  (Read 85 times)
Coding Enthusiast (OP)
Legendary
*
Offline Offline

Activity: 1043
Merit: 2818


Bitcoin and C♯ Enthusiast


View Profile WWW
October 12, 2020, 03:41:25 PM
Merited by Welsh (3), ABCbits (1), Heisenberg_Hunter (1), darosior (1)
 #1
The ServiceFlags enum is jumping from the previously defined 5th bit (1 << 4 ie XThin) to 7th bit (1 << 6 ie CompactFilters). I couldn't find the 6th bit ever being set in the history of protocol.h file so is there any reason for this jump?

https://github.com/bitcoin/bitcoin/blob/af22322dab1a2277483b2512723491a5fad1a606/src/protocol.h#L268-L302
Projects List+Suggestion box
Donate: 1Q9s or bc1q
|
|
|
FinderOuter(0.20.0)Ann-git
Denovo(0.7.0)Ann-git
Bitcoin.Net(0.26.0)Ann-git
|
|
|
BitcoinTransactionTool(0.11.0)Ann-git
WatchOnlyBitcoinWallet(3.2.1)Ann-git
SharpPusher(0.12.0)Ann-git
achow101
Moderator
Legendary
*
expert
Offline Offline

Activity: 3542
Merit: 6886


Just writing some code


View Profile WWW
October 12, 2020, 03:51:54 PM
Merited by Welsh (6), ABCbits (2), Coding Enthusiast (2), Heisenberg_Hunter (1), darosior (1)
 #2
It's because both Bcash and Segwit2x occupied some service bits to indicate their own forks while they were still able to connect to Bitcoin nodes.

Bcash was using bit 6, and Segwit2x was using bit 8. Both bits thus needed to be skipped for some time to avoid collisions. See https://github.com/bitcoin/bitcoin/pull/10982
Bitcoin Core contributor | Tip Me! | GitHub | GPG Key Fingerprint 0x17565732E08E5E41
Pages: [1]
  Print  
Bitcoin Forum > Bitcoin > Development & Technical Discussion > Why was the 6th ServiceFlags bit skipped?
 « previous topic next topic »
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!