I ask you to help me compile the project.

[Noname400]

Good afternoon, dear masters.
I ask you to help me compile the project.

I'm certainly not a master, but I understand something and I compiled the version for CUDA.
but I can not compile the option for OPENCL

I ask for help.

https://github.com/djarumlights/BitCrack

[NotATether]

How are you trying to compile this? On Linux, or Windows with Visual Studio, or Windows with MinGW/Msys2?

If Linux, what is the distribution you are compiling on?

On Linux there are extra packages that need to be installed for the OpenCL development headers. On Windows the OpenCL support is usually provided by the graphics driver.

[Noname400]

I was compiling on VS 2019
under Windows. All necessary libraries are.

ERROR:
E0322 use of object of abstract type of class "CLKeySearchDevice" is not allowed: clKeyFinder
C2259 "CLKeySearchDevice": unable to instantiate abstract class clKeyFinder

[NotATether]

I was compiling on VS 2019
under Windows. All necessary libraries are.

ERROR:
E0322 use of object of abstract type of class "CLKeySearchDevice" is not allowed: clKeyFinder
C2259 "CLKeySearchDevice": unable to instantiate abstract class clKeyFinder

I have isolated problem to some file in the CLKeySearchDevice project. E0322 implies that some line is running clKeyFinder = CLKeySearchDevice(...)

I wanted to compile this myself to see the build logs but I've been having trouble installing OpenCL headers (CPU only, my servers have no GPUs to test on). I'll see if I can get them working later today.

[Noname400]

I am very grateful for your help.
I rechecked the code again. no reason.
the same file is compiled for different platforms. (KeyFinder -> clKeyFinder -> cuKeyFinder)

[NotATether]

I am very grateful for your help.
I rechecked the code again. no reason.
the same file is compiled for different platforms. (KeyFinder -> clKeyFinder -> cuKeyFinder)

If you clone the parent repository https://github.com/ByLamacq/BitCrack, does it compile successfully?

Because I have previously compiled brichard19's BitCrack repository on Linux successfully (after adding a library to the MakeFile, but that's not my point). That means we know it's a known good version.

If you can successfully compile ByLamacq's fork then we know for starters that one of djarumlights' commits introduced the build error.

Otherwise it is one of the commits made by ByLamacq that doesn't work.


I don't think there are any source code differences between the Windows and Linux compilation, both should be running exactly the same C++ code so if for whatever reason I can't get OpenCL libraries on Windows then I will see if I can reproduce the error on my Linux box.

[Noname400]

"ByLamacq"  - going without problems.
everything works great!

[Noname400]

I'm not a master, but I'm not dumb. But I can't understand why the code doesn't compile ... OMG!

[NotATether]

Dumped from my error log:

Severity   Code   Description   Project   File   Line   Suppression State
Error   C2259   'CLKeySearchDevice': cannot instantiate abstract class   clKeyFinder   E:\Source\Repos\BitCrack\KeyFinder\main.cpp   253   

This is the context around the failing line:

Code:

#ifdef BUILD_OPENCL
    if(device.type == DeviceManager::DeviceType::OpenCL) {
        return new CLKeySearchDevice(device.physicalId, threads, pointsPerThread, blocks);   # line 253
    }
#endif

This code is the same for all three repos. It means this fork has a virtual method in CLKeySearchDevice\CLKeySearchDevice.cpp that was removed, and if there's an unimplemented virtual method in C++ then it becomes an abstract class.

I'll continue inspecting tomorrow.

[Noname400]

https://github.com/ByLamacq/BitCrack - I have compiled without problems.
forks on the tree below give an error only in OPENCL.
made comparisons of the source code, while I can not understand the reason.

[NotATether]

Now I have OpenCL headers properly configured. It looks like there's more information if I make Visual Studio display the informational messages too.

Code:

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2259	'CLKeySearchDevice': cannot instantiate abstract class	clKeyFinder	E:\Source\Repos\BitCrack\KeyFinder\main.cpp	254	
Message		see declaration of 'KeySearchDevice::init'	clKeyFinder	E:\Source\Repos\BitCrack\KeyFinderLib\KeySearchDevice.h	42	
Message		'void KeySearchDevice::init(const secp256k1::uint256 &,const secp256k1::uint256 &,int,const secp256k1::uint256 &,bool)': is abstract	clKeyFinder	E:\Source\Repos\BitCrack\KeyFinder\main.cpp	254	
Message		due to following members:	clKeyFinder	E:\Source\Repos\BitCrack\KeyFinder\main.cpp	254	
Message		see declaration of 'CLKeySearchDevice'	clKeyFinder	E:\Source\Repos\BitCrack\CLKeySearchDevice\CLKeySearchDevice.h	14	

So apparently it's because KeySearchDevice::init is not defined. Maybe it must have been removed by the fork?


Found the problem.

The base class of CLKeySearchDevice, KeySearchDevice has a different init() method signature from the CLKeySearchDevice::init().

Code:

// KeySearchDevice.h

    // Initialize the device
    virtual void init(const secp256k1::uint256 &start, const secp256k1::uint256 &end, int compression, const secp256k1::uint256 &stride, bool randomMode) = 0;

// CLKeySearchDevice.h

    // Initialize the device
    virtual void init(const secp256k1::uint256 &start, int compression, const secp256k1::uint256 &stride);

Notice that end and randomMode parameters are missing from the subclass CLKeySearchDevice. Since KeySearchDevice::init() is abstract (it has = 0 at the end), CLKeySearchDevice::init() does not override it and you get this error.

I think that while the maintainer was updating the CUDA code he forgot to update the classes in the OpenCL classes. We need to modify the code to pass the additional parameters, even if they go unused.

[Noname400]

found the differences. I will rebuild today.
I hope this is it.
it's hard to look for errors in someone else's code (((  

Thank you so much for your time.
I am very grateful that you help me.

[Noname400]

I found the reason.
thank you for your time.
good luck!