Bitcoin Forum
December 03, 2016, 03:59:02 PM *
News: To be able to use the next phase of the beta forum software, please ensure that your email address is correct/functional.
 
   Home   Help Search Donate Login Register  
Pages: [1]
  Print  
Author Topic: Broken links everywhere - is anyone working on this?  (Read 1442 times)
piotr_n
Legendary
*
Offline Offline

Activity: 1498


aka tonikt


View Profile WWW
November 28, 2011, 08:54:36 PM
 #1

Never mind why, but the entire forum is full of broken links which point to http://bitcointalk.org/index.php?topic=... instead of http://bitcointalk.org/index.php?topic=...

It's not something that an average PHP developer wouldn't be able to handle within an hour.
So please, fix all the old links so they'd still work.

Check out gocoin - my original project of a bitcoin client written in Go, with some unique features.
PGP fingerprint: AB9E A551 E262 A87A 13BB  9059 1BE7 B545 CDF3 FD0E
1480780742
Hero Member
*
Offline Offline

Posts: 1480780742

View Profile Personal Message (Offline)

Ignore
1480780742
Reply with quote  #2

1480780742
Report to moderator
1480780742
Hero Member
*
Offline Offline

Posts: 1480780742

View Profile Personal Message (Offline)

Ignore
1480780742
Reply with quote  #2

1480780742
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
tysat
Legendary
*
Offline Offline

Activity: 952


Keep it real


View Profile
November 28, 2011, 09:48:04 PM
 #2

Just out of curiosity, you mind pointing to some of the broken links you're running into? (link to the posts they're in)

I don't think I've seen any for while.
theymos
Administrator
Legendary
*
Offline Offline

Activity: 2492


View Profile
November 28, 2011, 09:56:00 PM
 #3

It's not something that an average PHP developer wouldn't be able to handle within an hour.

Are you volunteering?

1NXYoJ5xU91Jp83XfVMHwwTUyZFK64BoAD
piotr_n
Legendary
*
Offline Offline

Activity: 1498


aka tonikt


View Profile WWW
November 28, 2011, 10:08:41 PM
 #4

@tysat, not to look far, go to this article:
https://bitcointalk.org/index.php?topic=7269.0
.. and click the first link.

@theymos, no problem, but I'd have to change the source code so it's a matter of trust.
just find the function that writes a post into html and add some str_replace there.
anyone can do it Smiley

Check out gocoin - my original project of a bitcoin client written in Go, with some unique features.
PGP fingerprint: AB9E A551 E262 A87A 13BB  9059 1BE7 B545 CDF3 FD0E
tysat
Legendary
*
Offline Offline

Activity: 952


Keep it real


View Profile
November 28, 2011, 10:43:53 PM
 #5

Well got that one updated, not sure how many other posts with broken links there are around (that are still relevant posts).
btc_artist
Full Member
***
Offline Offline

Activity: 154


Bitcoin!


View Profile WWW
November 28, 2011, 10:48:12 PM
 #6

I'll volunteer to help.  It can actually be done with an SQL query, but a simple < 50 line PHP script could easily handle it.

@piotr_n  The problem is not when users submit new posts, it's old links in old posts.  

theymos, I can throw together a quick run-once PHP script to convert the old links to new ones.  Just let me know if you want it.

BTC: 1CDCLDBHbAzHyYUkk1wYHPYmrtDZNhk8zf
LTC: LMS7SqZJnqzxo76iDSEua33WCyYZdjaQoE
btc_artist
Full Member
***
Offline Offline

Activity: 154


Bitcoin!


View Profile WWW
November 28, 2011, 10:50:38 PM
 #7

Well got that one updated, not sure how many other posts with broken links there are around (that are still relevant posts).
If you have access to the database, just run the following to see how many posts have broken links in them.

Code:
SELECT * FROM smf_messages WHERE body LIKE '%http://bitcointalk.org/index.php%'

BTC: 1CDCLDBHbAzHyYUkk1wYHPYmrtDZNhk8zf
LTC: LMS7SqZJnqzxo76iDSEua33WCyYZdjaQoE
btc_artist
Full Member
***
Offline Offline

Activity: 154


Bitcoin!


View Profile WWW
November 28, 2011, 10:54:00 PM
 #8

You could fix the broken links with something like this, but you'd want to test it first before running it on the live database.  It might also change text that wasn't linked.

Code:
UPDATE smf_messages SET body = REPLACE(body, 'http://bitcointalk.org/index.php', 'http://bitcointalk.org/index.php');

BTC: 1CDCLDBHbAzHyYUkk1wYHPYmrtDZNhk8zf
LTC: LMS7SqZJnqzxo76iDSEua33WCyYZdjaQoE
theymos
Administrator
Legendary
*
Offline Offline

Activity: 2492


View Profile
November 29, 2011, 12:19:50 AM
 #9

I don't want to modify the text of any old posts. I'd rather the links be converted during display. Probably best to do it in the same place where linkification happens.

Maybe I'll take a look later if no one else provides the code.

1NXYoJ5xU91Jp83XfVMHwwTUyZFK64BoAD
theymos
Administrator
Legendary
*
Offline Offline

Activity: 2492


View Profile
November 29, 2011, 12:23:04 AM
 #10

Actually, the "censored words" functionality might be sufficient. I set up something (probably broken), and I'll do proper testing in a few hours.

1NXYoJ5xU91Jp83XfVMHwwTUyZFK64BoAD
tysat
Legendary
*
Offline Offline

Activity: 952


Keep it real


View Profile
November 29, 2011, 12:49:04 AM
 #11

Actually, the "censored words" functionality might be sufficient. I set up something (probably broken), and I'll do proper testing in a few hours.

It looks like it is working now... just looked at the links provided above in this post.
theymos
Administrator
Legendary
*
Offline Offline

Activity: 2492


View Profile
November 29, 2011, 03:59:46 AM
 #12

OK, it seems to be working pretty well.

1NXYoJ5xU91Jp83XfVMHwwTUyZFK64BoAD
btc_artist
Full Member
***
Offline Offline

Activity: 154


Bitcoin!


View Profile WWW
November 29, 2011, 05:14:05 AM
 #13

Good deal!

BTC: 1CDCLDBHbAzHyYUkk1wYHPYmrtDZNhk8zf
LTC: LMS7SqZJnqzxo76iDSEua33WCyYZdjaQoE
piotr_n
Legendary
*
Offline Offline

Activity: 1498


aka tonikt


View Profile WWW
November 29, 2011, 10:12:21 AM
 #14

thanks! Smiley

Check out gocoin - my original project of a bitcoin client written in Go, with some unique features.
PGP fingerprint: AB9E A551 E262 A87A 13BB  9059 1BE7 B545 CDF3 FD0E
deepceleron
Legendary
*
Offline Offline

Activity: 1470



View Profile WWW
November 29, 2011, 03:24:09 PM
 #15

Well, now the original post has been "censored" so I can't see what was being talked about. Let's try some stuff:

forum.bitcoin.org

http://forum.bitcoin.org

http://forum.bitcoin.org/index.php?topic=53161.0

Well, I guess those links aren't what was being discussed, as forum.bitcoin.org still redirects here...

Pages: [1]
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!