Bitcoin Forum
May 23, 2024, 05:54:42 AM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: [bug?] New wallet version  (Read 175 times)
pbies (OP)
Full Member
***
Offline Offline

Activity: 252
Merit: 126



View Profile
August 21, 2022, 02:53:38 AM
 #1

Reproduce:

1. create wallet (not descriptor wallet, empty), version created is noted as 10500 in debug.log
2. close the wallet
3. open it once again
4. debug.log says version 169900 for this wallet

BTC: bc1qmrexlspd24kevspp42uvjg7sjwm8xcf9w86h5k
I have 9900K and 1080 Ti, gathering funds for new desktop PC for Bitcoin operations - 12900K and RTX 4090
achow101
Moderator
Legendary
*
expert
Offline Offline

Activity: 3402
Merit: 6642


Just writing some code


View Profile WWW
August 21, 2022, 03:32:53 AM
Merited by hugeblack (4), hosseinimr93 (1), pbies (1)
 #2

That is expected behavior.

A newly created wallet will initially have the version of 10500 before it is subsequently set to the current latest of 169900. The logging happens before that update.

NotATether
Legendary
*
Online Online

Activity: 1610
Merit: 6754


bitcoincleanup.com / bitmixlist.org


View Profile WWW
August 21, 2022, 03:48:57 AM
 #3

A newly created wallet will initially have the version of 10500 before it is subsequently set to the current latest of 169900. The logging happens before that update.

Are there plans to introduce a second debug message after the update that says something like "Wallet <xyz> has been changed from version 123 to 456"?

.
.BLACKJACK ♠ FUN.
█████████
██████████████
████████████
█████████████████
████████████████▄▄
░█████████████▀░▀▀
██████████████████
░██████████████
████████████████
░██████████████
████████████
███████████████░██
██████████
CRYPTO CASINO &
SPORTS BETTING
▄▄███████▄▄
▄███████████████▄
███████████████████
█████████████████████
███████████████████████
█████████████████████████
█████████████████████████
█████████████████████████
███████████████████████
█████████████████████
███████████████████
▀███████████████▀
█████████
.
achow101
Moderator
Legendary
*
expert
Offline Offline

Activity: 3402
Merit: 6642


Just writing some code


View Profile WWW
August 21, 2022, 03:42:48 PM
Merited by hugeblack (2), NotATether (1)
 #4

Are there plans to introduce a second debug message after the update that says something like "Wallet <xyz> has been changed from version 123 to 456"?
PRs welcome.

NotATether
Legendary
*
Online Online

Activity: 1610
Merit: 6754


bitcoincleanup.com / bitmixlist.org


View Profile WWW
August 21, 2022, 09:09:04 PM
Merited by ABCbits (3), n0nce (1)
 #5

Are there plans to introduce a second debug message after the update that says something like "Wallet <xyz> has been changed from version 123 to 456"?
PRs welcome.

Pull request submitted.

.
.BLACKJACK ♠ FUN.
█████████
██████████████
████████████
█████████████████
████████████████▄▄
░█████████████▀░▀▀
██████████████████
░██████████████
████████████████
░██████████████
████████████
███████████████░██
██████████
CRYPTO CASINO &
SPORTS BETTING
▄▄███████▄▄
▄███████████████▄
███████████████████
█████████████████████
███████████████████████
█████████████████████████
█████████████████████████
█████████████████████████
███████████████████████
█████████████████████
███████████████████
▀███████████████▀
█████████
.
NotATether
Legendary
*
Online Online

Activity: 1610
Merit: 6754


bitcoincleanup.com / bitmixlist.org


View Profile WWW
August 22, 2022, 04:26:22 PM
 #6

@achow101:

I'm not familiar with Bitcoin Core's PR merging process. How long does it take on average for somebody to review a commit and [N]ACK it?

[yes, I double posted 20 hours later, but I didn't want to leave this until 23:30 UTC+3 because I'll probably be asleep by then]

.
.BLACKJACK ♠ FUN.
█████████
██████████████
████████████
█████████████████
████████████████▄▄
░█████████████▀░▀▀
██████████████████
░██████████████
████████████████
░██████████████
████████████
███████████████░██
██████████
CRYPTO CASINO &
SPORTS BETTING
▄▄███████▄▄
▄███████████████▄
███████████████████
█████████████████████
███████████████████████
█████████████████████████
█████████████████████████
█████████████████████████
███████████████████████
█████████████████████
███████████████████
▀███████████████▀
█████████
.
achow101
Moderator
Legendary
*
expert
Offline Offline

Activity: 3402
Merit: 6642


Just writing some code


View Profile WWW
August 22, 2022, 11:56:29 PM
 #7

I'm not familiar with Bitcoin Core's PR merging process. How long does it take on average for somebody to review a commit and [N]ACK it?
Depends on how complicated and how many people care. It can be anywhere from a few hours to a few years.

NotATether
Legendary
*
Online Online

Activity: 1610
Merit: 6754


bitcoincleanup.com / bitmixlist.org


View Profile WWW
August 27, 2022, 07:45:25 AM
 #8

Are there plans to introduce a second debug message after the update that says something like "Wallet <xyz> has been changed from version 123 to 456"?
PRs welcome.

Pull request submitted.

This PR has been merged so this thread can be locked now.

.
.BLACKJACK ♠ FUN.
█████████
██████████████
████████████
█████████████████
████████████████▄▄
░█████████████▀░▀▀
██████████████████
░██████████████
████████████████
░██████████████
████████████
███████████████░██
██████████
CRYPTO CASINO &
SPORTS BETTING
▄▄███████▄▄
▄███████████████▄
███████████████████
█████████████████████
███████████████████████
█████████████████████████
█████████████████████████
█████████████████████████
███████████████████████
█████████████████████
███████████████████
▀███████████████▀
█████████
.
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!