Skipping to the next/previous post within a topic by the same author (SMF patch)

[LoyceV]

Am I to do something to enable this?

It's up to Admin to apply patches.

[1714636130]

1714636130

[1714636130]

1714636130

[1714636130]

1714636130

[1714636130]

1714636130

[PowerGlove]

@PawGo: Please respond to post #14. I thought very carefully about security before posting any code, and I resent the lazy security review you left on page 1. Either tell me specifically what you think I missed, without vague references or admit that you jumped the gun and didn't actually read/understand the code before you posted.

Am I to do something to enable this? 'OP' patch was directly shown without doing anything on my part. Is it cause I'm on mobile?

Don't worry, there's no way for you to enable this at the moment. It's just a proposal right now; if theymos accepts the patch then you'll see it automatically, just like last time.

Wow I would love to have this feature and I’m sure all those who have been to WO they will love this the most.

Yeah, I have my own reasons for liking it, but I also very much had the WO folks in mind when I decided to start working on this; it's a feature that really shines in megathreads!

This is a fantastic addition that I would love to see. It would be more useful to bounty sections because the manager would be able to easily track weekly reports because you only need to be on the user's first comment to navigate to the last page without having to scroll the entire page.

I'm happy you think it will be useful! I was getting discouraged after the first few responses (except LoyceV's). It was looking bleak there, for a minute.

[PawGo]

$param_topic, $param_user and $param_message are all forced to integer values, $gt_lt can only be '>' or '<', $direction can only be 'DESC' or empty. If you can see something that I can't, then please point it out, I would appreciate it!

Yes, my fault, I have missed that cast to int. As I am allergic to variables encoded in queries, it blinded me and I haven't seen the whole picture. As a penance I will listen 10 times "The Best of Bryan Adams". 
But still take a look, maybe using prepared statement would give a (marginal) benefit.

[PowerGlove]

Yes, my fault, I have missed that cast to int. As I am allergic to variables encoded in queries, it blinded me and I haven't seen the whole picture.

Yep, I sympathize; that query being safe is not obvious at first glance.

As a penance I will listen 10 times "The Best of Bryan Adams".  

That's too much self-flagellation for an honest mistake, maybe just one listen to Michael Bublé's christmas album.

But still take a look, maybe using prepared statement would give a (marginal) benefit.

They improved things in later versions, but putting together SQL queries by string interpolation is canonical on this old version of SMF.

[PowerGlove]

I left a half-joking line in the initial post about being preemptively annoyed that people (and ajaxtempest specifically) would probably ask for up/down arrows instead of left/right ones. I just want to add some context to that, in case it rubbed anyone the wrong way or gave off the impression that I don't appreciate feedback: One thing that may not be obvious to anyone watching from home is that when I do these patches, I'm working within the confines of an existing scaffolding of HTML/CSS/PHP that I'm trying to disturb as little as possible. Because of this, there are often only a small handful of possible design decisions that "make sense". I also like to keep the patches as small as I'm able to, because I believe that theymos is more likely to accept them that way. Please keep that in mind if my approach to feedback ever seems standoffish, because I definitely do appreciate feedback, but it's not always possible to apply (given the constraints).

Would it take more than a line break in the "report to moderator" button (so it stays at the very bottom) and one in those two buttons to make it vertical though?

<br> works for HTML, I'm not sure if there's something for it on php or if this would be too much adapting for the stylesheet.

Yep, after LoyceV's input (which I misunderstood) I tried experimenting with line breaks in various places and in various ways, and while a few attempts did kind of work, there were always layout and spacing artifacts that made things look a little too messy. I also played around with some other techniques, like inline styles applied to different combinations of container elements, but those experiments also only produced results that kind of worked and had their own layout and spacing problems. Because horizontally laid out left/right arrows make just as much sense (to me) as vertically laid out up/down arrows, I gave up after that.

Adding numbers between the two arrows (Next and Prev) to easily see the number of posts by the user will easily solve this and allow the user to easily refer to his previous post. For example, (as I mentioned in my 2 (second) post that......) this is just my 0.004 cent.

That's a good idea, I like it! Unfortunately, it would require the kind of "eager" database lookups that I'm trying to avoid (details in initial post).

[Pmalek]

If the codes you wrote are 100% ready for deployment and it wouldn't mess with any other forum features, why not!? I say add it theymos. 

I often use "CTRL-F username", and this would be easier. To search for a user's posts, I use "show All" to search more pages at once, but that's not possible for very large topics.

I did that as well in the past. But I think it was you who told me about a better way. Instead of doing a "CTRL + F + username" search, I now do "CTRL + F + Activity count" of that user. There is a benefit to doing that. "CTRL + F + username" also highlights every time that person was quoted in the thread. But unless someone else has the exact same activity points, "CTRL + F + Activity count" is better. And if we are searching for posts written by the OP, thanks to PowerGlove, we can now run a search for "(OP)".

[ajaxtempest]

Peekaboo!

Thanks so much OP for your hardwork. I visited this forums after many months and was pleased that this thread was created. Hope to see its full implementation one day!