Need help moving BTC to exchange (Transaction stuck confirming for 48+ hours)

[Pmalek]

That's a P2P exchange between you and another person. It should work as long as you understand the risks and make sure you received the money before releasing your coins. I don't use Binance but my guess is that there should also be a traditional spot exchange available where you can trade your BTC for fiat using Binance's provided rates. This is the first google result on that search query: How to Convert & Sell Bitcoin for Cash

I am a little confused why your Binance account holds USDT and not bitcoin? What happened with your bitcoin? Did you swap it for USDT?
You may also want to pay attention to not revealing sensitive information about yourself. On that screenshot you posted, we can see both your name and the name of the person you traded with. 

[un_rank]

Edit: I think I have arrived at the same page where im doing P2P transfer
...

You should not add screenshots like that, it shows personal names of parties involved in the transaction, that is terrible for your privacy. You should edit the screenshot out of the post.
The rate for USDT looks to be high but its P2P so I will assume there are other reasons you chose to trade with that person. Always confirm receipt of the funds from your end before releasing, do not trust the buyers proof.

What would have happened if i didn't set an optimal fee?  Could the transaction be stuck for months?  I am using Electrum 4.5.5

It would have remained on the network till majority of nodes have dropped it from their mempool. It could still be rebroadcasted by some so there is no specific length of time. The default mempool retention period is 2 weeks.

- Jay -

[Pmalek]

It would have remained on the network till majority of nodes have dropped it from their mempool. It could still be rebroadcasted by some so there is no specific length of time. The default mempool retention period is 2 weeks.

The problem is that rebroadcasting by some nodes can create an endless loop where the now rebroadcasted transaction keeps showing up over and over again even in the mempools of nodes that dropped it. The best thing to do is to wait until the transaction drops below the purging rate, then find an Electrum server that dropped it, which should allow you to cancel it.   

[nc50lc]

Edit: I think I have arrived at the same page where im doing P2P transfer

This is the best/correct way to do it right?  This is the way i did it last time

https://imgur.com/a/uNQ0aou

Quite, Binance's P2P is one way to sell your Bitcoins, yes.
But in P2P, the Bank transfer that the seller supposed to do is out of your and Binance's control so be careful when proceeding to release your Bitcoins.
The danger here is if you've released the Bitcoins and seller suddenly reversed the bank transfer, so make sure to select a reputable seller with good reviews for high value transactions.

BTW, discussion about trading your deposited BTC is quite off-topic to your OP.

-snip-

What would have happened if i didn't set an optimal fee?  Could the transaction be stuck for months?  I am using Electrum 4.5.5
-snip-

Nah, I just added it just because it could've taken more hours/days to be confirmed since you can't use the free accelerator.
In any case, Electrum automatically opt-in the transactions it create with rbf-flag,
So if ever, you can replace it with a higher fee rate transaction with "increase fee" right-click menu.