@PowerGlove do you think this highlight could be improved?
Ha! In the original patch, I actually
disabled the existing locked-topic warning and left this comment:
// Skip this if we're in the context of a "peek" request. (This warning *seems* germane in this context, but it's not: the whole point of "peek" requests is to allow messages to be inspected from inside locked topics, so warning the user about something that they already know, and against an action that they're unable to take, is pretty silly.)In hindsight, there's a (human-shaped) hole in that rationale, so I think theymos was right to add a notice. Personally, I'm happy with the current placement/style, but if I go
hunting for something to improve in that area, then I suppose it would be harder to miss (and perhaps more logical) if it were closer to where the "Post" and "Preview" buttons would have been, like this:
(That just involves taking the existing
<tr> for that notice, and moving it to the end of its containing
<table>, and then changing
align="left" to
align="middle" on the second child
<td>.)
My point of view: Ignoring edge cases like the topic becoming locked
while you were already browsing it, I struggle to see how someone could miss both the padlock icon
before entering the topic, and the gray-instead-of-blue quote button with the "Inspect message" tooltip (and the "Inspect message" page title, and the notice that theymos added, too)... If you (the proverbial "you", not you specifically, obviously) often find yourself in a position where you've blown past all that, and end up confused, then I'll stop just shy of calling you an
idiot, but, chances are good that you should do some introspection around your posting habits, because being blissfully unaware of whether or not a given topic has run its course is something I can only imagine repeatedly happening to someone that posts a lot of donkey twaddle.