[BOUNTY 0.03/bug] Help test next major release of Armory! (0.91.1)

[etotheipi]

Find bugs in Armory 0.91.1, get 0.03 BTC!

This thread used to be for the 0.91 release, but I'm going to piggyback on it for for 0.91.1 because it's basically the same release, but with some minor tweaks.  Nothing substantial should've changed, except for the bug reporting and wallet-corruption handling.  This was born out of a couple reports of wallet corruption that were not being handled well by Armory in 0.91, and we had to not only improve it but add a way for users to submit their wallet recovery logs for review.  

Given that this will be pretty boring, I've upped the bounty to 0.03 BTC (~$15) per bug.  I will pay out all bounties for the original 0.91 testing and this round at the same time.  I expect this round won't be very long, and the same rules apply -- you must be the first to post it, and it must be something that isn't totally trivial.  But we're not going to be stingy about it -- we need testers more than we need to save $15 on this bounty!

This release might require explicit digging for bugs.  There might a few pieces of low-hanging fruit, but beyond that you're going to have explicitly test some of the less-commonly-used functionality (importing, sweeping, rebuilding, making & restoring backups, etc).  

  Armory 0.91.1-rc3 for Windows XP, Vista, 7, 8+ 32- and 64-bit
  Armory 0.91.1-rc3 for Ubuntu 12.04+ 32bit
  Armory 0.91.1-rc3 for Ubuntu 12.04+ 64bit
  Armory 0.91.1-rc3 for Raspbian armhf
  Armory 0.91.1-rc3 for MacOSX 10.7+ 64bit


  Armory 0.91.1-rc3 Offline Bundle for Ubuntu 12.04 32bit
  Armory 0.91.1-rc3 Offline Bundle for Ubuntu 12.04 64bit
  Armory 0.91.1-rc3 Offline Bundle for Raspbian (armhf)

  Armory 0.91.1-rc3:  Signed hashes of all installers

Note:  The RPi regular build works just fine (as far as I can tell).  However the RPi offline bundle is still a work in progress.  No guarantees it works for as advertised!



---- ORIGINAL 0.91 TESTING DESCRIPTION ----

We finally have a stable version of what is soon to become Armory 0.91-beta.  We just put out a testing release (link below) and want to encourage people to help test by offering coins for your time. We are aware of a few quirks with the latest version, but nothing serious, all just usability/convenience/interface issues.  We will pay out for the obvious ones, as long as you're the first!

https://bitcointalk.org/index.php?topic=522866.0

See post above for details on the new version.  Here's a few highlights:
-- Major fix for 99%-scanning crashing bug, and general performance improvements
-- Solid OSX support including 10.9.1 and 10.9.2 (we think!)
-- Torrent download for initial network sync (only in auto-bitcoind mode)
-- New announcement system and secure downloader
-- Binaries for RaspberryPi (armhf)!


All bounty payout decisions are final!  We're not going to be stingy about bounties, but we do have to be reasonable.  We have done this in the past and no one complained.  Let's keep it up!

[1714578035]

1714578035

[1714578035]

1714578035

[1714578035]

1714578035

[1714578035]

1714578035

[qnxt]

Not sure if this counts as a bug in Armory itself...but the OS X tarfile gives a 403 error.

--2014-03-30 20:12:26--  https://s3.amazonaws.com/bitcoinarmory-testing/armory_0.90.99.5-testing_osx.tar.gz
Resolving s3.amazonaws.com... 176.32.97.242
Connecting to s3.amazonaws.com|176.32.97.242|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2014-03-30 20:12:26 ERROR 403: Forbidden.

I also can't download it from within 0.90.99.4, because it crashes when I try to use the secure downloader.

I can download all other versions fine from the urls in your other post. Please chmod the OS X version.

[etotheipi]

Not sure if this counts as a bug in Armory itself...but the OS X tarfile gives a 403 error.

--2014-03-30 20:12:26--  https://s3.amazonaws.com/bitcoinarmory-testing/armory_0.90.99.5-testing_osx.tar.gz
Resolving s3.amazonaws.com... 176.32.97.242
Connecting to s3.amazonaws.com|176.32.97.242|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2014-03-30 20:12:26 ERROR 403: Forbidden.

I also can't download it from within 0.90.99.4, because it crashes when I try to use the secure downloader.

I can download all other versions fine from the urls in your other post. Please chmod the OS X version.

It was actually a bad filename.  I just updated the post on the testing thread with the correct link.

[qnxt]

Minor cosmetic error. On first opening 0.90.99.5, I'm presented with an out-of-date notice:

"New Testing Version 0.90.99.5
You are using version 0.90.99.5"

The announcements tab does show that I'm using the latest version under "Software Version Updates".

Edit: And another minor problem with the OS X download. I tried using the "secure downloader" to grab the same version. But it also has the url with "osx" instead of "OSX" in the filename. That's obviously not much of an issue, but it doesn't handle the 403 error correctly: it tells me that the download completed, but that the signature was invalid. (When it didn't actually download anything.)

The secure downloader also fails to detect my OS at all (OS X 10.9.2), giving me a warning then letting me manually select.

[etotheipi]

I just explicitly tested the version check, and I didn't get a notification on 0.90.99.5.  Apparently I did something wrong.  Will have to check that it's respecting the min/max versions in the notifications.

As for it failing to download the OSX version, I was using an outdated announcement file when renaming the downloads.  Whoops.  Will be fixed in a minute (just going to put two copies there, one with each name).

[qnxt]

Another cosmetic bug...if I select "Use an existing address for change", the text above becomes squished and unreadable.

It almost looks like I blanked it myself for security, but I didn't!

https://i.imgur.com/xv3S2RO.png

Also on that screen: when I use the + or - Recipient buttons, the list resets to the top. Not really a big deal, but it'll make adding a bunch of addresses annoying, scrolling down for each one.

I haven't found any functional bugs yet, which is good!

Edit: Another nitpick. The About box lists the copyright date as 2011-2013. Shouldn't that be 2011-2014?

[george51]

https://i.imgur.com/MIi6tbe.jpg

This may only be a small bug - It says its out-of-date when I've got the most recent version. Also when I downloaded it - and selected my OS (windows 8.1) there was no option to select the new version.

[ncs0ne]

I cannot export transactions any more.

I tried "Help-> Rebuild and Rescan Databases" with a restart afterwards as well, but it doesn't help.
btw: I'm deeply impressed by the startup speed increase 

Code:

2014-03-31 12:50 (ERROR) -- Traceback (most recent call last):
  File "/usr/lib/armory/qtdialogs.py", line 8778, in accept
    if self.createFile_CSV():
  File "/usr/lib/armory/qtdialogs.py", line 8856, in createFile_CSV
    f.write('Export Date:, %s\n' % unixTimeToFormatStr(RightNow()))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 20: ordinal not in range(128)

[idoB]

UI Issue:
when generating new receive address and choosing 'create clickable link' - the resulting form is cut out at the top and the only way I can get it to fully display is by resizing it - it then pops down and displays correctly. For example:

[Brangdon]

It was actually a bad filename.  I just updated the post on the testing thread with the correct link.

It's also wrong in the Secure Downloader for Windows, I think.

I got an announcement in Armory itself, which led to the Help/Update Armory dialog. 0.90.99.5 is listed for WinXP, Vista, Win7 and Win8, both 32-bit and 64-bit, but none of them actually work. It's not listed at all for Win8.1.

Edit: I've now downloaded manually from the link. I notice that the installer defaulted to C:, rather than the location I the previous Armory is at, which is D:. Is that intentional?

[Brangdon]

(1) The scroll bars on the dashboard message have a problem. When I try to scroll down, it jumps back up. I think it wants to keep the "Armory is offline" message visible at the top.

This is on WinXP - it installs and works there now. My screen on that machine is only 600 pixels high, so without the scroll bars I can't read the rest of the message. My Win8.1 install doesn't have this issue, not even if I make the Dashboard window small. However, it is online, so it's displaying a different message.

(2) My Win8.1 Armory thinks it is online despite not having an internet connection - is that correct? It is running Bitcoin Core and has synchronised blocks etc, but won't be seeing new transactions and probably won't be broadcasting them either, because I've disabled my network adaptor. I can't access Google. I guess that the internet part is done by Bitcoin Core, so Armory doesn't know its status, but it's a bit confusing to be told it is online when it isn't.

[etotheipi]

(1) The scroll bars on the dashboard message have a problem. When I try to scroll down, it jumps back up. I think it wants to keep the "Armory is offline" message visible at the top.

This is on WinXP - it installs and works there now. My screen on that machine is only 600 pixels high, so without the scroll bars I can't read the rest of the message. My Win8.1 install doesn't have this issue, not even if I make the Dashboard window small. However, it is online, so it's displaying a different message.

(2) My Win8.1 Armory thinks it is online despite not having an internet connection - is that correct? It is running Bitcoin Core and has synchronised blocks etc, but won't be seeing new transactions and probably won't be broadcasting them either, because I've disabled my network adaptor. I can't access Google. I guess that the internet part is done by Bitcoin Core, so Armory doesn't know its status, but it's a bit confusing to be told it is online when it isn't.

Whoops, we forgot to fix the dashboard scrolling thing.  Definitely a bounty for that one.  Also ,I stupidly didn't include Windows 8.1 in the new download list, even though it should be included.  We plan to remove the OS sub-version fields in the future, and have a better system for linking downloads to OS.  But this version will keep it, for now. 

Not sure what's up with the download links.  I just tested it on my system and can download Windows installers fine.  Can you make sure you have the latest announcments by clicking the "Check for Updates" button on the "Announcements" tab?

As for where it's installed... that's good point we haven't thought about.  The installer should probably detect where the previous installation is and default to that.  Not sure how to do it but we can look into it.

[donut]

Secure Downloader bug: There is no 64-bit version available for Windows 8.1 (but everything is available for 8):

https://i.imgur.com/WtLQuuJ.png

Also, it couldn't detect the fact that I have Windows 8.1 x64 for some reason.


It complains about the version being "outdated" on every startup and offers to upgrade... to the same version.

[etotheipi]

Okay, so far we have in the queue for fixing:

• Auto-detect OS in secure downloader
• Respect version-range of notifications w.r.t to current version
• Add Windows 8.1 to the next notification set
• Dashboard scroll-reset issue when in offline mode
• Export transactions to CSV needs to work with unicode
• Update "About" window with proper copyright years
• Fix bug-reporting URLs and certificates
• Add urllib3 library to Windows build
• Show appropriate message on Secure-Downloader 403 error (currently shows failed sig error, should be URL-not-avail message)
• Fix filenames in offline signing script to avoid upload issues again

This is not a tally of bounties.  Most things that were reported first will get a bounty.  This is just  a list/summary of things we can fix for the next testing release.

@testers:  also, some other features to test:
-- Send to P2SH address
-- Download blockchain via torrent (just set a new --datadir and --satoshi-datadir and it should jump right into it)
-- Restore wallet from backup over existing
-- Fix corrupted wallets (if you have any)

[Brangdon]

Not sure what's up with the download links.  I just tested it on my system and can download Windows installers fine.  Can you make sure you have the latest announcments by clicking the "Check for Updates" button on the "Announcements" tab?

Yep. "Check for Updates" says they are up to date, but Secure Downloader still says "There was a failure downloading this file: 0" when I try "Armory testing (unstable)"

Also I note there are no release notes for it.

[etotheipi]

Not sure what's up with the download links.  I just tested it on my system and can download Windows installers fine.  Can you make sure you have the latest announcments by clicking the "Check for Updates" button on the "Announcements" tab?

Yep. "Check for Updates" says they are up to date, but Secure Downloader still says "There was a failure downloading this file: 0" when I try "Armory testing (unstable)"

Also I note there are no release notes for it.

Can you try clicking on "Download Info" and copy the URL into your browser and see if it downloads it?  I'm not sure why it's having an issue.  It sounds like a different error than simply not existing, which as noted in my previous post, gives an "Invalid Signature" error.

[Brangdon]

Should "Review Offline Transaction" show more information?

I've now created an offline wallet, sent some coins to it, created a transaction on my desktop, signed it with the offline machine, and broadcast it with the online machine. It all seems to work OK. However, I noticed that the dialog to review the transaction before signing or broadcasting seems to be missing information. There's nothing for the "Wallet:" or even the "Transaction Amount:", although those should surely be known. Also, clicking for "more information about this transaction" did nothing. The dialog after "Sign" or "Broadcast" did show some information, including the transaction amount.

[Brangdon]

Can you try clicking on "Download Info" and copy the URL into your browser and see if it downloads it?

That downloaded OK. That URL seems to be the same as in the first post in the download thread.

---------------------------
Package Information
---------------------------
Download information for <b>ArmoryTesting version 0.90.99.5:</b> <br> <ul> <li><u><b>Operating System</b></u>:</li> <ul> <li>Windows 8 64-bit</li> </ul> <li><u><b>Installer Filename</b></u>:</li> <ul> <li>armory_0.90.99.5-testing_winAll.exe</li> </ul> <li><u><b>Download URL</b></u>:</li> <ul> <li>https://s3.amazonaws.com/bitcoinarmory-testing/armory_0.90.99.5-testing_winAll.exe</li> </ul> <li><u><b>Verified sha256sum</b></u>:</li> <ul> <li>9b5a76cdb28b7cb8f5bd3446646f018d30394994330a995fd979db9b4e72c1bc</li> </ul> </ul>
---------------------------
OK  
---------------------------

[escrow.ms]

Tried it on Windows 8.1 64 Bit, didn't found any bugs except some small errors.

Step-4 UI is little bit messed up
https://i.imgur.com/65MO2PK.png

There's no Armory 0.90 Download in windows 8.1
https://i.imgur.com/aeJmDga.png


I tried to recover a unencrypted backup wallet just for testing and it said "99 errors where found"


Errors were about chain index
http://pastie.org/8983553


Ps: Torrent download works great.
https://i.imgur.com/R2Xv41b.png
https://i.imgur.com/XKNKnDB.png

[Brangdon]

I just failed to send some coin to three addresses. It got as far as asking for my password, but when I clicked Unlock it returned to the "Sending from Wallet" dialog. There was no error message. I'm pretty sure I had the right password (and if I hadn't, I'd expect a helpful error message saying as much). I tried again after deleting the last address, and that failed the same way. I then deleted another address, so that only one was left, and that succeeded as expected.

(This was all on my desktop; no offline signing shenanigans involved.)