New PyWallet fork with Python 3 support and improved coin recovery

[anon743294]

Long story short: I had problems using PyWallet because every time I ran it, it just crashed when trying to recover keys from a very corrupted legacy wallet.dat file.

Since I happen to run a software development firm, I basically asked (read: paid) one of my developers to work on PyWallet to improve it. It escalated into a new PyWallet fork with Python 3 support and improved corrupted wallet recovery support.

It's available at https://github.com/Great-Software-Company/pywallet

And I also did this simple website for it: https://pywallet.org/

I hope you like it! Thanks!

[ABCbits]

Since I happen to run a software development firm, I basically asked (read: paid) one of my developers to work on PyWallet to improve it. It escalated into a new PyWallet fork with Python 3 support and improved corrupted wallet recovery support.

It's available at https://github.com/Great-Software-Company/pywallet

I didn't try it. But after reading the README, it seems your developer worked on it. Anyway, you may want to specify license of your pywallet. I stated this because it currently have no license[1].

And I also did this simple website for it: https://pywallet.org/

At a glance, it looks good. But on "Other Open Source Bitcoin Wallet Recovery Tools" section, do you mind adding BTCRecover forked by 3rdIteration[1]? It's fork of BTCRecover with more feature, documentation and optional paid support/request.

[1] https://choosealicense.com/no-permission/
[2] https://github.com/3rdIteration/btcrecover][url]https://github.com/3rdIteration/btcrecover[/url]

[anon743294]

I didn't try it. But after reading the README, it seems your developer worked on it. Anyway, you may want to specify license of your pywallet. I stated this because it currently have no license[1].

I'm afraid I wasn't able to find the license information of PyWallet, so I didn't add any license to my fork either. I'd use the same license, but since I couldn't find this information, I didn't want to add anything.

At a glance, it looks good. But on "Other Open Source Bitcoin Wallet Recovery Tools" section, do you mind adding BTCRecover forked by 3rdIteration[1]? It's fork of BTCRecover with more feature, documentation and optional paid support/request.

Very nice! I added this.

[ABCbits]

I didn't try it. But after reading the README, it seems your developer worked on it. Anyway, you may want to specify license of your pywallet. I stated this because it currently have no license[1].

I'm afraid I wasn't able to find the license information of PyWallet, so I didn't add any license to my fork either. I'd use the same license, but since I couldn't find this information, I didn't want to add anything.

Fair point. jackjack-jj fork doesn't mention any license, while joric original works only briefly mention public domain. It makes choosing appropriate license is tricky.

Code:

# PyWallet 1.2.3 (Public Domain)
# http://github.com/joric/pywallet
# Most of the actual PyWallet code placed in the public domain.
# PyWallet includes portions of free software, listed below.

Source: https://github.com/joric/pywallet/blob/master/pywallet.py#L3-L6

[mcdouglasx]

I didn't try it. But after reading the README, it seems your developer worked on it. Anyway, you may want to specify license of your pywallet. I stated this because it currently have no license[1].

I'm afraid I wasn't able to find the license information of PyWallet, so I didn't add any license to my fork either. I'd use the same license, but since I couldn't find this information, I didn't want to add anything.

Fair point. jackjack-jj fork doesn't mention any license, while joric original works only briefly mention public domain. It makes choosing appropriate license is tricky.

Code:

# PyWallet 1.2.3 (Public Domain)
# http://github.com/joric/pywallet
# Most of the actual PyWallet code placed in the public domain.
# PyWallet includes portions of free software, listed below.

Source: https://github.com/joric/pywallet/blob/master/pywallet.py#L3-L6

There is actually very little information on the subject of licensing with pywallet, but from what I've seen, Joric created pywallet and then Jackjack made a fork of it, although apparently Joric's original license according to his repository on Google is BSD.

https://code.google.com/archive/p/pywallet/

[anon743294]

There is actually very little information on the subject of licensing with pywallet, but from what I've seen, Joric created pywallet and then Jackjack made a fork of it, although apparently Joric's original license according to his repository on Google is BSD.

To be perfectly honest with you, I don't have much experience in open source development and this was actually my very first fork of an existing code ever. So, I don't really know what is the correct procedure here. Should I just assume the license is BSD and therefore mark my fork as BSD license as well on Github?

On a relating note: I have been working more with my updated PyWallet. I found another corrupted wallet.dat file which could not be processed by any previous versions of PyWallet, so I made improvements to my fork and it is now able to handle that type of file corruption as well and recover data from it. Debug logging was also improved.

[ABCbits]

--snip--

There is actually very little information on the subject of licensing with pywallet, but from what I've seen, Joric created pywallet and then Jackjack made a fork of it, although apparently Joric's original license according to his repository on Google is BSD.

https://code.google.com/archive/p/pywallet/

I managed to download the code, despite most function on that link is broken. But comparing "pywallet.py" file from that link and "pywallet.py" from Joric first commit on GitHub[1], it looks very different. It makes me think that it's mere coincidence both of them have same name.

There is actually very little information on the subject of licensing with pywallet, but from what I've seen, Joric created pywallet and then Jackjack made a fork of it, although apparently Joric's original license according to his repository on Google is BSD.

To be perfectly honest with you, I don't have much experience in open source development and this was actually my very first fork of an existing code ever. So, I don't really know what is the correct procedure here. Should I just assume the license is BSD and therefore mark my fork as BSD license as well on Github?
--snip--

In practice, i see many project forget to choose a license or choose non-conflicting license. So if you're not sure, i would recommend you to just acknowledge original creator/previous author.

[1] https://github.com/joric/pywallet/commit/bc1d07d669bf84272bc27c9f642b0aee2c53c04d

[COBRAS]

OP  add detect if fake wallet - without private keys at adresses with ballance etc