Bitcoin Core - showing the coins (UTXOs) in a separate tab

[apogio]

Disclaimer: I know there are Core devs and maintainers in here. Please be kind, it's the first time I'm messing with Bitcoin's source code.

The Pull Request: https://github.com/bitcoin-core/gui/pull/898


I've always liked to be able to see my coins (UTXOs), even if I didn't have to spend bitcoins.

So, I thought about adding it at the top bar, like so:




Clicking this tab would open the existing UTXO page (coincontroldialog.cpp), but I didn't like the whole top section, because it only makes sense if you select UTXOs.




Therefore, I added a view-only mode for the dialog and I removed the checkboxes and the entire section at the top and this is what I'm left with:



Question
Does anyone like my idea? I'm thinking about submitting a Pull Request.
I know it's not super significant, but I like it this way.
If it's only me who likes it though, it doesn't matter, I'll use it only for myself.

[Alvin_talk]

Does anyone like my idea?

Just as you have said it is not so significant but it looks pretty cool.

It is something I will love to try out when I am bored .

[Forsyth Jones]

I loved the idea and fully support the Pull Request!!

Currently, the Coin Control interface in Bitcoin Core is very ugly. When activated, it takes up a lot of space in the sending tab, which could easily be triggered with a button (like you did), but a button in the sending tab (just like there's a button to customize the sending fee).

But your proposal is very good!  

[Mia Chloe]

~snip

It's a nice modification you did thanks to the freedom open source softwares grant us. Anyways just like you mentioned it's not a very pressing fix but I think it's still a fine one. Could interact with pre opened dialogue boxes after you opened this particular dialogue box in your fix?

I'm asking this because sometimes some dialogue boxes must be closed for you to be able to access pre opened ones. Anyways the biggest mods I'll like is for Electrum to improve the mobile version because it way behind from the desktop version.

[apogio]

Pull Request sent
Obviously I'd like to hear your thoughts, but in the worst-case scenario, it will simply not get merged. All good!

[Satofan44]

Pull Request sent
Obviously I'd like to hear your thoughts, but in the worst-case scenario, it will simply not get merged. All good!

Seems like a good idea, only you opened the PR in the wrong place. First time contributor blunder?  The PR in case anyone is looking. https://github.com/bitcoin/bitcoin/pull/33542

Should be here as hebasto wrote. https://github.com/bitcoin-core/gui

[apogio]

Seems like a good idea, only you opened the PR in the wrong place. First time contributor blunder?   The PR in case anyone is looking. https://github.com/bitcoin/bitcoin/pull/33542

Should be here as hebasto wrote. https://github.com/bitcoin-core/gui

Yeah I'm in the middle of opening it now in the correct place.

Here it is: https://github.com/bitcoin-core/gui/pull/898

[coinlary]

The feature looks good.
You can try making it optional though through a checkbox   from the  setting >Options> Display.  
When enabled the coin tab you added  will be visible then  instead of having it   visible by default.

Does anyone like my idea? I'm thinking about submitting a Pull Request.

[ABCbits]

I really appreciate your attempt. But have you fully read contributor guide? IMO this part is especially important.

When adding a new feature, thought must be given to the long term technical debt and maintenance that feature may require after inclusion. Before proposing a new feature that will require maintenance, please consider if you are willing to maintain it (including bug fixing). If features get orphaned with no maintainer in the future, they may be removed by the Repository Maintainer.

Does anyone like my idea? I'm thinking about submitting a Pull Request.

For wallet with many address/UTXO, IMO preserving "Quantity" text and choice between "Tree mode" or "List mode" may come in handy.

[apogio]

I really appreciate your attempt. But have you fully read contributor guide? IMO this part is especially important.

When adding a new feature, thought must be given to the long term technical debt and maintenance that feature may require after inclusion. Before proposing a new feature that will require maintenance, please consider if you are willing to maintain it (including bug fixing). If features get orphaned with no maintainer in the future, they may be removed by the Repository Maintainer.

Unless there is a secret meaning, then I consider it an obligation anyways. An obligation which is both "technical debt", but also ethical requirement.

For wallet with many address/UTXO, IMO preserving "Quantity" text and choice between "Tree mode" or "List mode" may come in handy.

That's a good idea. Let's see how it goes, I'm sure people will jump in and post ideas and objections, either here or on Github.

[Satofan44]

I really appreciate your attempt. But have you fully read contributor guide? IMO this part is especially important.

When adding a new feature, thought must be given to the long term technical debt and maintenance that feature may require after inclusion. Before proposing a new feature that will require maintenance, please consider if you are willing to maintain it (including bug fixing). If features get orphaned with no maintainer in the future, they may be removed by the Repository Maintainer.

Unless there is a secret meaning, then I consider it an obligation anyways. An obligation which is both "technical debt", but also ethical requirement.

There isn't one, it means literally what it says. Many people want Core to do all sorts of things but they don't contribute anything to it at all. Core really does not like technical debt. However, since this is not really a major feature given the number of lines changed and you are willing to maintain it then there are no issues.

Do you now plan to contribute more to Core or is this more a one time thing?

[apogio]

Do you now plan to contribute more to Core or is this more a one time thing?

Definitely! I'm planning to contribute more, but I'm not making any actual plans.

I will be looking the github repositories, check the issues, check the new PRs, implement new stuff (if I consider them important).
I will not contribute just to say that I contribute. I won't be making changes, just to change something.

I hope it makes sense

For wallet with many address/UTXO, IMO preserving "Quantity" text and choice between "Tree mode" or "List mode" may come in handy.

I have tried it. Would you like it this way? I'm posting the list view and the tree view pictures below:




Perhaps it would make more sense if I also left the checkboxes on the left, so that you can click and expand the UTXOs.

[ABCbits]

For wallet with many address/UTXO, IMO preserving "Quantity" text and choice between "Tree mode" or "List mode" may come in handy.

I have tried it. Would you like it this way? I'm posting the list view and the tree view pictures below:




Perhaps it would make more sense if I also left the checkboxes on the left, so that you can click and expand the UTXOs.

At a glance, it looks great. I also think it's good to idea to be able to expand UTXO of an address. Although i believe you'll need opinion from various person.

[apogio]

UPDATE (for those who don't follow Github):

After receiving a comment from Luke Dashjr, I've made some modifications which I think are reasonable.

So, now, the way it works is:

When coin control features are disabled, then the "Coins" tab will be hidden, like in this picture:




Once the user enables coin control features, then the "Coins" tab will appear, like so:




If the user has coin control features enabled and then disables it, the "Coins" tab will hide again and the user will be transferred to the "Overview" tab.

And lastly, here is the way that the coins tab will look like: