Thank you for sharing your work. I don't use mac, but i wonder why you decide to make build as default option for Bitcoin? Are there any advantage over download (the binary)?
I'm not sure there is a good reason it is the default (except for my QA it is the more complex path and I want to make sure the complete build/config/install from scratch works), but there are some advantages to building vs. downloading:
- The binary availability bitcoincore.org lags when the releases are tagged on github
- You can specify to use the direct master branch to try bug fixes / new features
- You can experiment with adding different pull requests, or making changes to directly to the source
- Based on the configuration specified, the resulting binary will be more "tuned" to the features you want. For example, I never use the wallet in Bitcoin Core itself and I don't use the GUI, and there are build flags that will skip/exclude building those features resulting in a binary that does not include that functionality at all.
I'm using it as part of my build environment for making changes. For most users choosing the download option would suffice and be faster, unless they are wanting to use a version that isn't yet available as a binary on bitcoincore.org.
On the Electrs side I'm not sure there is a macOS binary available, so building is the only option.
