[BUG] ckpool - bestshare sync discrepancy and state persistence after block find

[valdobruheim]

Hi Con / @-ck,

I'm reporting a potential bug related to the logic in ckpool how bestshare is handled in the JSON API and the users state file following a block find.

Environment:
    - Version: Vanilla (official Bitbucket source)
    - Environment: Docker container
    - Network: BCH

The Issue:
When a block is found, the global bestshare in the JSON API resets correctly. However, the bestshare value within the users and worker objects/files does not consistently reset. This leads to a discrepancy where the user-level stats remain "stale" from the previous round.

Observed State Behavior:

    - Memory Overwrite: If I manually edit the users file to reset the value while the pool is running, the pool eventually overwrites my manual change with the stale high value stored in memory.
    - Force Reset via Restart: If I stop the ckpool container, manually edit the bestshare in the users file to 0, and then start the pool, the pool.status and users stats update correctly and stay synced—until the next block is found, at which point the discrepancy returns.

Summary:
It appears the "Reset on Block" logic triggers for the global status but fails to flush the new state to the individual user objects in memory or the persistent users file. The only way to realign them currently is a hard service restart with a manual file edit.

Is there a planned fix for ensuring the users state is fully flushed/reset upon a block find, or is this a side effect of how the pool handles high-concurrency worker updates?

Best,
Valdo

[o_solo_miner]

first: Report your "bug" in the cksolo.pool tread, and not "somewhere".
second: Network: BCH / you are in the Bitcoin section, everything else is altcoin! and will not be supportet

[valdobruheim]

first: I couldn't find any tread for ckpolo as I'm running in my own server where I installed the vanilla ckpolo from -ck official bitbucket repo, I'm not mining in ckpolo.pool. I posted in the section I though was appropriate but looks like it is not, my bad.
second: It's irrelevant what coin I'm mining as this is not a problem talking with the node or related to the coin, this is a problem in the ckpool. Just like the "first" I posted in the section I though was appropriate but looks like it is not, my bad.

If you can point me to the right tread I would be very grateful as I did a lot of searches and couldn't find any tread dedicate to the ckpool software, I guess my ability to search is not the best out there and just like the "first" and the "second" it's my bad.

Happy mining!

[NotFuzzyWarm]

first: I couldn't find any tread for ckpolo as I'm running in my own server where I installed the vanilla ckpolo from -ck official bitbucket repo, I'm not mining in ckpolo.pool. I posted in the section I though was appropriate but looks like it is not, my bad.
second: It's irrelevant what coin I'm mining as this is not a problem talking with the node or related to the coin, this is a problem in the ckpool. Just like the "first" I posted in the section I though was appropriate but looks like it is not, my bad.

If you can point me to the right tread I would be very grateful as I did a lot of searches and couldn't find any tread dedicate to the ckpool software, I guess my ability to search is not the best out there and just like the "first" and the "second" it's my bad.

Happy mining!

Correct area is Mining Software https://bitcointalk.org/index.php?board=42.0
-ck closed support of the ckpool software long ago so don't expect much...

[valdobruheim]

Thanks, will post there. I can see he updated the bitbucket repo recently. Anyway, I'm looking at the code and see if I can fix (not a c++ expert, or at least not anymore  ).