Does the network (ie other peers) see us as the same “peer” since it’s the same IP address, but they can only connect to one of the two actual machines? There’d be one “half” of our “peer” with one version of the client and another “half” of our same peer with a different client version. And I suppose they’d never actually connect to each other?
I’m not sure if that will be the case, both should be able to establish their own outband connections with the router handling different NAT mappings for each. This situation is different for inbound connections, If both nodes are listening on the default port 8333, your router generally can’t forward the same public IP:8333 connection to two different machines at the same time. So unless the router is configured differently, only one of the nodes can normally be the publicly reachable destination on that port.
So technically you should be fine unless you’ve specifically disabled outband connections or both are sharing the same configurations they shouldn’t be.