Bitcoin Forum
December 04, 2016, 04:38:19 PM *
News: Latest stable version of Bitcoin Core: 0.13.1  [Torrent].
 
   Home   Help Search Donate Login Register  
Pages: [1]
  Print  
Author Topic: [PULL] add 'settxfee' RPC  (Read 1269 times)
xf2_org
Member
**
Offline Offline

Activity: 70


View Profile
April 12, 2011, 10:55:36 PM
 #1


URL: https://github.com/bitcoin/bitcoin/pull/150

Add 'settxfee' RPC, to change TX fee setting at runtime

This clamps TX fee, if not zero, between "network minimum" (0.01) and 5 BTC (IMO sanity limit).

Presumably, the "network minimum" might be lowered, as is occasionally discussed on IRC and forum. This RPC prevents setting TX fee below network minimum.
"Your bitcoin is secured in a way that is physically impossible for others to access, no matter for what reason, no matter how good the excuse, no matter a majority of miners, no matter what." -- gmaxwell
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1480869499
Hero Member
*
Offline Offline

Posts: 1480869499

View Profile Personal Message (Offline)

Ignore
1480869499
Reply with quote  #2

1480869499
Report to moderator
Luke-Jr
Legendary
*
expert
Offline Offline

Activity: 2086



View Profile
April 12, 2011, 11:56:53 PM
 #2

This introduces a regression, since -settxfee accepts <0.01 right now, and it's sane to do so.

xf2_org
Member
**
Offline Offline

Activity: 70


View Profile
April 13, 2011, 12:14:53 AM
 #3

This introduces a regression, since -settxfee accepts <0.01 right now, and it's sane to do so.

That's intentional, not a regression.

j16sdiz
Jr. Member
*
Offline Offline

Activity: 37


View Profile
April 13, 2011, 12:38:24 AM
 #4

Remove the    if (nAmount < CENT) and   if (nAmount > (5 * COIN))  check.
API should be as powerful as (if not more powerful then) command line.
Luke-Jr
Legendary
*
expert
Offline Offline

Activity: 2086



View Profile
April 13, 2011, 01:48:34 AM
 #5

This introduces a regression, since -settxfee accepts <0.01 right now, and it's sane to do so.
That's intentional, not a regression.
It's a regression by definition, because it works today and your patch breaks it.

Gavin Andresen
Legendary
*
qt
Offline Offline

Activity: 1652


Chief Scientist


View Profile WWW
April 14, 2011, 01:54:09 AM
 #6

I can see the GUI not allowing a less-than-CENT to save fat-fingered users from themselves, but I think the RPC should allow it; at the very least it makes it possible for a kind of grass-roots movement to arise between miners and people generating transactions so if we start seeing a lot of transactions with less-than-CENT-per-kbyte-fees then that's a really good indication the default definition of "free" needs to change.

And now that the RPC and GUI allow full-precision amounts for send/move, there is no problem with "I got 50.000001 bitcoins from mining, how do I send ALL of them?"

How often do you get the chance to work on a potentially world-changing project?
xf2_org
Member
**
Offline Offline

Activity: 70


View Profile
April 14, 2011, 04:57:25 AM
 #7

Updated pull request, removing the ValidFee() check.

Pages: [1]
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!