[ANN] Armory Multi-Sig with Simulfunding [BOUNTY 0.03 per bug]

[etotheipi]

Okay, one more try!  I just uploaded an identical copy of 0.91.99.8-beta, except that the Windows version now has all the print statements removed.  Otherwise, it should be identical to the previously-available 0.91.99.8.  

Just be aware that since the file is named the same (it's literally the same except for irrelevant print statements removed), that the secure downloader signature verification will fail for the next 30-60 minutes, or until you go to the "Announcements" tab and click "Check for Updates".  You can't get the wrong one though, since you'll get an error and Armory will refuse to save the file.

P.S. - In case it wasn't clear:  this 0.91.99.8 re-do seeks to solve the "Bad File Descriptor" error.

[helgabutters]

1) When you are viewing the "Transactions" tab in "Manage Multi-Sign Lockbox Info", I can't right click and view the details of a transaction.
This is from a lockbox that I imported that doesn't have any of keys on this machine.
Armorylog: http://pastie.org/pastes/9358430/text?key=235mpxztzfutb3zmp3hs1a

2) When you are using a lockbox on the Test Network and you "Manually Enter bitcoin: Link" such as: bitcoin:2NFa9B2Pt3g279U16gLMfMbxWHWBsCYHaJz?amount=0.001
You will get an "Wrong Network" error that you are on the Test Network and the address supplied is for the Test Network.

https://i.imgur.com/1CnvalO.png

3) I know this is still beta but there is nothing in your privacy policy about talking with Coinbase and getting the exchange rate.

Request: There is no way to set the "owner" of the lockbox. This one I'm not sure about since you can simply be an organizer but it would be nice to have a setting to specify if you are an owner or just an organizer. An example situation is, I've imported a lockbox but I don't have any of the keys. It will still display that I received bitcoins even thought I can't do anything with them. I'm guessing this is correct behavior since it doesn't know if, for example, your keys are stored offline but it would be nice to be able to differentiate between the two. This is unless I am misunderstanding the different usages of the lockboxes.

[helgabutters]

1) Something really odd happens to the numbers when you put in large values of BTC when you are sending bitcoins in "Sending from Wallet" or Recieving Bitcoins through "Create Payment Request Link"
Example: Put in a value with about 15/20 or more numbers in "Request (BTC)" in "Create Payment Link" or "Amount" in "Sending from Wallet" and you will start getting different numbers BTC amounts then what the value you put in is. Example here is with all 9's:

https://i.imgur.com/HSTfBAY.png


2) The "BTC Balance" in the "Exchange Rates" tab is right justified. It doesn't allow you to resize the column to not have a lot of whitespace without covering up the actual BTC value.
You can see everything here:

https://i.imgur.com/kglpt7K.png

This is after slightly making the column smaller:

https://i.imgur.com/P24EUFC.png

After some more testing I noticed this happens in a lot of spots so it may be a known issue. Just seems like unnecessary whitespace when you need something smaller.

3) If you have a lockbox but do not have any of the keys on the machine, you can not make any comments to transactions. The window will pop up but you will get the same error that I pasted before with the "View Details":
UnboundLocalError: local variable 'wlt' referenced before assignment

4) Below are two examples of the same issue. The transaction amount displayed is "-0.001 BTC" but as you can see from both transactions, 0.001 BTC is not any of the inputs or outputs.
This is from a lockbox with 2 keys on one machine and 1 key on another. They also all display "Sent" when they were actually recieving.

https://i.imgur.com/gJmmRNE.png

https://i.imgur.com/lGMoIuj.png

[helgabutters]

1) "Public Key Information" window pops up randomly when editing a lockbox. I can't consistently reproduce this issue so I'm not really sure what the cause may be: https://www.youtube.com/watch?v=ZE4EzI7lFmE

This is a 2-of-2 lockbox on Win7 with both wallets on this machine.
There is no "extended info" for the lockbox as well as no "Name or ID" for both pieces.
It only has one transaction which is the original funding transaction.

2) Can't resize the "Transaction Info" windows

https://i.imgur.com/T7P4fsd.png

3) On Windows for "Import Lockbox", "Import Signature Collector", "Import Promissory Note" in the upper right hand corner there is a "?". Pressing this does nothing but change your pointer to a Do Not symbol: https://i.imgur.com/qja2U86.png

3.1) Import Lockbox:

https://i.imgur.com/oJ3eJBU.png

3.2) Import Signature Collector:

https://i.imgur.com/vQxW9pG.png

3.3) Import Promissory Note:

https://i.imgur.com/FyF0bQc.png



4) In "Create Payment Request Link" an overly long "Link Text" pushes everything down and you can't view all of the information unless you copy to clipboard or raw html.

https://i.imgur.com/CuapRpZ.png

[PRab]

I just re-tested with the latest version and from what I can tell all of the bugs/glitches/improvements that I have mentioned have been fixed! I am extremely excited about this next release of Armory. Armory continues to lead the way in cutting edge bitcoin security that is accessible by anyone.

Now I just get to sit back and enjoy this technology while you guys work on deterministic/HDish lockboxes (I'm assuming that's next, but I trust your judgement if something else is more urgent).

Note: I have been doing all of my testing on one online box. I haven't tried anything with doing the signing/merging transactions on an offline computer.

[helgabutters]

1) I was sending from a Lockbox to a variation of lockboxes / bare P2SH addresses. Armory threw an error that the transaction was not accepted but it was sent and included in the next block: http://pastie.org/pastes/9365846/text?key=jf5oyzmqmeo6cg890agiw

2) Clicking "Manually Enter Bitcoin: Link" without anything inside doesn't display any error and causes: http://pastie.org/pastes/9365725/text?key=mod6tocttrku2maks8i1g

3) When two separate transactions are listed that are actually part of the same transaction in the MultiSig info box you can't set separate comments for each one, it will autofill in the other.

4) This is a signed, exported transaction from an OSX wallet: http://pastie.org/pastes/9365763/text?key=mlykdfhsayfcms9t84ytq
Putting this text into "Import Lockbox" and hitting "Done" does not give a dialog box and this is the armorylog: http://pastie.org/pastes/9365761/text?key=fvxvffei8zxastiz0imioa

5) In OSX, "Collect Sigs and Broadcast" doesn't display receiving addresses. You can add the above signed transaction to see: http://pastie.org/pastes/9365763/text?key=mlykdfhsayfcms9t84ytq

https://i.imgur.com/J5MPCho.png

6) The MultiSign "Dashboard" information is cut off in OSX:

6.1)
https://i.imgur.com/6cNSmjV.png

6.2)
https://i.imgur.com/CdAXVUy.png

[helgabutters]

1) Total public keys will randomly jump to a different number when selecting. You can see this around 42 seconds where I select "4" and it jumps to "6":

https://www.youtube.com/watch?v=BJmElel5hlQ#t=42

2) The "Show Keyboard", when it has already been opened and you go to enter the password again will display "Show keyboard" instead of "Hide keyboard":

https://www.youtube.com/watch?v=m_Ust67eGFs

3) Creating a promissory note with all three promissories in the same wallet with a few different values:

http://pastie.org/pastes/9366419/text?key=iduvkt3bfpqezvtidbria
https://www.youtube.com/watch?v=QLpTzWKe1TI

4) In "New Receiving Address" you can insert a seemingly infinite amount of information in the "(Optional) Add a label ..." but this information will be cut off when you "Create Clickable Link":

https://www.youtube.com/watch?v=RdAuTh2vy-8

5) Armory randomly crashes after playing with offline transactions / wallet properties / lock boxes:

http://pastie.org/pastes/9366416/text?key=r7isdfaonz0oaa1w4jjqna
https://www.youtube.com/watch?feature=player_detailpage&v=DIXIN53VIHM#t=69 (actual crash is around 1:09)

[helgabutters]

1) (?) for "Print Wallet Backup" with "Use SecurePrint(TM)" talks about "Turn off this feature if you copy the 'Root Key' and 'Chaincode' by hand" but there is no "Chaincode" anymore.

https://i.imgur.com/vOYGT00.png

2) "Printable paper backups" > "Fragmented Backup (M-of-N)" ... "Create Backup Fragments" does not have a "(?)" for the SecurePrint information that the single-sheet does.

https://i.imgur.com/zETEA8y.png

3) In the "Wallet Creation Wizard" the first step has a "< Back" button but there is no reason for this button. It is greyed out but a non-greyed out cancel button may work better (or just removed completely)

https://i.imgur.com/gcIkN2I.png

4) "Wallets" > "Fix Damaged Wallet" if you don't put anything inside the "Wallet Path" and hit "Recover" then the menu closes and you get this error:

http://pastie.org/pastes/9366709/text?key=ox9ftzrbkvmap4j60hwq

https://i.imgur.com/bTCMFKq.png

5) Can't print Armory backup wallet to PDF successfully in OSX: https://www.youtube.com/watch?v=qBPCdlWtRg8

[helgabutters]

1) "Sign with Address" with a lockbox selected and clicking "Bare Signature" then "Base64 Signature" then "Clearsign Signature":

http://pastie.org/pastes/9369038/text?key=64ygktykwwx01xor2y85g

2) Same as above but with the actual P2SH address instead of Lockbox:

http://pastie.org/pastes/9369034/text?key=mq3dg3ngb3sch3carnpcuw

3) In the Address Book in OSX, setting a comment on a reciving address won't update the display until you select another transaction or try to change the name again:

https://www.youtube.com/watch?v=4fJMsvu7vM8

4) In same video around 11 seconds you can see that every so often it won't successfully change a comment:

https://www.youtube.com/watch?v=4fJMsvu7vM8#t=11

[CircusPeanut]

Helgabutters - Thanks for all of your hard work. I have counted 54 bug reports and found ~43 distinct bugs that we have either fixed already or will fix. That's an ~80% hit rate. Also, your reports were easy to read and understand. In most cases you included no more and no less information than I needed to reproduce the bug. I only need one clarification that is included below.

To thank you for quantity and the quality of your output we have decided to pay 0.03 for all of your bug reports including whatever we think are duplicates and not bugs. This also saves us the trouble of making calls on the few borderline bugs.

So that is 54 * 0.03 = 1.62 BTC.  Just post your address and we will send you your prize.

Anyone else that may be thinking what about my bug reports. I'm not sure, I've just been focused on this lot. We intend to reward everyone for useful bugs that they've submitted. And for anyone who can match Helgabutters prolific output, we will reward you just as generously.

Thank you Helgabutters and everyone who's participating in crowd testing Armory.


------------------------------------------------------
"I was sending from a Lockbox to a variation of lockboxes / bare P2SH addresses. Armory threw an error that the transaction was not accepted but it was sent and included in the next block: http://pastie.org/pastes/9365846/text?key=jf5oyzmqmeo6cg890agiw"


Not sure what you mean by bare P2SH, please clarify.

[etotheipi]

So that is 54 * 0.03 = 1.62 BTC.  Just post your address and we will send you your prize.

 Actually, I've already got an encrypted GPG thread with helgabutters over email.  Please send the payment address there. 

And yes, thanks again!  You get the bug bounty overachievers award!

[helgabutters]

Helgabutters - Thanks for all of your hard work. I have counted 54 bug reports and found ~43 distinct bugs that we have either fixed already or will fix. That's an ~80% hit rate. Also, your reports were easy to read and understand. In most cases you included no more and no less information than I needed to reproduce the bug. I only need one clarification that is included below.

To thank you for quantity and the quality of your output we have decided to pay 0.03 for all of your bug reports including whatever we think are duplicates and not bugs. This also saves us the trouble of making calls on the few borderline bugs.

That's awesome! Thank you very much.

So that is 54 * 0.03 = 1.62 BTC.  Just post your address and we will send you your prize.

 Actually, I've already got an encrypted GPG thread with helgabutters over email.  Please send the payment address there.

Yes, please send to the address that I previously sent to etotheipi.

"I was sending from a Lockbox to a variation of lockboxes / bare P2SH addresses. Armory threw an error that the transaction was not accepted but it was sent and included in the next block: http://pastie.org/pastes/9365846/text?key=jf5oyzmqmeo6cg890agiw"


Not sure what you mean by bare P2SH, please clarify.

Sorry for the mix up, it should be "Bare Multi-Sig (No P2SH)". Below is an example of the type of transaction I sent (and just confirming that this one too gave the error):

https://i.imgur.com/6PUG1Ht.png

[doug_armory]

Helgabutters - Thanks for all of your hard work.

Yes, thank you very much. At my previous job, I got bug reports from so many people who had no clue what they were talking about, or couldn't organize their materials, or otherwise drove me nuts. Your bug reports are damn near perfect. You've earned your bounty. Now then, to fix those Mac bugs.... (FYI, the printing bug is already fixed.)

[fran2k]

This is very awesome work! Finally some multi-sig into the GUI.

Thanks.

[burekzastonj]

Armory caused me a lot of grey hair in the past, so thank you, no more!

[etotheipi]

Last testing version before 0.92 release (0.91.99.9-beta)
Still 0.03 BTC per bug!


As before, use the secure downloader to grab the latest testing version.  Armory will check the digital signatures for you!  Only use the links below if you do not yet have a trusted version of 0.91+ available.

Installers for 0.92-beta (pre-release 0.91.99.9-beta):
  Armory 0.91.99.9-beta for Windows XP, Vista, 7, 8+ 32- and 64-bit
  Armory 0.91.99.9-beta for MacOSX 10.7+ 64bit
  Armory 0.91.99.9-beta for Ubuntu 12.04+ 32bit
  Armory 0.91.99.9-beta for Ubuntu 12.04+ 64bit
  Armory 0.91.99.9-beta for Raspbian (armhf)

Offline Bundles:
  Armory 0.91.99.9-beta Offline Bundle for Ubuntu 12.04 32bit
  Armory 0.91.99.9-beta Offline Bundle for Ubuntu 12.04 64bit
  Armory 0.91.99.9-beta Offline Bundle for Raspbian (armhf)

Signed Hashes:
  Armory 0.91.99.9-beta: Signed hashes of all installers


Thanks to all our testers, especially helgabutters!   It took us a while to get through all his bug reports, but I think we knocked them off all of the non-OSX bug reports.  Although we may not have fixed all the OSX bugs, doug_armory was able to integrate some Qt4 patches into the OSX build system that should resolve a ton of stability issues.  No promises, but he insists that he experienced a notable improvement!  Please let us know.

Not only that, but doug_armory and CircusPeanut have got a ton of new unit tests and functional tests integrated, which should dramatically improve robustness of everything going on under the hood.  We're still working on some automated GUI tests, but they're not ready yet.  Hopefully soon.

Finally, we made some significant improvements to armoryd.py.  It's still not quite stable, and we don't plan for it to be for the 0.92 release, but it's getting closer.  If you are interested in armoryd, please try it out and feel free to report bugs here for bounties.   We have made no claims of it being stable, so there's probably quite a few bounties to be collected.  We're happy to pay them out to speed up our development.

The 0.03 bounty is still active for 0.91.99.9, both GUI and now armoryd.  

[helgabutters]

First armoryd bug!

When running "help" they all return "Error": "The function description is malformed."
http://pastie.org/pastes/9395585/text?key=fbvn2gyp5xzxicil4reag

Since this is the last release before 0.92 is there any specific date you are aiming to have it out by?

[etotheipi]

Since this is the last release before 0.92 is there any specific date you are aiming to have it out by?

It's funny you ask that.  The guys that work with me would probably complain that I like to declare schedules and then not stick to them.  Which is true -- I try to set schedules to give us a target to work for, but the true end date is "when it's ready"    Especially with a piece of software as sensitive as this, we never rush anything which might lead to dangerous bugs.

So to answer your question more directly:  we'd like to officially release this next week.  Saturday is a good target for the end of the testing phase.  But depending on how testing goes, it may be further delayed.  So far, things are looking good, an these bounties have been tremendously useful for speeding up this process so you guys can expect these to continue for further releases!

[TimS]

Edit: I upgraded to .9 and this is gone, so you should probably disregard this.

I wouldn't expect this qualifies for the 0.03 bounty, but I noticed a little something. At the end of the first paragraph is the text "Untitled".


This is in version 0.91.99.8-multisig.

A brief overview of how I got here, in case it matters:
I created two promissory notes (0.1 BTC each) to pay an address in my own wallet, created the TXSIGCOLLECT from that, and then imported that into the Review & Sign window (these are still unsigned transactions).

[etotheipi]

I wouldn't expect this qualifies for the 0.03 bounty, but I noticed a little something. At the end of the first paragraph is the text "Untitled".

...

A brief overview of how I got here, in case it matters:
I created two promissory notes (0.1 BTC each) to pay an address in my own wallet, created the TXSIGCOLLECT from that, and then imported that into the Review & Sign window (these are still unsigned transactions).

Whoops, that's a pretty obvious error.  You definitely deserve a bounty for that ... or at least we deserve to lose a bounty for not noticing it ourselves