|
dabura667
|
 |
May 27, 2014, 03:40:08 PM |
|
so DW was first, and you just copied it. then I copied it...  the question is: what now? are you going to change it? I think we should. Fixed. But now I won't be able to recover funds with DW half of the time :-( |
My Tip Address:
1DXcHTJS2DJ3xDoxw22wCt11FeAsgfzdBU
|
|
|
|
|
|
You can see the statistics of your reports to moderators on the "Report to moderator" pages.
|
|
|
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
|
|
|
|
|
|
|
piotr_n
Legendary
 Offline
Activity: 2053
Merit: 1354
aka tonikt
|
|
May 27, 2014, 03:42:29 PM |
|
yeah I know.
do you have some better comm channel with DW guys?
I've been trying to let them know and ask whether they were going to fix it as well, but they don't seem to be reachable.
|
Check out gocoin - my original project of full bitcoin node & cold wallet written in Go.PGP fingerprint: AB9E A551 E262 A87A 13BB 9059 1BE7 B545 CDF3 FD0E
|
|
|
|
Nicolas Dorier (OP)
|
|
May 27, 2014, 03:51:19 PM |
|
habitually genjix respond, tried to spam him again today, but he 404 me.
|
Bitcoin address 15sYbVpRh6dyWycZMwPdxJWD4xbfxReeHe
|
|
|
caedes
Newbie
Offline
Activity: 44
Merit: 0
|
|
May 27, 2014, 06:57:24 PM |
|
hey,
We agree the dw implementation is at fault, I'm going to apply the fix and think about some way so we can redeem old dw stealth funds too so I can take a bit to apply the pull request but will do it asap.
cheers and congrats on finding out the error!.
|
|
|
|
|
piotr_n
Legendary
Offline
Activity: 2053
Merit: 1354
aka tonikt
|
|
May 27, 2014, 07:31:43 PM |
|
good. thx.
|
Check out gocoin - my original project of full bitcoin node & cold wallet written in Go.PGP fingerprint: AB9E A551 E262 A87A 13BB 9059 1BE7 B545 CDF3 FD0E
|
|
|
genjix
Legendary
Offline
Activity: 1232
Merit: 1072
|
|
May 27, 2014, 08:03:16 PM |
|
sorry Nicolas, was outside.
I'm lurking and responding when back.
btw is SX doing it correctly or not?
|
|
|
|
|
|
Nicolas Dorier (OP)
|
|
May 27, 2014, 08:46:04 PM |
|
SX is correct, the DW implementation in javascript is not. I'm a little confused about who develops what.
Do you manage the JS implementation ?
|
Bitcoin address 15sYbVpRh6dyWycZMwPdxJWD4xbfxReeHe
|
|
|
caedes
Newbie
Offline
Activity: 44
Merit: 0
|
|
May 28, 2014, 03:53:00 AM |
|
I manage the js implementation and genjix the sx one.
|
|
|
|
|
caedes
Newbie
Offline
Activity: 44
Merit: 0
|
|
May 28, 2014, 04:57:29 AM |
|
Ok we have fixed the issue in darkwallet git. The fix also is using a different api than proposed that also makes sure the point is encoded as 32 bytes, not totally sure it's required but probably is what we want, will double check that soon with genjix. https://github.com/darkwallet/darkwallet/commit/da6a084c3102bbaf50aabd1ba524f5365f27d7edWe also added some backwards compatibility code so funds in bad addresses won't be just stuck. Tried to make it in the most simple way and so the workaround can easily be removed later. Thx again for finding the issue and providing a fix. |
|
|
|
|
|
Nicolas Dorier (OP)
|
|
May 28, 2014, 09:10:37 AM |
|
cool, glad we could help. We had 1 chance on 2 to find the bug, if the first transaction I sent to piotr worked, we would have continued our lives with the bug lurking in the dark.  |
Bitcoin address 15sYbVpRh6dyWycZMwPdxJWD4xbfxReeHe
|
|
|
|
