It's a great and fun idea, but not that useful if you ask me. I would prefer engraved tungsten any time, any day. It looks much better as well
I can see why this would be ideal for some. I personally would prefer metal or stone over vinyl myself but that is just me. I can't imagine vinyl would last too long either to be honest not compared to metal and stone, at least not unless it is kept really safe.
I think this would open you up to a number of potential attacks. If someone knows that you are playing the disk that contains your private key then they could just "listen" for your private key and steal your funds.
You clearly don't know what BIP38 is. It encrypts your private key with a password/sentence that you choose. They would steal an encrypted private key and without knowing the code it will be useless for that person.