Bitcoin Forum
May 11, 2024, 08:33:41 AM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: [1]
  Print  
Author Topic: Adblock/ABP circumvention code may be causing LastPass to spring a memory leak  (Read 1243 times)
Kluge (OP)
Donator
Legendary
*
Offline Offline

Activity: 1218
Merit: 1015



View Profile
September 14, 2014, 11:54:49 PM
 #1

I've had an issue where Bitcointalk's Chrome tab would take up obscene amounts of memory. The most recent time I closed it, it neared 2GB, but this was after something like a week of the page being open on the same tab. This doesn't happen on any other page I'm aware of, but LastPass is known to have memory leak issues under certain circumstances on all browsers.

Disabling either Adblock or LastPass seems to resolve the issue, but if they're BOTH open and enabled on the page, it starts slowly growing, so my guess'd be that Adblock's modification of the pages are causing LastPass to store data it shouldn't be and not purging it, maybe due to the way BTCtalk tries to circumvent ad-blocking.

Since having Adblock or ABP enabled on this site'd be pointless, anyway, the obvious workaround is to disable AB/ABP. Fwiw.
In order to achieve higher forum ranks, you need both activity points and merit points.
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
theymos
Administrator
Legendary
*
Offline Offline

Activity: 5194
Merit: 12983


View Profile
September 15, 2014, 01:11:47 AM
Last edit: September 15, 2014, 01:22:45 AM by theymos
 #2

I don't do anything really strange to bypass ad-blocking, so I kind of doubt that this is the cause. If it is, then ABP or LastPass must be seriously broken.

The ABP bypassing methods are:
- Various CSS classes are randomized.
- The ad area looks just like a post from ABP's perspective, and it's surrounded by a random number of invisible "posts", so ABP can't target it accurately.
- If a link is blocked by ABP, and if the URL of the link is exactly equal to one of the URLs listed in the getabplink function (see the HTML source of any forum page), then the forum undoes the ad blocking using some simple JavaScript that I wrote. This code is only ever run once (after a 300ms delay on Chrome, immediately after the page loads on Firefox), so it shouldn't be able to cause endless reprocessing of the page or anything like that.

1NXYoJ5xU91Jp83XfVMHwwTUyZFK64BoAD
goozman96
Hero Member
*****
Offline Offline

Activity: 728
Merit: 500



View Profile
September 15, 2014, 01:40:09 AM
 #3

You should try to post this on the ABP forums. You don't even have to register to post.

https://adblockplus.org/forum/index.php

BTC: 19DKtsdGfQyFzNiEze9KuFQrWGiLDvg6F1 | LTC: LbV6UGyjYbVP49NvQFmuAnkADcaFYvNagK | NMC: NDCdMJmTmGH54Cezmo3CwSxAC7grAoZJbj
Kluge (OP)
Donator
Legendary
*
Offline Offline

Activity: 1218
Merit: 1015



View Profile
September 15, 2014, 02:19:28 AM
Last edit: September 15, 2014, 04:10:09 AM by Kluge
 #4

I'll let them both run again and record heap allocations for a while to try to see what it's grabbing if I can.

ETA: Chrome tab now takes up 432MB where it was previously at ~342MB when I last had this page open.

ETA2: Okay... so to figure out where I should be looking --
12:09PM
~70-71MB for BTCTalk, 521KB image cache, 37MB JS cache
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!