Just a heads up... I'm assuming you guys have this covered.
This was told to us in a recent convo about size of hashes
David,
Just for your info...
Blocknet is already aware.
https://gist.github.com/markblundeberg/7a932c98179de2190049f5823907c016https://github.com/bitcoin/bips/blob/master/bip-0180.mediawiki (edited)
Here is 86B's response on this glitch
86b - Yesterday at 10:33 PM
"Doesn’t apply to Blocknet as mentioned here:
""The atomic swaps from decred's setup look to be accidentally immune since the supported cryptocurrencies appear to all be forked from bitcoin and thus have the same 520 byte limit.""
"We dont support instances where this can be gamed, and we thoroughly vet our coins as we add them to prevent this from occurring altogether. Also, the xbridge itself is automatically generating the raw transactions involved in trades and anything done manually will be rejected by the DX platform itself"
My response is as follows...
Hey so that second comment had me a little bit concerned. If the xbridgde is a 3rd party and they make the raw they cannot know the hash in advance. If a 3rd party knows the hash then they can collude on the deal by brokering their own trade.
The hash is a secret that must only be known to the person selling X-Coin for Y-Coin
As long as blocknet only supports coins of 520 bytes you have nothing to worry about
but if anything bigger or smaller is chosen for trading pair then indeed a size check must happen on the hash