earlz (OP)
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:02:45 AM Last edit: October 23, 2014, 03:34:26 AM by earlz |
|
The ADMT thread is moderated and I assume my post will get deleted immediately. So, I'm posting with a new topic. Anyway, here is my review including the exploit. Summary is, the dev made a hidden premine of 20M or so, and hid it in such a way that not even traditional block explorers could reveal it My review follows adamantiumcoin https://bitcointalk.org/index.php?topic=829498.0
Heritage: HACK, DRM
Problems:
* CRITICAL: Reward for block 22 can be any amount that is desired ** The block explorer is compromised or the coin is serrepticious enough that it causes the block explorer to lie ** http://104.131.48.111:7200/block/00000283b17dbaa7445d64c988dcb7e58227ba49b686e029bbaf81bf67224993
review stopped at this point and early notice given to exchanges and miners.
Notes:
node: {"108.170.2.13", "108.170.2.13"},
this is where the dev allows a block with non-standard reward to be mined @@ -1582,7 +1583,7 @@ bool CBlock::ConnectBlock(CTxDB& txdb, CBlockIndex* pindex, bool fJustCheck) { int64_t nReward = GetProofOfWorkReward(nFees); // Check coinbase reward - if (vtx[0].GetValueOut() > nReward) + if (vtx[0].GetValueOut() > nReward && pindexBest->nHeight+1!=22) return DoS(50, error("ConnectBlock() : coinbase reward exceeded (actual=%"PRId64" vs calculated=%"PRId64")", vtx[0].GetValueOut(), nReward));
a variable used @@ -330,6 +332,7 @@ bool CTransaction::IsStandard() const // expensive-to-check-upon-redemption script like: // DUP CHECKSIG DROP ... repeated 100 times... OP_1 // +int64_t nvout=2000000000000000;
here is where the dev hides the amount in supply for RPC calls @@ -1618,6 +1620,10 @@ bool CBlock::ConnectBlock(CTxDB& txdb, CBlockIndex* pindex, bool fJustCheck) // Update block index on disk without changing it in memory. // The memory index structure will be changed after the db commits. + if(pindexBest->nHeight+1 == 22) { + pindex->nMint = nValueOut - nValueIn + nFees - nvout; + pindex->nMoneySupply = (pindex->pprev? pindex->pprev->nMoneySupply : 0) + nValueOut - nValueIn - nvout; + }
here is where he hides the amount mined with the generation transaction causing both my own block explorer, and Abe to report it wrongly +++ b/rpcrawtransaction.cpp @@ -74,7 +74,12 @@ void TxToJSON(const CTransaction& tx, const uint256 hashBlock, Object& entry) { const CTxOut& txout = tx.vout[i]; Object out; + if(tx.GetHash().GetHex() == "f48435e7305419f3fb4db67de5eca21bdd92a44babe7f056dfbeb1b7600d4c4e") { + out.push_back(Pair("value",0.00000000)); + } + else { out.push_back(Pair("value", ValueFromAmount(txout.nValue))); + }
Here is block 22 when these transaction hiding bits are removed: [earlz@li67-111 src]$ ./AdamantiumCoind getblockbynumber 22 true { "hash" : "00000283b17dbaa7445d64c988dcb7e58227ba49b686e029bbaf81bf67224993", "confirmations" : 596, "size" : 175, "height" : 22, "version" : 6, "merkleroot" : "f48435e7305419f3fb4db67de5eca21bdd92a44babe7f056dfbeb1b7600d4c4e", "mint" : 0.00000000, "time" : 1413949218, "nonce" : 7462376, "bits" : "1e02bf73", "difficulty" : 0.00142155, "blocktrust" : "5d29ee", "chaintrust" : "3b4a09d", "previousblockhash" : "000001f2f69d68be7ec69dd877f801963a823bf31691d69c5180c564d9d21d2f", "nextblockhash" : "000000bc54ac049a0c01fd2d3be098b08247bc16df20f1101a9b631a85f7f2fa", "flags" : "proof-of-work", "proofhash" : "00000283b17dbaa7445d64c988dcb7e58227ba49b686e029bbaf81bf67224993", "entropybit" : 1, "modifier" : "00000000001cb4ed", "modifierchecksum" : "8cbc4017", "tx" : [ { "txid" : "f48435e7305419f3fb4db67de5eca21bdd92a44babe7f056dfbeb1b7600d4c4e", "txid" : "f48435e7305419f3fb4db67de5eca21bdd92a44babe7f056dfbeb1b7600d4c4e", "version" : 1, "time" : 1413949218, "locktime" : 0, "vin" : [ { "coinbase" : "01160101", "sequence" : 4294967295 } ], "vout" : [ { "value" : 20000000.00000000, "n" : 0, "scriptPubKey" : { "asm" : "OP_DUP OP_HASH160 e829b472157a48cf939a76e66ac710c8d3898d95 OP_EQUALVERIFY OP_CHECKSIG", "reqSigs" : 1, "type" : "pubkeyhash", "addresses" : [ "AcwSNi1VZ41WLErCguXiTh9d9Q9CjEQ1rB" ] } } ] } ] }
Watermarks: uint64_t, pos, drm-like
Btw, if anyone would like to request a code review. I try to review popular and new coins automatically. However, if you want to request a coin reviewed quickly (24-72 hours), you can PM me. I require a modest payment though to skip the line since my time is at a premium.
|
|
|
|
inspirone1
Full Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif) ![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 327
Merit: 100
Open and Transparent Science Powered By Blockchain
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:09:35 AM |
|
I doubt the dev will delete anything as I bet he never post under that name again. Earlz Thanks for catching it before it went to far.
|
|
|
|
Nagger06
Newbie
Offline
Activity: 25
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:11:26 AM |
|
Im assuming the dev will read this and since the thread is locked i cant call him a cocksucker there so here:
DEV: You are a cocksucker.
|
|
|
|
inspirone1
Full Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif) ![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 327
Merit: 100
Open and Transparent Science Powered By Blockchain
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:17:06 AM |
|
Im assuming the dev will read this and since the thread is locked i cant call him a cocksucker there so here:
DEV: You are a cocksucker.
double that He already deleted and now locked the thread. I was hoping to at least get some kind of story out of him on it.
|
|
|
|
Pride-C-CEX
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:17:18 AM |
|
We greatly appreciate your swift contact regarding this, you are a class act!
|
|
|
|
tylerderden
Copper Member
Legendary
Offline
Activity: 1162
Merit: 1025
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:17:23 AM Last edit: October 31, 2014, 03:57:21 AM by tylerderden |
|
this shit sucks
|
|
|
|
icecube45
Legendary
Offline
Activity: 1218
Merit: 1000
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:19:07 AM |
|
Dev just deleted my original comment
|
|
|
|
adoalli
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:21:52 AM |
|
>:(SCAMCOIN
|
|
|
|
inspirone1
Full Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif) ![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 327
Merit: 100
Open and Transparent Science Powered By Blockchain
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:22:37 AM |
|
Theres still 13ghz of hash on this.
|
|
|
|
adoalli
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:26:25 AM |
|
Theres still 13ghz of hash on this.
don't waste your hashpower ![Roll Eyes](https://bitcointalk.org/Smileys/default/rolleyes.gif) im quit
|
|
|
|
forzendiablo
Legendary
Offline
Activity: 1526
Merit: 1000
the grandpa of cryptos
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:28:56 AM |
|
im not a coder but bumping this
|
yolo
|
|
|
Adamantium
Newbie
Offline
Activity: 14
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:29:58 AM |
|
First of my coins that failed.. Well! I guess I will have to hide everything in another way! I'll be back! ![Cool](https://bitcointalk.org/Smileys/default/cool.gif) PS: This is actually a good thing. Everyone should learn to take a look at the code before mining/hosting a pool/exchange/etc. EDIT: When that happens with every coin, only good ones will survive!
|
|
|
|
bathrobehero
Legendary
Offline
Activity: 2002
Merit: 1051
ICO? Not even once.
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:31:39 AM |
|
earlz, you're awesome!
|
Not your keys, not your coins!
|
|
|
kozmos
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:32:11 AM |
|
Thanks a lot earlz for the warning. and add this to the list of the dev's fiasco attempt lol: ![](https://ip.bitcointalk.org/?u=http%3A%2F%2Fi60.tinypic.com%2F155lzq8.jpg&t=665&c=Z_t7-SYSKjwkAQ) ![](https://ip.bitcointalk.org/?u=http%3A%2F%2Fi61.tinypic.com%2F20g07c0.jpg&t=665&c=GqDyhbz4wDMnOA)
|
|
|
|
earlz (OP)
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:35:06 AM |
|
Btw, if anyone would like to request a code review. I try to review popular and new coins automatically. However, if you want to request a coin reviewed quickly (24-72 hours), you can PM me. I require a modest payment though to skip the line since my time is at a premium.
|
|
|
|
TheClownSong
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:35:12 AM |
|
>:(SCAMCOIN
You think? looks like we have a genius in here..
|
|
|
|
inspirone1
Full Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif) ![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 327
Merit: 100
Open and Transparent Science Powered By Blockchain
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:36:22 AM |
|
First of my coins that failed.. Well! I guess I will have to hide everything in another way! I'll be back! ![Cool](https://bitcointalk.org/Smileys/default/cool.gif) PS: This is actually a good thing. Everyone should learn to take a look at the code before mining/hosting a pool/exchange/etc. EDIT: When that happens with every coin, only good ones will survive! You piece of shit!
|
|
|
|
adoalli
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:37:18 AM |
|
First of my coins that failed.. Well! I guess I will have to hide everything in another way! I'll be back! ![Cool](https://bitcointalk.org/Smileys/default/cool.gif) PS: This is actually a good thing. Everyone should learn to take a look at the code before mining/hosting a pool/exchange/etc. EDIT: When that happens with every coin, only good ones will survive! shit man
|
|
|
|
shojayxt
Legendary
Offline
Activity: 896
Merit: 1001
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:37:34 AM |
|
First of my coins that failed.. Well! I guess I will have to hide everything in another way! I'll be back! ![Cool](https://bitcointalk.org/Smileys/default/cool.gif) PS: This is actually a good thing. Everyone should learn to take a look at the code before mining/hosting a pool/exchange/etc. EDIT: When that happens with every coin, only good ones will survive! All your coins fail you pathetic loser or should I say carsen cocksucker. And no I didn't mine this shit. But apparently there are plenty of fools in altcoin land more than willing to help it implode by supporting obvious shitcoins.
|
|
|
|
inspirone1
Full Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif) ![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 327
Merit: 100
Open and Transparent Science Powered By Blockchain
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
October 23, 2014, 03:37:57 AM |
|
Btw, if anyone would like to request a code review. I try to review popular and new coins automatically. However, if you want to request a coin reviewed quickly (24-72 hours), you can PM me. I require a modest payment though to skip the line since my time is at a premium.
You should team up with POD (cryptoasian) do it as a add on paid service.
|
|
|
|
|