Bitcoin Forum
December 06, 2016, 10:08:21 AM *
News: Latest stable version of Bitcoin Core: 0.13.1  [Torrent].
 
   Home   Help Search Donate Login Register  
Pages: [1]
  Print  
Author Topic: [PATCH] (Mostly) Working backport to wx2.8  (Read 779 times)
Matt Corallo
Hero Member
*****
expert
Offline Offline

Activity: 751


View Profile
May 24, 2011, 02:02:38 AM
 #1

I decided to actually look at what is required to backport to wx2.8.  Actually, its mostly copy/paste/sed crap. 
Its done in the worst possible way and is ridiculously inefficient, I just wanted to see if it could be done.
As it turns out, it seems completely possible.
The GUI shows up and the majority seems to work.  Translations appear to work, but that is only in very brief testing.
I'm sure I've made 100 or more typos, so I'd like some corrections (and pointing out of much better ways of converting crap between wxString and std::string, if someone can find one).
You can grab the version at https://github.com/TheBlueMatt/bitcoin/tree/wx2.8

Bitcoin Ubuntu PPA maintainer - donate to me personally: 1JBMattRztKDF2KRS3vhjJXA7h47NEsn2c
http://bitcoinrelaynetwork.org maintainer
PGP ID: 07DF 3E57 A548 CCFB 7530  7091 89BB B866 3E2E65CE
1481018901
Hero Member
*
Offline Offline

Posts: 1481018901

View Profile Personal Message (Offline)

Ignore
1481018901
Reply with quote  #2

1481018901
Report to moderator
1481018901
Hero Member
*
Offline Offline

Posts: 1481018901

View Profile Personal Message (Offline)

Ignore
1481018901
Reply with quote  #2

1481018901
Report to moderator
1481018901
Hero Member
*
Offline Offline

Posts: 1481018901

View Profile Personal Message (Offline)

Ignore
1481018901
Reply with quote  #2

1481018901
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
Pieter Wuille
Legendary
*
qt
Offline Offline

Activity: 1036


View Profile WWW
May 24, 2011, 09:09:11 AM
 #2

Very nice! It doesn't seem to work completely yet, as I get weird character in the status column and status bar below. Apart from that, really good to see we don't need a dev branch of wxwindows.

One suggestion: is it possible to define _ yourself, so all the GetTranslationChar calls aren't necessary?

aka sipa, core dev team

Tips and donations: 1KwDYMJMS4xq3ZEWYfdBRwYG2fHwhZsipa
Matt Corallo
Hero Member
*****
expert
Offline Offline

Activity: 751


View Profile
May 24, 2011, 11:29:20 AM
 #3

Very nice! It doesn't seem to work completely yet, as I get weird character in the status column and status bar below. Apart from that, really good to see we don't need a dev branch of wxwindows.
Yea, that showed up in a couple places because I didn't handle temporary pointers right, I think I've fixed the majority of those now.
One suggestion: is it possible to define _ yourself, so all the GetTranslationChar calls aren't necessary?
Not really, _ has to return 3 different types (wxString, std::string, char*) and you can't override based on return value (AFAIK, but I may very well be wrong).  wx2.9 will convert properly automatically, but not with 2.8.

Bitcoin Ubuntu PPA maintainer - donate to me personally: 1JBMattRztKDF2KRS3vhjJXA7h47NEsn2c
http://bitcoinrelaynetwork.org maintainer
PGP ID: 07DF 3E57 A548 CCFB 7530  7091 89BB B866 3E2E65CE
Pages: [1]
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!