Bitcoin Forum
May 09, 2024, 08:13:38 PM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Bitcoin Forum > Bitcoin > Development & Technical Discussion > Tiny error in shy version message code
Pages: [1]
« previous topic next topic »
  Print  
Author Topic: Tiny error in shy version message code  (Read 1047 times)
realnowhereman (OP)
Hero Member
*****
Offline Offline

Activity: 504
Merit: 502



View Profile
May 25, 2011, 12:34:00 PM
 #1
Code:
0c97aa9e141f5:main.cpp:2388

        // Be shy and don't send version until we hear
        if (pfrom->fInbound)
            pfrom->PushVersion();

Shouldn't this be !pfrom->fInbound ?

Outbound connections should speak first, but this code makes inbound connections speak first.

I admit I don't really know what's going on since the following is present too:

Code:
0c97aa9e141f5:net.h:567

        // Be shy and don't send version until we hear
        if (!fInbound)
            PushVersion();

Which looks more correct to me.
1AAZ4xBHbiCr96nsZJ8jtPkSzsg1CqhwDa
"This isn't the kind of software where we can leave so many unresolved bugs that we need a tracker for them." -- Satoshi
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
1715285618
Hero Member
*
Offline Offline

Posts: 1715285618

View Profile Personal Message (Offline)

Ignore
1715285618
1715285618
Reply with quote  #2
1715285618
Report to moderator
1715285618
Hero Member
*
Offline Offline

Posts: 1715285618

View Profile Personal Message (Offline)

Ignore
1715285618
1715285618
Reply with quote  #2
1715285618
Report to moderator
1715285618
Hero Member
*
Offline Offline

Posts: 1715285618

View Profile Personal Message (Offline)

Ignore
1715285618
1715285618
Reply with quote  #2
1715285618
Report to moderator
Hal
VIP
Sr. Member
*
expert
Offline Offline

Activity: 314
Merit: 3853



View Profile
May 25, 2011, 08:19:14 PM
 #2
I'm the author of this code. The main.cpp code sends a version message in response to receiving one, on inbound connections.
Hal Finney
realnowhereman (OP)
Hero Member
*****
Offline Offline

Activity: 504
Merit: 502



View Profile
May 26, 2011, 06:12:54 AM
 #3
Of course.  Feeling dim now.
1AAZ4xBHbiCr96nsZJ8jtPkSzsg1CqhwDa
Pages: [1]
  Print  
Bitcoin Forum > Bitcoin > Development & Technical Discussion > Tiny error in shy version message code
 « previous topic next topic »
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!