[PATCH REQUEST] Variable ports (205BTC reward)

[mizerydearia]

I would like to request for a patch to be developed that allows a bitcoin client to have configurable ports (currently 8332 and 8333) using configuration file to determine which ports to use.  So as to incentivize development for this patch I would like to offer 5btc (I am poor) and if anyone else would like to additionally contribute so as to offer more incentive, feel free to reply.

    5btc (miz)
+ 200btc (aceat64)
--------
  205btc

jgarzik's patch

[1714972711]

1714972711

[1714972711]

1714972711

[1714972711]

1714972711

[Insti]

(I am poor)

Bitcoin donations received: 344.29

You probably didn't need to claim poverty.

[mizerydearia]

(I am poor)

Bitcoin donations received: 344.29

You probably didn't need to claim poverty.

I've donated to others as well, especially nanotube who has helped me a lot with bitbot!  The amount in the image is not indicative of how much I have, but rather total amount of donations overall.  Also, I would like to preserve some balance for future usage/expenditures/donations.  However, beyond scope of my Bitcoin balance, I am still unemployed and have no money remaining for any purpose (including foods) and am still lazy other than dedicating most of my time/effort towards Bitcoin-related projects.

[aceat64]

If someone wrote a patch that lets me set the IP/port for JSON-RPC in bitcoin.conf, I'll send them 200 BTC. 

[jgarzik]

Does this patch work for you guys?

     http://yyz.us/bitcoin/patch.bitcoin-bindaddr

The patch adds four command line parameters,

     -bindaddr=W.X.Y.Z      Bind to address W.X.Y.Z, instead of 127.0.0.1.  Supports bind-any modes via "*" and "0.0.0.0" addresses.
     -bindport=X         Bind to port X, instead of 8332
     -rpcaddr=W.X.Y.Z       Connect to address W.X.Y.Z, instead of 127.0.0.1
     -rpcport=X           Connect to port X, instead of 8332

Because of the way bitcoin works, all command line parameters may be specifed in the config file.  Therefore, the above would be added to the config file like this,

Code:

bindaddr=W.X.Y.Z
bindport=X
rpcaddr=W.X.Y.Z
rpcport=X

[aceat64]

Thank you jgarzik. The patch is working great, and I've sent the 200 BTC to the address in your signature.

[mizerydearia]

This doesn't seem to be compatible with Slight change so that JSON-RPC binds to all/any IPs instead of just the loopback..  Can these patches be combined or is one better than the other?

[jgarzik]

This doesn't seem to be compatible with Slight change so that JSON-RPC binds to all/any IPs instead of just the loopback..  Can these patches be combined or is one better than the other?

Those two patches attempt similar things, and so should be considered mutually incompatible.

[aceat64]

This doesn't seem to be compatible with Slight change so that JSON-RPC binds to all/any IPs instead of just the loopback..  Can these patches be combined or is one better than the other?

Those two patches attempt similar things, and so should be considered mutually incompatible.

Yup, I've removed my patch, as jgarzik's is better (mine was just a simple hack).

[mizerydearia]

Ah, cool.  Thanks for the confirmation.

[aceat64]

I've now removed jgarzik's patch from my client in favor of using Satoshi's -rpcallowip setting (since it's in the vanilla svn).

[nelisky]

I've now removed jgarzik's patch from my client in favor of using Satoshi's -rpcallowip setting (since it's in the vanilla svn).

But that doesn't allow separate ports to run multiple clients on the same machine, does it?

[aceat64]

I've now removed jgarzik's patch from my client in favor of using Satoshi's -rpcallowip setting (since it's in the vanilla svn).

But that doesn't allow separate ports to run multiple clients on the same machine, does it?

That is correct, but my main concern was being able to connect to the JSON-RPC interface from somewhere other than localhost. Specifically so that I could manage my nodes with phpMyBitcoin.

[jgarzik]

I've now removed jgarzik's patch from my client in favor of using Satoshi's -rpcallowip setting (since it's in the vanilla svn).

But that doesn't allow separate ports to run multiple clients on the same machine, does it?

I'll update my patch on top of -rpcallowip soonish...  The JSON-RPC port is still hardcoded as 8332 in vanilla svn

[jgarzik]

Patch updated for latest SVN.  Given recent upstream changes to support binding to any address (0.0.0.0 or '*'), this patch is reduced to adding an option to bind or connect to a non-standard, not 8332 port:

URL: http://yyz.us/bitcoin/patch.bitcoin-bindaddr

[aceat64]

Patch updated for latest SVN.  Given recent upstream changes to support binding to any address (0.0.0.0 or '*'), this patch is reduced to adding an option to bind or connect to a non-standard, not 8332 port:

URL: http://yyz.us/bitcoin/patch.bitcoin-bindaddr

I've added the new bindaddr patch to my client.

[nelisky]

I know my usecase (multiple bitcoin clients on the same server) is not the same thing that is being solved by this patch, it does fix most of it. The only thing remaining is to prevent binding to 8333 (no reason to change that, as other clients only try to connect to 8333, afaict. IRC only advertises IP, right?).

I've patched my client with this simple change:

Code:

--- a/net.cpp
+++ b/net.cpp
@@ -1236,6 +1236,9 @@ bool BindListenPort(string& strError)
     memset(&sockaddr, 0, sizeof(sockaddr));
     sockaddr.sin_family = AF_INET;
     sockaddr.sin_addr.s_addr = INADDR_ANY; // bind to all IPs on this computer
+    if (mapArgs.count("-disableinbound")) {
+      return true;
+    }
     sockaddr.sin_port = DEFAULT_PORT;
     if (::bind(hListenSocket, (struct sockaddr*)&sockaddr, sizeof(sockaddr)) == SOCKET_ERROR)
     {

so passing the -disableinbound switch makes it not try to bind the 8333 port.

[mizerydearia]

no reason to change that, as other clients only try to connect to 8333, afaict. IRC only advertises IP, right?

For IRC I set my user name to 8332 and my real name to 8333 as per server connection configuration and then connected.

Code:

/whois necrodearia
[necrodearia] (8332@address.net): 8333
* [necrodearia] #bitcoin-dev #bitcoin
* [necrodearia] peacock.heliacal.net :Chicago, IL USA
* [necrodearia] idle 00:00:09, signon: Tue Sep 21 07:46:38
* [necrodearia] End of WHOIS list.

Using this method, it is possible to embed port numbers that a client is using into their IRC connection so that ports are not restricted to 8332 and 8333.  I suggest implementing this or a related implementation into a future version of Bitcoin.

Satoshi o/

[Gavin Andresen]

no reason to change that, as other clients only try to connect to 8333, afaict. IRC only advertises IP, right?

No, both IP and port are encoded in the #bitcoin IRC usernames (see the EncodeAddress/DecodeAddress routines in irc.cpp).

(so mizerydearia:  no need to do what you done did...)

[nelisky]

no reason to change that, as other clients only try to connect to 8333, afaict. IRC only advertises IP, right?

No, both IP and port are encoded in the #bitcoin IRC usernames (see the EncodeAddress/DecodeAddress routines in irc.cpp).

(so mizerydearia:  no need to do what you done did...)

So I could use -inboundport=<port> and use that instead of DEFAULT_PORT, or if 0 disable inbound completely like I do now. Hmmm, I feel a patch to your patch coming.