[PULL] dns lookups for -addnode and -connect

[Pieter Wuille]

Hello,

I've created a pull request that adds support for DNS lookups in -addnode and -connect, as I think it's a very useful feature.

Apparently it is considered a security issue by some (including satoshi, I've been told), so by default it is disabled, and the command line option -dns needs to be passed to enable it (as suggested by jgarzic)

See https://github.com/bitcoin/bitcoin/pull/192

[HostFat]

Can you add an option? ( like upnp )

[Cdecker]

I actually think it is useful. It would be even more useful to allow most of these options configurable through the config file.

+1

Edit: as for security reasons: we do trust peers exchanged from others, so there are easier ways to inject and propagate malicious contacts.

[Gavin Andresen]

I actually think it is useful. It would be even more useful to allow most of these options configurable through the config file.

All command-line options (except for -datadir and -conf) can be specified in the config file.

[Cdecker]

All command-line options (except for -datadir and -conf) can be specified in the config file.

And there I was thinking that I figured out everything ^^ Thanks for the correction.

[xf2_org]

See comments at the pull request.

User interface is OK (-dns, changing -addnode and -connect behavior, etc.), but the code needs to be turned "inside out."  DNS produces multiple addresses, and thus has a one-to-many relationship between DNS name and CAddress...  but the DNS lookup is stuffed inside a CAddress object.

The code should instead have a helper that produces a vector of CAddress, from a DNS lookup, or a helper that creates and pushes multiple CAddress objects into AddAddress()

[theymos]

DNS would be very nice. Maybe it can be extended to IP transactions, too.

[Pieter Wuille]

Updated.

[xf2_org]

Pulled into upstream.