|
Pieter Wuille (OP)
|
 |
May 03, 2011, 12:05:09 PM
Last edit: May 03, 2011, 12:49:30 PM by sipa |
|
Hello, I've created a pull request that adds support for DNS lookups in -addnode and -connect, as I think it's a very useful feature. Apparently it is considered a security issue by some (including satoshi, I've been told), so by default it is disabled, and the command line option -dns needs to be passed to enable it (as suggested by jgarzic) See https://github.com/bitcoin/bitcoin/pull/192 |
I do Bitcoin stuff.
|
|
|
|
|
|
|
|
The grue lurks in the darkest places of the earth. Its favorite diet is adventurers, but its insatiable appetite is tempered by its fear of light. No grue has ever been seen by the light of day, and few have survived its fearsome jaws to tell the tale.
|
|
|
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
|
|
|
|
|
|
|
HostFat
Staff
Legendary
 Offline
Activity: 4214
Merit: 1203
I support freedom of choice
|
|
May 03, 2011, 12:25:08 PM |
|
Can you add an option? ( like upnp )
|
|
|
|
|
Cdecker
|
|
May 03, 2011, 12:39:49 PM |
|
I actually think it is useful. It would be even more useful to allow most of these options configurable through the config file.
+1
Edit: as for security reasons: we do trust peers exchanged from others, so there are easier ways to inject and propagate malicious contacts.
|
|
|
|
Gavin Andresen
Legendary
Offline
Activity: 1652
Merit: 2216
Chief Scientist
|
|
May 03, 2011, 12:54:15 PM |
|
I actually think it is useful. It would be even more useful to allow most of these options configurable through the config file.
All command-line options (except for -datadir and -conf) can be specified in the config file. |
How often do you get the chance to work on a potentially world-changing project?
|
|
|
|
Cdecker
|
|
May 03, 2011, 01:01:34 PM |
|
All command-line options (except for -datadir and -conf) can be specified in the config file. And there I was thinking that I figured out everything ^^ Thanks for the correction. |
|
|
|
xf2_org
Member
Offline
Activity: 98
Merit: 13
|
|
May 03, 2011, 02:14:15 PM |
|
See comments at the pull request.
User interface is OK (-dns, changing -addnode and -connect behavior, etc.), but the code needs to be turned "inside out." DNS produces multiple addresses, and thus has a one-to-many relationship between DNS name and CAddress... but the DNS lookup is stuffed inside a CAddress object.
The code should instead have a helper that produces a vector of CAddress, from a DNS lookup, or a helper that creates and pushes multiple CAddress objects into AddAddress()
|
|
|
|
|
theymos
Administrator
Legendary
Offline
Activity: 5194
Merit: 12983
|
|
May 03, 2011, 09:26:28 PM |
|
DNS would be very nice. Maybe it can be extended to IP transactions, too.
|
1NXYoJ5xU91Jp83XfVMHwwTUyZFK64BoAD
|
|
|
|
Pieter Wuille (OP)
|
|
May 05, 2011, 01:59:31 PM |
|
Updated.
|
I do Bitcoin stuff.
|
|
|
xf2_org
Member
Offline
Activity: 98
Merit: 13
|
|
May 12, 2011, 09:33:23 PM |
|
Pulled into upstream.
|
|
|
|
|
|
