Bitcoin Forum
December 10, 2016, 01:09:49 AM *
News: Latest stable version of Bitcoin Core: 0.13.1  [Torrent].
 
   Home   Help Search Donate Login Register  
Pages: [1]
  Print  
Author Topic: [PULL] dns lookups for -addnode and -connect  (Read 1084 times)
Pieter Wuille
Legendary
*
qt
Offline Offline

Activity: 1036


View Profile WWW
May 03, 2011, 12:05:09 PM
 #1

Hello,

I've created a pull request that adds support for DNS lookups in -addnode and -connect, as I think it's a very useful feature.

Apparently it is considered a security issue by some (including satoshi, I've been told), so by default it is disabled, and the command line option -dns needs to be passed to enable it (as suggested by jgarzic)

See https://github.com/bitcoin/bitcoin/pull/192

aka sipa, core dev team

Tips and donations: 1KwDYMJMS4xq3ZEWYfdBRwYG2fHwhZsipa
1481332189
Hero Member
*
Offline Offline

Posts: 1481332189

View Profile Personal Message (Offline)

Ignore
1481332189
Reply with quote  #2

1481332189
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
HostFat
Staff
Legendary
*
Offline Offline

Activity: 2296


I support freedom of choice


View Profile WWW
May 03, 2011, 12:25:08 PM
 #2

Can you add an option? ( like upnp )

Eternity Wall: Messages lasting forever - The Rock Trading (ref): A good exchange / gateway Ripple, with support for multisig, since 2007. 
https://bitcointa.lk: Bitcointalk backup if offline - Bitcoin Foundation Italia - Blog: http://theupwind.blogspot.it
Cdecker
Hero Member
*****
Offline Offline

Activity: 487



View Profile WWW
May 03, 2011, 12:39:49 PM
 #3

I actually think it is useful. It would be even more useful to allow most of these options configurable through the config file.

+1

Edit: as for security reasons: we do trust peers exchanged from others, so there are easier ways to inject and propagate malicious contacts.

Want to see what developers are chatting about? http://bitcoinstats.com/irc/bitcoin-dev/logs/
Bitcoin-OTC Rating
Gavin Andresen
Legendary
*
qt
Offline Offline

Activity: 1652


Chief Scientist


View Profile WWW
May 03, 2011, 12:54:15 PM
 #4

I actually think it is useful. It would be even more useful to allow most of these options configurable through the config file.

All command-line options (except for -datadir and -conf) can be specified in the config file.

How often do you get the chance to work on a potentially world-changing project?
Cdecker
Hero Member
*****
Offline Offline

Activity: 487



View Profile WWW
May 03, 2011, 01:01:34 PM
 #5

All command-line options (except for -datadir and -conf) can be specified in the config file.
And there I was thinking that I figured out everything ^^ Thanks for the correction.

Want to see what developers are chatting about? http://bitcoinstats.com/irc/bitcoin-dev/logs/
Bitcoin-OTC Rating
xf2_org
Member
**
Offline Offline

Activity: 70


View Profile
May 03, 2011, 02:14:15 PM
 #6

See comments at the pull request.

User interface is OK (-dns, changing -addnode and -connect behavior, etc.), but the code needs to be turned "inside out."  DNS produces multiple addresses, and thus has a one-to-many relationship between DNS name and CAddress...  but the DNS lookup is stuffed inside a CAddress object.

The code should instead have a helper that produces a vector of CAddress, from a DNS lookup, or a helper that creates and pushes multiple CAddress objects into AddAddress()

theymos
Administrator
Legendary
*
expert
Offline Offline

Activity: 2506


View Profile
May 03, 2011, 09:26:28 PM
 #7

DNS would be very nice. Maybe it can be extended to IP transactions, too.

1NXYoJ5xU91Jp83XfVMHwwTUyZFK64BoAD
Pieter Wuille
Legendary
*
qt
Offline Offline

Activity: 1036


View Profile WWW
May 05, 2011, 01:59:31 PM
 #8

Updated.

aka sipa, core dev team

Tips and donations: 1KwDYMJMS4xq3ZEWYfdBRwYG2fHwhZsipa
xf2_org
Member
**
Offline Offline

Activity: 70


View Profile
May 12, 2011, 09:33:23 PM
 #9

Pulled into upstream.
Pages: [1]
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!