Bug: Incorrect datadir location on Windows

[theymos]

On Windows, Electrum puts its data directory in %LOCALAPPDATA%. This is incorrect. %LOCALAPPDATA% is for non-critical files such as temporary files. This directory is usually not backed up by backup software, and it is sometimes scheduled to be reset regularly. Clearly not a good place for wallet files.

The correct location is %APPDATA%.

[1714129237]

1714129237

[1714129237]

1714129237

[Tachikoma]

I could change this but I guess we need some intelligent code that will check if there are wallets in %LOCALAPPDATA% and move them to %APPDATA%.

Do you have a source about this? (APPDATA vs LOCALAPPDATA)

[theymos]

I could change this but I guess we need some intelligent code that will check if there are wallets in %LOCALAPPDATA% and move them to %APPDATA%.

Yeah, that's why I didn't just fix it myself and submit a pull request.

Do you have a source about this? (APPDATA vs LOCALAPPDATA)

Windows uses the Local and LocalLow folders for application data that does not roam with the user. Usually this data is either machine specific or too large to roam. The AppData\Local folder in Windows Vista is the same as the Documents and Settings\username\Local Settings\Application Data folder in Windows XP.

Windows uses the Roaming folder for application specific data, such as custom dictionaries, which are machine independent and should roam with the user profile. The AppData\Roaming folder in Windows Vista is the same as the Documents and Settings\username\Application Data folder in Windows XP.

Basically this means that Local/LocalLow stuff, since it doesn't "roam with the user", isn't very important and doesn't need to be saved.

[Tachikoma]

I've just pushed this commit to the repository.

I setup a rudimentary Windows VM to test it and I think it works, but I don't normally work on the windows bits. I would appreciate a code review if you are able and if you have a local Python development environment I would appreciate it if you could check it out. If not there should be a nightly build tonight with the commit in it here.

[theymos]

It works for me, though I get this warning:

C:\Users\Michael\Desktop\electrum-master\lib\util.py:72: SyntaxWarning: import * only allowed at module level

Thanks.

[Tachikoma]

Yeah I noticed that myself after I got some sleep, will have to ask Thomas on how to best handle this one. Will fix that in master as soon as I can.