0.96.4 RC1

[goatpig]

The logs with the error backtraces should be there regardless of what version you are running now though. That's what I'm asking for.

[1714850987]

1714850987

[1714850987]

1714850987

[1714850987]

1714850987

[Casimir1904]

The logs with the error backtraces should be there regardless of what version you are running now though. That's what I'm asking for.

Code:

2017-11-22 15:15:39 (INFO) -- TxFrames.py:727 - Change address behavior: NewAddr
2017-11-22 15:15:39 (ERROR) -- Traceback (most recent call last):
  File "/usr/local/lib/armory/ui/TxFrames.py", line 848, in createTxAndBroadcast
    ustx = self.validateInputsGetUSTX()
  File "/usr/local/lib/armory/ui/TxFrames.py", line 802, in validateInputsGetUSTX
    lockTime=TheBDM.getTopBlockHeight())
  File "/usr/local/lib/armory/armoryengine/Transaction.py", line 2287, in createFromTxOutSelection
    return self.createFromPyTx(thePyTx, pubKeyMap, txMap, p2shMap)
  File "/usr/local/lib/armory/armoryengine/Transaction.py", line 2196, in createFromPyTx
    cppPrevTx = TheBDM.bdv().getTxByHash(txhash)
  File "/usr/local/lib/armory/CppBlockUtils.py", line 2758, in getTxByHash
    return _CppBlockUtils.BlockDataViewer_getTxByHash(self, txHash)
DbErrorMsg: <CppBlockUtils.DbErrorMsg; proxy of <Swig Object of type 'DbErrorMsg *' at 0x7fc0d9941a80> >

[goatpig]

It's suggesting your DB is corrupt.

[Casimir1904]

It's suggesting your DB is corrupt.

Rebuild more than once in the last days...

[goatpig]

Put the call in a try block and print the error message. Something like this:

Code:

         try:
            cppPrevTx = TheBDM.bdv().getTxByHash(txhash)
         except DbErrorMsg as e:
            print e.what()
            raise e

Btw this traceback is for code from master (0.96.3). Have you reproduced the same issue with the testing branch?

[Casimir1904]

Put the call in a try block and print the error message. Something like this:

Code:

         try:
            cppPrevTx = TheBDM.bdv().getTxByHash(txhash)
         except DbErrorMsg as e:
            print e.what()
            raise e

Btw this traceback is for code from master (0.96.3). Have you reproduced the same issue with the testing branch?

I'll build the testing tomorrow again. ( ATM its rebuilding the DB again ).

[Casimir1904]

I've setup on a clean new machine and now it works.
The signer still need to be fixed on my side as the signed TX is not recognized but i'm able to just broadcast the raw tx.

[goatpig]

I've setup on a clean new machine and now it works.
The signer still need to be fixed on my side as the signed TX is not recognized but i'm able to just broadcast the raw tx.

Do you have an error log for that last part?

[Casimir1904]

I've setup on a clean new machine and now it works.
The signer still need to be fixed on my side as the signed TX is not recognized but i'm able to just broadcast the raw tx.

Do you have an error log for that last part?

Guess this one:

Code:

(WARNING) Transaction.py:1263 - Unexpected nested type for TxIn 16
(ERROR) Transaction.py:1289 - Insert list has index too big
(ERROR) Transaction.py:1289 - Insert list has index too big

But could be just because the signer is on an older version and the online node is on the current testing.

[goatpig]

Ah indeed, the signer and online instance need to be in lockstep.

[RustyRussell]

Same problem with my save and restored 1RustyR vanity wallet:

(ERROR) TxFrames.py:925 - Problem sending transaction!
Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 919, in createTxAndBroadcast
    ustxSigned = self.wlt.signUnsignedTx(ustx, signer=self.signerType)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 2705, in signUnsignedTx
    signerType=signer)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 2886, in createAndInsertSignatureForInput
    DetSign, signerType=signerType)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 1507, in createAndInsertSignature
    DetSign, signerType=signerType)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 1425, in createTxSignature
    raise SignatureError('No PubKey that matches this privKey')
SignatureError: No PubKey that matches this privKey
(ERROR) Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 919, in createTxAndBroadcast
    ustxSigned = self.wlt.signUnsignedTx(ustx, signer=self.signerType)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 2705, in signUnsignedTx
    signerType=signer)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 2886, in createAndInsertSignatureForInput
    DetSign, signerType=signerType)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 1507, in createAndInsertSignature
    DetSign, signerType=signerType)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 1425, in createTxSignature
    raise SignatureError('No PubKey that matches this privKey')
SignatureError: No PubKey that matches this privKey

Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 919, in createTxAndBroadcast
    ustxSigned = self.wlt.signUnsignedTx(ustx, signer=self.signerType)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 2705, in signUnsignedTx
    signerType=signer)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 2886, in createAndInsertSignatureForInput
    DetSign, signerType=signerType)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 1507, in createAndInsertSignature
    DetSign, signerType=signerType)
  File "/usr/lib/armory/armoryengine/Transaction.py", line 1425, in createTxSignature
    raise SignatureError('No PubKey that matches this privKey')     
armoryengine.ArmoryUtils.SignatureError: No PubKey that matches this privKey

[goatpig]

What's vanity about it? Did you import a private key?

Edit:

Did you update your signer? Are you using mismatched versions between signer and online?

[RustyRussell]

What's vanity about it? Did you import a private key?

Edit:

Did you update your signer? Are you using mismatched versions between signer and online?

Yes, 1RustyRX2oai4EYYDpQGWvEL62BBGqN9T didn't occur naturally

Hmm, it's the armory_0.96.3.99-gcc5.4_amd64.deb so I assume it's all included.  I'm not doing offline signing.

I don't need to reboot or anything?

Happy to hand you whatever you need via GPG email, if it helps.

Thanks,
Rusty.

[goatpig]

It looks like the Python signer is failing to populate the pubkey list of the unsigned tx object when it comes to imports. I'll investigate. For now, set yourself in expert user mode and try to manually pick the C++ signer at spend time, see if that fixes your issue.

[RustyRussell]

It looks like the Python signer is failing to populate the pubkey list of the unsigned tx object when it comes to imports. I'll investigate. For now, set yourself in expert user mode and try to manually pick the C++ signer at spend time, see if that fixes your issue.

(ERROR) TxFrames.py:925 - Problem sending transaction!
Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 919, in createTxAndBroadcast
    ustxSigned = self.wlt.signUnsignedTx(ustx, signer=self.signerType)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 2722, in signUnsignedTx
    cppsigner.signTx()
  File "/usr/lib/armory/CppBlockUtils.py", line 4165, in signTx
    return _CppBlockUtils.PythonSigner_signTx(self)
RuntimeError: failed signature
(ERROR) Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 919, in createTxAndBroadcast
    ustxSigned = self.wlt.signUnsignedTx(ustx, signer=self.signerType)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 2722, in signUnsignedTx
    cppsigner.signTx()
  File "/usr/lib/armory/CppBlockUtils.py", line 4165, in signTx
    return _CppBlockUtils.PythonSigner_signTx(self)
RuntimeError: failed signature

Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 919, in createTxAndBroadcast
    ustxSigned = self.wlt.signUnsignedTx(ustx, signer=self.signerType)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 2722, in signUnsignedTx
    cppsigner.signTx()
  File "/usr/lib/armory/CppBlockUtils.py", line 4165, in signTx
    return _CppBlockUtils.PythonSigner_signTx(self)
RuntimeError: failed signature

[goatpig]

I'll try to reproduce on my end and report back here.

[goatpig]

I have failed to reproduce the issue on my own. This has something to do with the state of your wallets. I'm going to need more data to figure out what's going. For starters, delete the .lmdb files in your datadir. They will reconstructed on the next run. See if that helps with the C++ signer.

[RustyRussell]

I have failed to reproduce the issue on my own. This has something to do with the state of your wallets. I'm going to need more data to figure out what's going. For starters, delete the .lmdb files in your datadir. They will reconstructed on the next run. See if that helps with the C++ signer.

Woot!  Thanks, removing them, and with C++ signer, it worked.

Still have those 4 confirmed txs which Armory thinks aren't confirmed (and offers to bump fee).  I'll append tomorrow this one gets similarly stuck.

[goatpig]

Woot!  Thanks, removing them, and with C++ signer, it worked.

I'm going to assume the situation has not change with the Python signer, right? Definitely something weird with the wallet state.

Still have those 4 confirmed txs which Armory thinks aren't confirmed (and offers to bump fee).  I'll append tomorrow this one gets similarly stuck.

There are 3 possible states:

1) The ZC DB is corrupt and still shows the tx as unconfirmed, while they also appear as confirmed in the ledger. In this case, you can clear unconfirmed tx from the Help menu and restart Armory.

2) The ZC never actually mined. In this case, they may or may not be in the in a miner's mempool. You can just RBF these. You'll probably have to build the current state of testing as it has the RBF fixes in there. If you want signed builds, you'll have to wait till I'm done with this accursed BTG signer.

3) Your DB is stuck and can't see new blocks, therefor will never see these tx mined. You can check for this state by comparing Armory's top block (bottom right corner) to your network's top block. In this case, I'd need to see dbLog.txt before I can give you recommendations on how to proceed.

[Casimir1904]

I'm trying to spend some mixed inputs but armory wont let me.

Code:

Traceback (most recent call last):
  File "/usr/local/lib/armory/ui/TxFrames.py", line 927, in createTxAndBroadcast
    self.createUnsignedTxCallback(ustx)
  File "/usr/local/lib/armory/qtdialogs.py", line 4607, in createUnsignedTxAndDisplay
    dlg = DlgOfflineTxCreated(self.frame.wlt, ustx, self.parent, self.main)
  File "/usr/local/lib/armory/qtdialogs.py", line 4651, in __init__
    reviewOfflineTxFrame.setUSTX(ustx)
  File "/usr/local/lib/armory/ui/TxFrames.py", line 1686, in setUSTX
    self.txtUSTX.setText(ustx.serializeAscii())
  File "/usr/local/lib/armory/armoryengine/AsciiSerialize.py", line 67, in serializeAscii
    return makeAsciiBlock(self.serialize(), headStr)
  File "/usr/local/lib/armory/armoryengine/Transaction.py", line 2510, in serialize
    bp.put(VAR_STR, ustxi.serialize())
  File "/usr/local/lib/armory/armoryengine/Transaction.py", line 1698, in serialize
    bp.put(VAR_STR,      self.p2shMap[BASE_SCRIPT])
KeyError: 'base_script'

Selecting only 1 type of inputs works.
Isn't it possible to mix segwit with non segwit inputs?