Bitcoin Forum
May 06, 2024, 08:17:07 AM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: « 1 2 3 4 5 6 7 8 9 10 11 [12] 13 »  All
  Print  
Author Topic: [20 BTC] Multithreaded Keep-alive Implementation in Bitcoind  (Read 31401 times)
AnnihilaT
Full Member
***
Offline Offline

Activity: 210
Merit: 100



View Profile
July 27, 2011, 03:25:41 PM
 #221

Why would you want the older version?

Anyway ... I think there might be a small memory leak somewhere still.  My bitcoind is up to almost 700m at this point and I'm getting some connection errors occasionally, though that may be due to some other issues not related to bitcoind.


I wanted it only to diff against 0.99 since you guys said you were running that version without problems so i was curious to see what changes had been made in 0.99. 

Logical, no?
Make sure you back up your wallet regularly! Unlike a bank account, nobody can help you if you lose access to your BTC.
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
1714983427
Hero Member
*
Offline Offline

Posts: 1714983427

View Profile Personal Message (Offline)

Ignore
1714983427
Reply with quote  #2

1714983427
Report to moderator
AnnihilaT
Full Member
***
Offline Offline

Activity: 210
Merit: 100



View Profile
July 28, 2011, 01:37:27 PM
 #222

Im seeing the same thing regarding a possible memory leak.  Continual growth of used memory over the last 24 hours or so... up to 453368kB now and growing...
phorensic
Hero Member
*****
Offline Offline

Activity: 630
Merit: 500



View Profile
July 28, 2011, 03:54:54 PM
 #223

Been running it for a week strong now.  I don't know if I would consider it a memory leak, but ours is at just under 700m used.  Running in -hub level 1 with built in LP.
AnnihilaT
Full Member
***
Offline Offline

Activity: 210
Merit: 100



View Profile
July 28, 2011, 04:25:55 PM
 #224

Im seeing the same thing regarding a possible memory leak.  Continual growth of used memory over the last 24 hours or so... up to 453368kB now and growing...

spoke too soon.... it just went down to just under 350m Smiley
Inaba
Legendary
*
Offline Offline

Activity: 1260
Merit: 1000



View Profile WWW
July 28, 2011, 04:30:04 PM
 #225

Mine is right around 700m after a week or so, same as Phorensic.  We'll see how to goes as time goes on.  Seems a little excessive though.

If you're searching these lines for a point, you've probably missed it.  There was never anything there in the first place.
JoelKatz
Legendary
*
Offline Offline

Activity: 1596
Merit: 1012


Democracy is vulnerable to a 51% attack.


View Profile WWW
July 28, 2011, 06:35:08 PM
 #226

Testing bitcoind v0.3.24 + Joel Katz v0.99 4diff on our pool now.... so far so good in the last 15 mins...

Does anyone know the difd from 0.98 and 0.99 ?  couldnt find a copy of the older version anywhere.
There was a change from Giel de Nijs for an issue that maybe could cause stale shares. Neither of us is sure the issue can actually happen, but the patch is obviously safe and might fix a real problem, so I merged it. The change moves the code to send a SIGUSR1 for native long-polling to later in the code path.

Sorry, I meant to put a changelog at the top of the patch and it just didn't happen.

I am an employee of Ripple. Follow me on Twitter @JoelKatz
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
AnnihilaT
Full Member
***
Offline Offline

Activity: 210
Merit: 100



View Profile
July 28, 2011, 07:50:00 PM
 #227

Testing bitcoind v0.3.24 + Joel Katz v0.99 4diff on our pool now.... so far so good in the last 15 mins...

Does anyone know the difd from 0.98 and 0.99 ?  couldnt find a copy of the older version anywhere.
There was a change from Giel de Nijs for an issue that maybe could cause stale shares. Neither of us is sure the issue can actually happen, but the patch is obviously safe and might fix a real problem, so I merged it. The change moves the code to send a SIGUSR1 for native long-polling to later in the code path.

Sorry, I meant to put a changelog at the top of the patch and it just didn't happen.


Ok clear!  THanks for the reply Smiley
denis2342
Newbie
*
Offline Offline

Activity: 29
Merit: 0



View Profile WWW
July 29, 2011, 10:30:11 AM
 #228

Hi

I tested the native long polling patch and noticed that it fired the signal so early that pushpoold got the old block and not the new one. So it seems you have it fixed now.

I also moved the patch to the end of the function and I never saw the problem again.

Denis

PS: I couldn't write here because my account was not activated until now
JoelKatz
Legendary
*
Offline Offline

Activity: 1596
Merit: 1012


Democracy is vulnerable to a 51% attack.


View Profile WWW
July 29, 2011, 10:33:33 AM
 #229

I remember specifically thinking, when I placed the code, that the code held a lock that wouldn't let the 'getwork' code run until it was safe anyway. But then I looked back after I got the patch from Giel, and I couldn't figure out what I saw that justified that belief.

I am an employee of Ripple. Follow me on Twitter @JoelKatz
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
Balthazar
Legendary
*
Offline Offline

Activity: 3108
Merit: 1358



View Profile
October 17, 2011, 01:09:21 PM
 #230

...
Hi. Do you have plans for bitcoin v0.4? Smiley Current patches are incompatible with it because of some changes in RPC. Sad
JoelKatz
Legendary
*
Offline Offline

Activity: 1596
Merit: 1012


Democracy is vulnerable to a 51% attack.


View Profile WWW
October 17, 2011, 06:50:49 PM
 #231

...
Hi. Do you have plans for bitcoin v0.4? Smiley Current patches are incompatible with it because of some changes in RPC. Sad
http://davids.webmaster.com/~davids/bitcoin-4diff-beta.txt

I am an employee of Ripple. Follow me on Twitter @JoelKatz
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
Balthazar
Legendary
*
Offline Offline

Activity: 3108
Merit: 1358



View Profile
October 18, 2011, 09:18:55 AM
 #232

...
Hi. Do you have plans for bitcoin v0.4? Smiley Current patches are incompatible with it because of some changes in RPC. Sad
http://davids.webmaster.com/~davids/bitcoin-4diff-beta.txt
Thanks. I'll try test this today and write the report here.

// /me tried to implement support for 0.4 yesterday, but faced with stability problems.
Balthazar
Legendary
*
Offline Offline

Activity: 3108
Merit: 1358



View Profile
October 18, 2011, 12:49:15 PM
 #233

It works great. 80% CPU usage & disconnects ==> 10-15% & rock stable.  Smiley
Jine (OP)
Sr. Member
****
Offline Offline

Activity: 403
Merit: 250


View Profile
October 23, 2011, 07:03:01 AM
 #234

...
Hi. Do you have plans for bitcoin v0.4? Smiley Current patches are incompatible with it because of some changes in RPC. Sad
http://davids.webmaster.com/~davids/bitcoin-4diff-beta.txt

Hi!

Have anyone tested out the 0.4 beta patch successfully?
Any comparison with the 0.32 patch?

I'm thinking of setting up a new environment with poolserverj + 0.4.

Previous founder of Bit LC Inc. | I've always loved the idea of bitcoin.
JoelKatz
Legendary
*
Offline Offline

Activity: 1596
Merit: 1012


Democracy is vulnerable to a 51% attack.


View Profile WWW
October 23, 2011, 11:41:12 PM
 #235

Have anyone tested out the 0.4 beta patch successfully?
Any comparison with the 0.32 patch?

I'm thinking of setting up a new environment with poolserverj + 0.4.
Several people have been using it for two weeks or more, and I haven't received any issue reports yet.

I am an employee of Ripple. Follow me on Twitter @JoelKatz
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
Justin Bieber
Newbie
*
Offline Offline

Activity: 14
Merit: 0



View Profile
October 25, 2011, 03:47:22 PM
 #236

Quote from: JoelKatz
awesomeness
Is there one in the pipeline for 0.5? The RPC changes are a little too much for me to handle.
JoelKatz
Legendary
*
Offline Offline

Activity: 1596
Merit: 1012


Democracy is vulnerable to a 51% attack.


View Profile WWW
October 25, 2011, 08:34:47 PM
 #237

Quote from: JoelKatz
awesomeness
Is there one in the pipeline for 0.5? The RPC changes are a little too much for me to handle.
I'll try to find time to work on it in the next few days. It's hard to refuse a request from someone with perfect hair.

I am an employee of Ripple. Follow me on Twitter @JoelKatz
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
Justin Bieber
Newbie
*
Offline Offline

Activity: 14
Merit: 0



View Profile
October 27, 2011, 02:32:19 PM
 #238

I'll try to find time to work on it in the next few days. It's hard to refuse a request from someone with perfect hair.
I'm flattered!

Thanks.
terrytibbs
Hero Member
*****
Offline Offline

Activity: 560
Merit: 501



View Profile
October 27, 2011, 07:05:47 PM
 #239

watching this
JoelKatz
Legendary
*
Offline Offline

Activity: 1596
Merit: 1012


Democracy is vulnerable to a 51% attack.


View Profile WWW
October 28, 2011, 02:56:52 AM
 #240

http://davids.webmaster.com/~davids/bitcoin-4diff-5beta.txt

This is a "first working version". It patches cleanly, compiles, and passes my basic functional tests.

Quite a few of my optimizations were already made. Yay!

I guess I'll have to start working on some new ones.

I am an employee of Ripple. Follow me on Twitter @JoelKatz
1Joe1Katzci1rFcsr9HH7SLuHVnDy2aihZ BM-NBM3FRExVJSJJamV9ccgyWvQfratUHgN
Pages: « 1 2 3 4 5 6 7 8 9 10 11 [12] 13 »  All
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!