This really depends on these 3 things:
1) the amount of BTC you want to store
2) the frequency you want to access your coins
3) the grade of security you want to achieve
If you want to store amounts which are 'big' enough to absorb the purchase of a hardware wallet -> Go for it.
Ledger and
Trezor are the best ones.
Those offer highest grade of security combined with convinience in daily usage.
If you don't want to buy a hardware wallet, but want to have highest possible security -> Go for a cold storage. This means store the private keys / seed only in an air-gapped offline environment.
Spending from such a wallet can be a hassle, but your coins will stay very secured.
If you want to access your coins frequently and don't want to buy a hardware wallet -> Go for a split-option. Create a cold wallet and store a big percentage of your holding there.
Use a light-weight wallet for your every-day spendings. I'd suggest
Electrum in this case.