Bug on the merit system?

[seoincorporation]

So, a couple of days ago i realize there is a bug on the merit engine.

When we are in the merit box ready to spend our merits:

If we click two times the button it will send double merit before the forum send us to 'Merit sent!' page.

And that way some users are getting double merits, sending double merits already happened to me once while i was sending merit to user bomj as you can see on the next image.

And i think i get two merits on a publication for the same bug:

[1715086737]

1715086737

[1715086737]

1715086737

[1715086737]

1715086737

[1715086737]

1715086737

[1715086737]

1715086737

[1715086737]

1715086737

[LoyceV]

This is a known bug/feature, but it doesn't occur very often. In March I made this list:

Occasions where the same user merited the same post twice at the exact same time
26 posts received the same number of Merit from the same user in the same second. This is caused by double clicking the Send button:
Two times 1 Merit from Syndikat to undercomander13 for this post.
Two times 4 Merit from minerbro to Piston_82 for this post.
Two times 1 Merit from newegggo to moonriver for this post.
Two times 4 Merit from aTriz to killyou72 for this post.
Two times 1 Merit from johhnyUA to Gerhald for this post.
Two times 1 Merit from TMAN to Lauda for this post.
Two times 1 Merit from TK14 to John(JohnK.) for this post.
Two times 1 Merit from JCbtc to 1Referee for this post.
Two times 1 Merit from Anna505 to Krjkee for this post.
Two times 1 Merit from Alluro to Smpdytz for this post.
Two times 1 Merit from AlexLvov to svv for this post.
Two times 1 Merit from williamevanl to centralbanksequalsbombs for this post.
Two times 1 Merit from n00bby to Undland for this post.
Two times 1 Merit from soy to Becassine for this post.
Two times 1 Merit from Dvach to AlexZHankok for this post.
Two times 1 Merit from miha74 to klim75 for this post.
Two times 6 Merit from pisston to ckorbba for this post.
Two times 1 Merit from sheamus10 to Asyifiah for this post.
Two times 5 Merit from SmartIphone to vlad230 for this post.
Two times 5 Merit from SmartIphone to hugeblack for this post.
Two times 5 Merit from SmartIphone to 01BTC for this post.
Two times 2 Merit from mellorbo to zzxswqq for this post.
Two times 5 Merit from julian071 to BTCMILLIONAIRE for this post.
Two times 1 Merit from siti25 to vlad230 for this post.
Two times 1 Merit from teddy5145 to marlboroza for this post.
Two times 1 Merit from aTriz to Craige288 for this post.

[DdmrDdmr]

I was taking a look into this too. Since there was a 1 second gap in the @OgNasty -> @seoincorporation example in the OP, grouping by exact time would not catch these cases, so I went on to giving a 2 second margin (searching for all TXs within a 2 second gap with the same implied users and message and date).

I make it 317 TXs historically by the above criteria (see https://docs.google.com/spreadsheets/d/1JmMF_SZX0oWgK8L2BL-lkB0aDMAIW7HB2OWJKXxtrag/edit?usp=sharing), with 155 different real intended TX sends (the others are side effects of double or triple clicking the send button).

No too many cases, and roughly let’s say half of the implied sMerits being non-intentional (602 sMerits -> would mean 301 non-intentional sent sMerits historically).

[Findingnemo]

Already reported by many people,having cool down time between the two merit transaction will help to resolve this issue.Hopefully theymos will identify this bug and sort of the problem.Two AI were fighting so hard to beat satoshi on merit list.

[jackg]

I don't think it was worth making a thread on it, but if you hit the button on public WiFi it can send twice (if there's more than one router and you get switched between the two during that time, I was sat very near one of the routers too so I don't know why I was moved across.


As the others have said, this is a known thing as well as refreshing the merit sent page. It's not a bug, I think it was theymos intention.

[Yeahpro]

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

An issue that should be resolved is the '0' that is by default on the box for selecting number of merits to send.
The number of merits has to be delicately positioned after the 0, or the zero cleared first.
It adds nothing, as it's impossible to send zero merits and there's the chance a user could send 10 merits when trying to send 1. This poses an issue to members with lots of smerits available.

[Obiwankenodium]

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders.

[LoyceV]

A cooldown of 10-30 secons would be enough i guess

The 4 seconds between reporting posts is already annoying and slowing me down!

and it wouldt harm the rapid merit senders.

See:

Code:

October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to audaciousbeing for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to figmentofmyass for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to KonstantinosM for Re: Universal Basic Income Is Silicon Valley’s Latest Scam

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

All it takes is 4 clicks

[jackg]

A cooldown of 10-30 secons would be enough i guess

The 4 seconds between reporting posts is already annoying and slowing me down!

and it wouldt harm the rapid merit senders.

See:

Code:

October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to audaciousbeing for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to figmentofmyass for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to KonstantinosM for Re: Universal Basic Income Is Silicon Valley’s Latest Scam

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

I'm guessing you read a lot of posts and just start opening the merit link in a new tab ready to hammer the 1 and the send button. I think this is just proof that you're a bit though from this point .

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders.

10 seconds would probably harm me sometimes...

[seoincorporation]

A cooldown of 10-30 secons would be enough i guess

The 4 seconds between reporting posts is already annoying and slowing me down!

and it wouldt harm the rapid merit senders.

See:

Code:

October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to audaciousbeing for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to figmentofmyass for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to KonstantinosM for Re: Universal Basic Income Is Silicon Valley’s Latest Scam

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

I'm guessing you read a lot of posts and just start opening the merit link in a new tab ready to hammer the 1 and the send button. I think this is just proof that you're a bit though from this point .

With that hardware, you could run a lot of virtual machines and give one merit from each one at the same time with iMacros.

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders.

10 seconds would probably harm me sometimes...

The server shouldn't let you send merits on the same second, for a reason it doesn't let us make posts on that time rate, and that's the first bug. That bug could be fixed with a cooldown of 1 or 2 seconds. The second bug is on the 'Send' button, it shouldn't be clickable after we already make click. 

[jackg]

The server shouldn't let you send merits on the same second, for a reason it doesn't let us make posts on that time rate, and that's the first bug. That bug could be fixed with a cooldown of 1 or 2 seconds. The second bug is on the 'Send' button, it shouldn't be clickable after we already make click. 

A 1 second delay might be enough but I'm not entirely sure how you'd do it, the current implementation for the 1 second delay would mean you'd still end up refreshing your screen and double spending merit as there is a global one second delay for everything on the forum when a new page loads (other than the merit one clearly)...

[pugman]

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

Its fairly plausible. Its more likely to happen by a person who's bound to use shortcuts and whose hands work faster than the brain.

Also, where the fuck do you live to get 1GBps WiFi? If you don't mind me asking, I'm guessing wales, but i don't want to assume anything.
Will this bug or whatever you wanna call it ever be patched?

[mikeywith]

Also, where the fuck do you live to get 1GBps WiFi? If you don't mind me asking, I'm guessing wales, but i don't want to assume anything.

first thing first, he probably means 1Gbps and that's 125mBps , also i don't think he is referring to the the ISP bandwidth but rather his local network router. which could be the gateway to an old slow dial up connection with only 56 kbit/s.

with that being said, the speed of how fast you can actually post/merit which basically an "update or insert" command into the database of bitcointalk is  irrelevant. even if you were using the fastest internet speed on planet earth you will still be limited by the speed of the database engine as well as the server it runs on.  so the fast merits you done there are nothing but result of your fast "hands" rather than the speed of your internet or computer. 

-------------------------------------------

as for the bug, i noticed that too, i think the easiest solution would be to be to close the page after the button is clicked, since the merit page is useless after having sent the merit as it opens in a new tab.  so that will be more like hitting 2 birds with 1 stone.

[theymos]

Alright, you now can't merit the same post with the same amount within 60 seconds.

[vit05]

Alright, you now can't merit the same post with the same amount within 60 seconds.

I just did.

https://bitcointalk.org/index.php?action=merit;u=194811

I have opened two windows to send merit and when I hit the second one, I merit two times.

[theymos]

I just did.

OK, now it should be impossible no matter how much you try.

[cabalism13]

OK, now it should be impossible no matter how much you try.

[+1]
 
@vit05 you did a great job pal, you certainly got theymos back there hahaha

[Vod]

I just did.

OK, now it should be impossible no matter how much you try.

Ok, I think that was a cheap trick to get extra merits...   

[Vod]

OK, now it should be impossible no matter how much you try.

[+1]
 
@vit05 you did a great job pal, you certainly got theymos back there hahaha

And you sir, got five merits by mistake.  :/

[cabalism13]

And you sir, got five merits by mistake.  :/

I knew it!, well you did it again on me (see Merit History) haha well anyway thanks. And No worries I'm gonna spend this on worthies