Why seeing merit button on my post when I can not merit my own post

[Coyster]

You are correct that it shouldn't be there, but the admin is very reluctant to make changes (even when it is necessary), meaning they would never spend time implementing something that isn't actually a problem.

If a suggestion does not solve a particular problem, i don't think the admin would even think about implementing it, the merit button beside your own posts is not a problem, as long as you can't merit yourself and you get an error when you try it.

[LoyceV]

It's probably for the same reason you still see a Merit button when you've reached your maximum for that user, or when you're out of sMerit: it's not worth the effort to remove all exceptions.

[philipma1957]

When I go through a post of other members, I will see the link to a merit page which can be used to merit the particular post that you have just read. If it is my own post, I can not merit it. Then why should merit link to give merit to a post be seen on my own post when I can not merit myself. I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

It is corrected by the following step a click to merit yourself




do a wrong amount 0 and see what happens




it tells you invalid amount even though you sent it to yourself

do a correct amount say 1


it says "fuck you asshole" you can't merit yourself.  I added that  just to wake us up this morning


I can assure you that if you fix the merit yourself issue the way you do you will likely interfere with the code that says you sent a wrong / invalid amount.

To ask for what you want costs time.

Why not ask power glove  if he could fix it how long and how much code it will take then offer to pay him 100 usd an hour to fix it.


BTW when I see that other things are wrapped into it such as you sent an invalid amount 0 for instance. I know that "you can not send over 50 merits a month to the same person"  is linked into that same line of code.

[EarnOnVictor]

You mean you like to be meriting your own posts...lol Well, I've always seen that merit button on my posts but I believe it's not a big deal, especially if the system can tell you upon trying it that it is not possible to merit your post as the creator.

And if you had practically tried that before, then I must say you are one of the bravest hearts on this forum and curiosity must have pushed you towards that experiment. I've always been tempted to try it, even yesterday before you posted this topic, but I've tried my best to avoid it because if it mistakingly pushed through, I know I will have enough people to explain to on the forum that it was a mistake.

You know how our people behave.

[OgNasty]

When I go through a post of other members, I will see the link to a merit page which can be used to merit the particular post that you have just read. If it is my own post, I can not merit it. Then why should merit link to give merit to a post be seen on my own post when I can not merit myself. I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

It is corrected by the following step a click to merit yourself

That's funny.  I've never tried to merit myself before.  Seeing this, I went a step further and tried to leave myself a feedback rating.  I was also denied.  Damn.  I thought this was my chance to be a true self-scratcher.  It is a bit funny to think there are people out there who probably tried to leave themselves merit or trust ratings only to be denied.  I guess this is why some people spend so much time farming alts and forming trust/merit circles.  Personally, I think it would be funny if people could leave themselves merit, only instead of giving them merit it just destroys it.

[acroman08]

I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

as long as it doesn't allow us to merit ourselves, I don't see any issue with it, besides, its not like it is distracting or disrupt your day to day forum experience. also, I barely even notice it when I am online and as LoyceV mentioned, it's not worth the effort to remove it.

[Mpamaegbu]

OP, your observation is merit worthy. Sad I don't have any to splash on it. I believe that button was an oversight when merit was coded into this forum, and could be too much work to edit out after it was discovered later on. Perhaps, @PowerGlove could come to the rescue now that such is under review.

[PowerGlove]

This one's a bit tricky... I don't have access to theymos' code, so all I can really do is guess at what the code might look like, and then patch the reconstruction.

My guess would be that the code in question is somewhere between one half and two thirds of the way into a function called template_main() inside a file named Display.template.php, and that it looks something like this:

Code:

if(!$context['user']['is_guest'] && !$message['member']['is_guest'])
	echo '
			<a href="', $scripturl, '?action=merit;msg=', $message['id'], '" target="_blank"><span style="vertical-align: middle;"><b>+Merit</b></span></a>';

Using that guess as a baseline, the patch would consist of extending that if-condition with && $message['member']['id'] != $context['user']['id'], like so:

Code:

if(!$context['user']['is_guest'] && !$message['member']['is_guest'] && $message['member']['id'] != $context['user']['id'])
	echo '
			<a href="', $scripturl, '?action=merit;msg=', $message['id'], '" target="_blank"><span style="vertical-align: middle;"><b>+Merit</b></span></a>';

(For everyone's info: I don't receive notifications when I'm mentioned. I'm working on adding a simple mention system to SMF, but, until then, there's no guarantee that I'll bump into every @PowerGlove. If you suspect I've slept on some important forum-improvement topic, feel free to shoot me a PM.)

I only checked this afterwards, so I'll leave my original guesswork as-is, but, I see that the "+Merit" link does appear on guest posts, so whatever the actual if-condition is, it's missing the && !$message['member']['is_guest'] that I included in the guessed-at code. (I would add it, though: guest-meriting is similar to self-meriting; may as well just not emit links that can only error-out if you visit them.)

[Majestic-milf]

 I also wondered the need for this merit button that can be seen but can't be used on one's self but then I realized that some of these things where probably left there by Theymos when this forum was being created to add some sort of uniqueness or something, or it was a feature that was added on later , I dunno but like the others have said it's not something to break one's head over, i feel it's best to ignore.
 There are some features in this forum that are just there for formality purpose and do not carry much weight or affect anything like this :"we reserve the right to decay unused smerits" because up till date I've not really seen any merits get decayed.

[philipma1957]

A lot has to do with ease of coding. Back in 1979-1980 while in the US Navy we had a ton of software go bad.  Why it used the 7 from the decade to count time so when we went to the 8 as in 1980 the software erred out. I suspect many fear this was going to be big in 1999-2000 because they had seen 1979-1980 errors and 1989-1990 errors.

[AVE5]

When I go through a post of other members, I will see the link to a merit page which can be used to merit the particular post that you have just read. If it is my own post, I can not merit it. Then why should merit link to give merit to a post be seen on my own post when I can not merit myself. I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

You got me thinking and so as much you've made a very good point there. Apparently if we can't merit ourselves then the feature where we can observe the sMerits on our own posts seems not useful but let's just take it likely to say that the +Merit is a just a function by which we can access our sMerits status. That's to say we can always find that feature in self and others posts.

[The Cryptovator]

This isn't a serious issue that needs to be fixed. Eventually, you can't merit yourself. So nothing is wrong. If you can merit yourself, then it would be a matter of concern.

It just need to write couple of line on the code but waste of time actually.

This isn't a hassle for you also since you know it doesn't work meriting yourself.