[PATCH REQUEST] Variable ports (205BTC reward)

[mizerydearia]

no reason to change that, as other clients only try to connect to 8333, afaict. IRC only advertises IP, right?

No, both IP and port are encoded in the #bitcoin IRC usernames (see the EncodeAddress/DecodeAddress routines in irc.cpp).

(so mizerydearia:  no need to do what you done did...)

Mm...  On a slightly unrelated issue.  Since it is possible to detect majority of all nodes in the p2p network by visiting the bootstrapping irc channel, it seems fairly easy to determine where exactly all the nodes are in case any attempt to disconnect Internet or seize hardwares ever occurs.  Perhaps another thread should be used to discuss this.

[1713927869]

1713927869

[1713927869]

1713927869

[1713927869]

1713927869

[1713927869]

1713927869

[jgarzik]

Patch updated for latest SVN.

[mizerydearia]

original post edited to include link to patch.

[mizerydearia]

This patch doesn't work anymore.  Is this still necessary or has it made it into official svn?

[wumpus]

This patch doesn't work anymore.  Is this still necessary or has it made it into official svn?

Nope, it's not in official SVN yet.

On a related note: from discussion on IRC I understood that the peer exchange protocol somehow doesn't have support for alternative ports. Does this patch work as advertised at all?

[theymos]

On a related note: from discussion on IRC I understood that the peer exchange protocol somehow doesn't have support for alternative ports. Does this patch work as advertised at all?

The protocol supports alternative ports just fine, though you won't receive incoming connections because Bitcoin prefers not to connect to peers that are using non-standard ports.

[dsg]

On a related note: from discussion on IRC I understood that the peer exchange protocol somehow doesn't have support for alternative ports. Does this patch work as advertised at all?

The protocol supports alternative ports just fine, though you won't receive incoming connections because Bitcoin prefers not to connect to peers that are using non-standard ports.

Interesting, is this by design or a bug?

I think it will be imperative for bitcoin to randomise port and use encryption, in order to avoid being blocked by firewalls or DPI boxes. Hopefully this will be implemented before it's needed.

[theymos]

Interesting, is this by design or a bug?

It's by design. Here is Bitcoin choosing which peers to connect to:

Code:

// Randomize the order in a deterministic way, putting the standard port first
int64 nRandomizer = (uint64)(nStart * 4951 + addr.nLastTry * 9567851 + addr.ip * 7789) % (2 * 60 * 60);
if (addr.port != GetDefaultPort())
    nRandomizer += 2 * 60 * 60;