Some suggestions for DarkSilk (I reviewed
https://github.com/SCDeveloper/DarkSilk-Release-Candidate):
....
I am
I am bringing the codebase up to 12.1
Currently I am between 11.2 and 12.1 of Dash.
There are still a lot of differences such as CCoins too
DarkSilk will launch with these changes you mention in place
Did I review the wrong code or do you have another repo?
I'm glad you included theses and other fixes. I only named a few. I know you have been working really hard on DarkSilk.
Are you including Sling's market in the first version or did you remove it?
i was wondering the same. have i wrong git?
that may be i had.
if so the core is ok? but not out yet?
How many times.....
DarkSilk is not released.
ok. but dont ignore these olds bugs. cryptovote already gave you some small part of those. he knows what we are talking about.
problem is not the mastenode code, but the main code..
all because of some guy messed up sourcecode out there really bad time with the earlier masternode shit coins.
who was it? icm? name if you can.
I know about the mess of Crave. It doesn't work, simple.
I have been working on DarkSilk since April and CryptoVote was using MY commits and is now helping with DarkSilk which is nice of him.
If anyone is aware of the mess of Crave and other similar codebases, it's me
Check this repo -
https://github.com/SCDeveloper/Crave-Darksilk-Comparison (I made this 16 days ago and have done thousands of line changes since but this will give you an idea of the amount of work done)
There is not just the difference between CTransaction and CMutable, there are all the node elements, block scanning, Stealth address and messaging issues. Darksend simply doesn't work in Crave and basically the Dash code in Crave is just for show.
A simple example and proof of this is the fact that the mixer is disabled in the Crave source to not display on the overview page, ask yourself why.
I am of course referencing the original Crave release not any work done thereafter.
looks way better.. (git i looked earlier was last commit 3 months ago)
even the support for /* miniupnpc 1.9.20150730 */ added
"ibm" guys are waiting your work for crave?
"Darksend simply doesn't work in Crave and basically the Dash code in Crave is just for show.
A simple example and proof of this is the fact that the mixer is disabled in the Crave source to not display on the overview page, ask yourself why."
-yep, i found that months ago when fighting with similar code.
this BIG work you have done would help much with my hobby coin, but for personal reasons i am unable to continue..
Show Posts
