Bitcoin Forum
May 03, 2024, 10:08:02 PM *
News: Latest Bitcoin Core release: 27.0 [Torrent]
 
   Home   Help Search Login Register More  

Warning: Moderators do not remove likely scams. You must use your own brain: caveat emptor. Watch out for Ponzi schemes. Do not invest more than you can afford to lose.

Pages: « 1 2 3 4 5 6 7 8 [9] 10 11 12 13 14 15 16 17 18 19 20 »  All
  Print  
Author Topic: [BTC-TC] TAT.ASICMINER New Micro-share Passthrough!  (Read 37651 times)
ThatDGuy
Hero Member
*****
Offline Offline

Activity: 728
Merit: 500



View Profile
May 30, 2013, 02:24:04 PM
 #161

I had a whole reply put together on my laptop and the battery died, so I'm stuck retyping this on my phone.  Sad

Here's what happened:

Div 1: scheduled
Div 1: started processing a minute later
Div 1: cancelled (~10 mins after it started processing)
Div 2: scheduled
Div 1: completed
Div 2: completed

The cancel failed because the div was already being processed.  I have fixed the system so you can now see when a div is in progress and it will not cancel.

I have reimbursed TAT for the double div and I have initiated a recovery process whereby anyone that received a double dividend will see a balance reduction of whichever was the lesser of the two dividends.  This way no one gets burned if they traded between when the first div processed and when the second div processed.

The site's going to lose ~1 BTC on this bug, but hopefully this resolution is as fair as possible to everyone involved.

Cheers

Thanks very much for the information and fix! Keep up the great work!
1714774082
Hero Member
*
Offline Offline

Posts: 1714774082

View Profile Personal Message (Offline)

Ignore
1714774082
Reply with quote  #2

1714774082
Report to moderator
1714774082
Hero Member
*
Offline Offline

Posts: 1714774082

View Profile Personal Message (Offline)

Ignore
1714774082
Reply with quote  #2

1714774082
Report to moderator
1714774082
Hero Member
*
Offline Offline

Posts: 1714774082

View Profile Personal Message (Offline)

Ignore
1714774082
Reply with quote  #2

1714774082
Report to moderator
Transactions must be included in a block to be properly completed. When you send a transaction, it is broadcast to miners. Miners can then optionally include it in their next blocks. Miners will be more inclined to include your transaction if it has a higher transaction fee.
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
voluntaryist
Newbie
*
Offline Offline

Activity: 21
Merit: 0


View Profile
May 30, 2013, 02:46:22 PM
 #162

What happens if the double payment recovery makes one's balance go negative?

I didn't realize a bug had happened at first and reinvested in TAT shares (the overpayment amount to a little over a dollar, so I'm not worried about paying it back- I just don't want my account closed or something).
mem
Hero Member
*****
Offline Offline

Activity: 644
Merit: 501


Herp Derp PTY LTD


View Profile
May 30, 2013, 03:16:25 PM
 #163

I had a whole reply put together on my laptop and the battery died, so I'm stuck retyping this on my phone.  Sad

Here's what happened:

Div 1: scheduled
Div 1: started processing a minute later
Div 1: cancelled (~10 mins after it started processing)
Div 2: scheduled
Div 1: completed
Div 2: completed

The cancel failed because the div was already being processed.  I have fixed the system so you can now see when a div is in progress and it will not cancel.

I have reimbursed TAT for the double div and I have initiated a recovery process whereby anyone that received a double dividend will see a balance reduction of whichever was the lesser of the two dividends.  This way no one gets burned if they traded between when the first div processed and when the second div processed.

The site's going to lose ~1 BTC on this bug, but hopefully this resolution is as fair as possible to everyone involved.

Cheers

Im happy with that , fair is fair.

ZephramC
Sr. Member
****
Offline Offline

Activity: 475
Merit: 254



View Profile
May 30, 2013, 04:15:48 PM
 #164

...
I have initiated a recovery process whereby anyone that received a double dividend will see a balance reduction of whichever was the lesser of the two dividends. 
...

Personally, I have no problem with that.
I would also expect that your "lesser dividend selection algorithm" will not fail if both dividends are exactly the same to the single Satoshi. :-]. This is my case.
bitzox
Full Member
***
Offline Offline

Activity: 172
Merit: 100



View Profile
May 30, 2013, 04:39:29 PM
 #165

Kudos on a quick and professional solution to the problem.

18QpV8ZF3Y4oK8guDQiwTAK73W9r5nvBtm
matt4054
Legendary
*
Offline Offline

Activity: 1946
Merit: 1035



View Profile
May 30, 2013, 05:04:08 PM
 #166

Thanks for resolving this smoothly, just one more thing:

Furthermore, the duplicate dividend should have to be removed from the history too, otherwise it would screw up the statistics (both the asset statistics and the personal ones).

+1 to this, isn't there any way to remove it? Because AFAIK, if I do the math right now (i.e. try to hold a correct accounting / settlement using API), I will have a mismatch because of the 'shadow' transaction, or am I wrong about this?
burnside
Legendary
*
Offline Offline

Activity: 1106
Merit: 1004


Lead Blockchain Developer


View Profile WWW
May 30, 2013, 05:13:47 PM
 #167

Lots of good questions.

- Unfortunately in the interest of expediency I did not script this fix via site code.  I did it using a shell script making bitcoind requests.  This means there is not (yet) a database record of what was recovered, it's all in bitcoind transactions.
- The script was setup to not send accounts negative.  If an account didn't have the funds, we just moved on to the next account.  There were a few of these, I suspect mostly due to the dividend reinvestment feature spending it.  Smiley
- The account balance differences show up somewhat delayed because the site caches your balance until you do an operation like a withdrawal or trade.
- The selection for how much to pull out was done manually by taking the logs of each dividend process and doing a merge.  Thus situations where the share counts lined up were no problem, and I pulled out all the dupes by hand where the payout was higher.  This left all of the payouts that were the same or lower for my script to process.

Hope that all makes sense.  I still need to write a second script to send everyone an email and remove the database entries for the extra deposits.  I'll try to get that going today.

Cheers
Streets 2.0
Full Member
***
Offline Offline

Activity: 490
Merit: 101


FRX: Ferocious Alpha


View Profile
May 30, 2013, 05:42:15 PM
 #168

FYI Burnside, my second div payment is still there and is also equal to the first payment in amount.

nycgoat
Member
**
Offline Offline

Activity: 117
Merit: 10


View Profile
May 30, 2013, 05:50:21 PM
 #169

Great to see that you guys are resolving this professionally and promptly.  This small bump (in the whole scheme of things), isn't any worse than the flash crashes that happen in individual stocks all the time.  (yes, totally different, I am just speaking in terms of severity). 
bitzox
Full Member
***
Offline Offline

Activity: 172
Merit: 100



View Profile
May 30, 2013, 06:55:38 PM
 #170

Great to see that you guys are resolving this professionally and promptly.  This small bump (in the whole scheme of things), isn't any worse than the flash crashes that happen in individual stocks all the time.  (yes, totally different, I am just speaking in terms of severity). 

or the complete botching of the Facebook IPO, or the whole "oh no some HFT asshat caused a flash crash! lets reverse the trades so they don't lose any money because it wouldn't be fare to make them pay for being asshats who try to time the market and skip the queue when making trades", or any number of SEC sanctioned screwups that are always 100% designed to protect institutional interests and screw retail.

/rant

18QpV8ZF3Y4oK8guDQiwTAK73W9r5nvBtm
jdany
Hero Member
*****
Offline Offline

Activity: 644
Merit: 500


Inspired


View Profile
May 30, 2013, 07:44:12 PM
 #171

This whole thing reminds me of Animal Farm
daemondazz
Sr. Member
****
Offline Offline

Activity: 448
Merit: 250



View Profile
May 30, 2013, 11:22:23 PM
 #172

Hi Burnside,

Quick question if I may on the automatic re-investment option - does that only work for the same stock, or will it re-invest all dividends into what's set up? Eg, will it re-invest dividends from ASICMINER-PT into TAT.ASICMINER?

Thanks

Computers, Amateur Radio, Electronics, Aviation - 1dazzrAbMqNu6cUwh2dtYckNygG7jKs8S
murfshake
Member
**
Offline Offline

Activity: 84
Merit: 10


View Profile
May 30, 2013, 11:41:01 PM
 #173

Thank's for fixing this.  Kind of shows that mistakes happen but it appears you handled this very professionally, Burnside. 

I am happy with the way BTC-TC is setup and running as an end user.
burnside
Legendary
*
Offline Offline

Activity: 1106
Merit: 1004


Lead Blockchain Developer


View Profile WWW
May 31, 2013, 12:39:25 AM
 #174

Hi Burnside,

Quick question if I may on the automatic re-investment option - does that only work for the same stock, or will it re-invest all dividends into what's set up? Eg, will it re-invest dividends from ASICMINER-PT into TAT.ASICMINER?

Thanks

It works only for the stocks you have it turned on for and works by adding up how much you get in divs on that single stock over time until enough has come in to be able to afford more of that particular stock.  Important note here, it does not reserve the funds, so it's on you to leave the div funds in place while it adds up. 

It would be interesting to try to do something that pooled all the stocks you selected, but it would be very tricky since there's a wide array of prices and the exchange does not do fractional shares.
daemondazz
Sr. Member
****
Offline Offline

Activity: 448
Merit: 250



View Profile
May 31, 2013, 12:40:13 AM
 #175

No worries, thanks:)

Computers, Amateur Radio, Electronics, Aviation - 1dazzrAbMqNu6cUwh2dtYckNygG7jKs8S
Naelr
Full Member
***
Offline Offline

Activity: 231
Merit: 100


View Profile WWW
May 31, 2013, 04:23:38 AM
 #176

FYI Burnside, my second div payment is still there and is also equal to the first payment in amount.

As it would appear is mine!

Join me in hosted mining.  And always use 2 Factor Auth whenever possible.
CEX.IO hosting mining
MikkisJ
Member
**
Offline Offline

Activity: 126
Merit: 11


View Profile
June 01, 2013, 08:23:54 PM
 #177

Now the second dividend pay is gone, but the balance of the wallet still has the bitcoins.
matt4054
Legendary
*
Offline Offline

Activity: 1946
Merit: 1035



View Profile
June 01, 2013, 10:54:01 PM
 #178

Now the second dividend pay is gone, but the balance of the wallet still has the bitcoins.

2nd dividend gone in my history, but the balance is correct, the amount in excess had already been taken off our balances by burnside before the correction. So everything is fine on my side. Maybe your balance still has the money because you had reinvested the double dividend, or withdrawn the money before burnside had corrected the problem manually?
burnside
Legendary
*
Offline Offline

Activity: 1106
Merit: 1004


Lead Blockchain Developer


View Profile WWW
June 02, 2013, 12:08:42 AM
 #179

Now the second dividend pay is gone, but the balance of the wallet still has the bitcoins.

2nd dividend gone in my history, but the balance is correct, the amount in excess had already been taken off our balances by burnside before the correction. So everything is fine on my side. Maybe your balance still has the money because you had reinvested the double dividend, or withdrawn the money before burnside had corrected the problem manually?

There were some that weren't collectible for various reasons.  I'm not going to keep trying to collect.  If your balance is higher than you expected, it's your lucky day.  Wink

Cheers.
kuriboh
Sr. Member
****
Offline Offline

Activity: 358
Merit: 285


View Profile
June 02, 2013, 12:27:36 AM
Last edit: June 02, 2013, 06:40:06 AM by kuriboh
 #180

Buying some of this (when my wallet finish the update xD)

EDIT: Finally I buy some xD
Pages: « 1 2 3 4 5 6 7 8 [9] 10 11 12 13 14 15 16 17 18 19 20 »  All
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!