Peg
Newbie
Offline
Activity: 41
Merit: 0
|
|
May 12, 2018, 01:47:05 AM Last edit: May 12, 2018, 01:59:25 AM by Peg |
|
You can either Sweep (which will create an onchain transaction that sends the BCH from the old "btc" addresses to new BCH addresses in your BCH wallet)... or you can Import the keys into a BCH wallet (use the "Import Bitcoin addresses or private keys" option when creating the wallet in ElectronCash).
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
Yes, I want to dump the BCH,. Do I import private keys (Plain Base 58 format) from here https://i.imgur.com/zm0Gynz.jpgand then send to an Exchange?
|
|
|
|
HCP
Legendary
Offline
Activity: 2086
Merit: 4318
<insert witty quote here>
|
|
May 12, 2018, 02:02:32 AM Last edit: November 15, 2023, 08:01:20 AM by HCP |
|
can't you just import your keys into an offline ElectronCash wallet as a cold wallet option for hodling?
If you think you have no malware or keyloggers and that there is no way for your keys to have been harvested... then yes, you could simply import them into an offline wallet to HODL. An even better option would be to simply do nothing at all. You don't need to "claim" BCH, there is no deadline. The coins already exist on the BCH blockchain and can only be moved with your private keys. Barring a total collapse of BCH, in which case it doesn't matter where or what you did with the coins, "your" BCH are safely linked to your BTC keys and can stay that way until you wish to sell/exchange them etc. If you just want to be able to "see" your BCH to make yourself feel rich, just create a BCH watching-only wallet using your BTC addresses Yes, I want to dump the BCH,. Do I import Plain Base 58 format from here
and then send to an Exchange?
No... you have selected the wrong option in the "Install Wizard"... as I said, you need to select "Import Bitcoin Addresses or Private keys"... DO NOT select "Standard Wallet" Select that option, copy/paste the "PlainBase58" private keys when prompted (1 per line): Following that, ElectronCash will create the wallet, you'll see your BCH balance... you can then send to an Exchange.
|
|
|
|
btcpop.co
Jr. Member
Offline
Activity: 33
Merit: 1
|
|
May 12, 2018, 03:18:05 PM |
|
I managed to get armory connected to the newest bitcoinABC version. You need to remove 2 checks from the the net_processing.cpp: //Scan for message start if (memcmp(std::begin(msg.hdr.pchMessageStart), std::begin(chainparams.NetMagic()), CMessageHeader::MESSAGE_START_SIZE) != 0) { LogPrintf("PROCESSMESSAGE: INVALID MESSAGESTART %s peer=%d\n", SanitizeString(msg.hdr.GetCommand()), pfrom->id);
Make sure we ban where that come from for some time. connman.Ban(pfrom->addr, BanReasonNodeMisbehaving);
pfrom->fDisconnect = true; return false; }
if (!hdr.IsValid(config)) { LogPrintf("PROCESSMESSAGE: ERRORS IN HEADER %s peer=%d\n", SanitizeString(hdr.GetCommand()), pfrom->id); return fMoreWork; }
Note that Bitcoin nodes will also connect to your node then. Extra if statements that skip those checks only for armory would make more sense or add the net magic to armory on connection. ( {0xe3, 0xe1, 0xf3, 0xe8} )
|
|
|
|
goatpig (OP)
Moderator
Legendary
Offline
Activity: 3724
Merit: 1360
Armory Developer
|
|
May 13, 2018, 11:02:45 AM |
|
The only thing you're doing here is uncommenting an actual comment. This won't build no matter what you try. What I am guessing you're trying to do is to comment out the entire if branch. I would advise users not to do that, as their ABC node would be trying to process messages from actual Bitcoin nodes, which overwhelm BCH. Basically the equivalent of DDoSing yourself. Instead, you can try to change the P2P magic word in Armory (there's no guarantee that change alone will be enough): https://github.com/goatpig/BitcoinArmory/blob/master/cppForSwig/BlockUtils.cpp#L886 networkNode_ = make_shared<BitcoinP2P>("127.0.0.1", config_.btcPort_, *(uint32_t*)config_.magicBytes_.getPtr());
Should be changed to: networkNode_ = make_shared<BitcoinP2P>("127.0.0.1", config_.btcPort_, 0xe3e1f3e8);
|
|
|
|
btcpop.co
Jr. Member
Offline
Activity: 33
Merit: 1
|
|
May 13, 2018, 12:42:46 PM Last edit: May 13, 2018, 12:55:36 PM by btcpop.co |
|
Yes, I commented that out ( Doesn't do much more than versions before as those hadn't those checks ). And yes I wrote its not the best solution for the issue. I'll try to edit the armory code and see if that will work as well.
Edit, that change alone isn't enough, armory won't connect to bitcoinABC. I keep my dirty fix for now till i've more time to get deeper into the armory code.
|
|
|
|
goatpig (OP)
Moderator
Legendary
Offline
Activity: 3724
Merit: 1360
Armory Developer
|
|
May 13, 2018, 03:24:16 PM |
|
Edit, that change alone isn't enough, armory won't connect to bitcoinABC.
Check your node log, should tell you why Armory is getting rejected.
|
|
|
|
Peg
Newbie
Offline
Activity: 41
Merit: 0
|
|
May 14, 2018, 08:22:48 AM |
|
can't you just import your keys into an offline ElectronCash wallet as a cold wallet option for hodling?
If you think you have no malware or keyloggers and that there is no way for your keys to have been harvested... then yes, you could simply import them into an offline wallet to HODL. An even better option would be to simply do nothing at all. You don't need to "claim" BCH, there is no deadline. The coins already exist on the BCH blockchain and can only be moved with your private keys. Barring a total collapse of BCH, in which case it doesn't matter where or what you did with the coins, "your" BCH are safely linked to your BTC keys and can stay that way until you wish to sell/exchange them etc. If you just want to be able to "see" your BCH to make yourself feel rich, just create a BCH watching-only wallet using your BTC addresses Yes, I want to dump the BCH,. Do I import Plain Base 58 format from here
and then send to an Exchange?
No... you have selected the wrong option in the "Install Wizard"... as I said, you need to select "Import Bitcoin Addresses or Private keys"... DO NOT select "Standard Wallet" https://i.imgur.com/CJjD7pb.pngSelect that option, copy/paste the "PlainBase58" private keys when prompted (1 per line): https://i.imgur.com/oswxW2G.pngFollowing that, ElectronCash will create the wallet, you'll see your BCH balance... you can then send to an Exchange. Thank you HCP. I imported Bitcoin Addresses to get all my bch in ElectronCash . Can I send eg. 0.01 bch to exchange for testing, once no any problem then send out all of them? I greatly appreciate your valuable advice!!
|
|
|
|
HCP
Legendary
Offline
Activity: 2086
Merit: 4318
<insert witty quote here>
|
|
May 14, 2018, 08:25:17 AM |
|
Can I send eg. 0.01 bch to exchange for testing, once no any problem then send out all of them?
Sure... why not? Just be careful that you don't send less than any minimum deposit amount specified by the exchange you send to, as some exchanges/sites will just "eat" deposits under a minimum size (no refund etc). Also, fees in BCH are really low due to large empty blocks, so you can generally send with minimum fee.
|
|
|
|
alomar
Member
Offline
Activity: 178
Merit: 10
|
|
May 15, 2018, 10:13:33 AM Last edit: May 15, 2018, 10:35:40 AM by alomar |
|
Also, fees in BCH are really low due to large empty blocks, so you can generally send with minimum fee. Let's try to distinguish between large block "limits" vs the reality of small economically determined block "sizes" of ~80kB today in BCH, please
|
|
|
|
btcpop.co
Jr. Member
Offline
Activity: 33
Merit: 1
|
|
May 15, 2018, 11:28:32 AM |
|
Also, fees in BCH are really low due to large empty blocks, so you can generally send with minimum fee. Let's try to distinguish between large block "limits" vs the reality of small economically determined block "sizes" of ~80kB today in BCH, please Those "arguments" could've been used for Bitcoin as well some years back and was used "No one is using it I stay with "real" money"... Could keep it non political in a technical thread as well.
|
|
|
|
justanickname
|
|
May 23, 2018, 04:03:55 AM |
|
So if I understand correctly, starting may 15th, you can't use armory on the BCH chain anymore?
|
|
|
|
goatpig (OP)
Moderator
Legendary
Offline
Activity: 3724
Merit: 1360
Armory Developer
|
|
May 23, 2018, 11:49:53 AM |
|
So if I understand correctly, starting may 15th, you can't use armory on the BCH chain anymore?
Entirely depends on the span of the new HF. If it's just a block size increase and new opcodes, Armory should still "work" provided the network magic word part is fixed. Honestly, it would probably take me a single day to deal with this stuff assuming all they did was to increase the block size. I don't do it because I refuse to give up development time for BCH.
|
|
|
|
justanickname
|
|
May 23, 2018, 03:48:20 PM |
|
So if I understand correctly, starting may 15th, you can't use armory on the BCH chain anymore?
Entirely depends on the span of the new HF. If it's just a block size increase and new opcodes, Armory should still "work" provided the network magic word part is fixed. Honestly, it would probably take me a single day to deal with this stuff assuming all they did was to increase the block size. I don't do it because I refuse to give up development time for BCH. Got it, thank you for your hard work!
|
|
|
|
btcpop.co
Jr. Member
Offline
Activity: 33
Merit: 1
|
|
May 28, 2018, 01:01:21 AM |
|
So if I understand correctly, starting may 15th, you can't use armory on the BCH chain anymore?
Entirely depends on the span of the new HF. If it's just a block size increase and new opcodes, Armory should still "work" provided the network magic word part is fixed. Honestly, it would probably take me a single day to deal with this stuff assuming all they did was to increase the block size. I don't do it because I refuse to give up development time for BCH. Got it, thank you for your hard work! It works if you just remove some checks for the network magic, those was only added in the last update, peers for other chains will still be banned so it could only lead initial to some more wrong connections from and to your node. See: https://bitcointalk.org/index.php?topic=2070058.msg37065819#msg37065819For now I think its the best solution, its not the optimal solution but that way you could still use armory and also update armory without needing to edit or add own code. You just need to make sure you remove the checks also in future updates on Bitcoin Cash. ( I assume the checks wont be updated much so should be easy to find and remove it in future versions as well ).
|
|
|
|
justanickname
|
|
May 28, 2018, 06:04:40 PM |
|
So if I understand correctly, starting may 15th, you can't use armory on the BCH chain anymore?
Entirely depends on the span of the new HF. If it's just a block size increase and new opcodes, Armory should still "work" provided the network magic word part is fixed. Honestly, it would probably take me a single day to deal with this stuff assuming all they did was to increase the block size. I don't do it because I refuse to give up development time for BCH. Got it, thank you for your hard work! It works if you just remove some checks for the network magic, those was only added in the last update, peers for other chains will still be banned so it could only lead initial to some more wrong connections from and to your node. See: https://bitcointalk.org/index.php?topic=2070058.msg37065819#msg37065819For now I think its the best solution, its not the optimal solution but that way you could still use armory and also update armory without needing to edit or add own code. You just need to make sure you remove the checks also in future updates on Bitcoin Cash. ( I assume the checks wont be updated much so should be easy to find and remove it in future versions as well ). Thanks, the problem is, as stupid as it may sound, that I don't really know how to download the code and build it with the changes, it will probably take me 2-3 days to do just that. I would have done that don't get me wrong but I think that this is a bad practice. goatpig don't want to support BCH which is his right and I respect it. So now for each new version of both armory and BCH you will have to find more and more workarounds to make it work which is really a bad practice. Armory is for BTC. I think it is best to just find another wallet for BCH. Any Ideas?
|
|
|
|
HCP
Legendary
Offline
Activity: 2086
Merit: 4318
<insert witty quote here>
|
|
May 29, 2018, 07:10:13 AM |
|
I think it is best to just find another wallet for BCH. Any Ideas?
If you mean for getting a BCH wallet... then your choices are pretty much: Full Node: Bitcoin ABC - Just be SUPER careful when installing and running it to make sure it doesn't overwrite all your Bitcoin Core install and data directory. SPV: ElectronCash I believe that it really comes down to want you want to access the BCH wallet for... HODLing or dumping? If you just want to get BCH to dump it, I'd recommend that you get ElectronCash, export your private keys from Armory, import them into ElectronCash and then you can send them to whatever exchange you want very easily. If you want to hold, then, in the long term, it might be worth the effort to get BitcoinABC up and running and then sweep the private keys into your BitcoinABC wallet. ElectronCash could also be used longterm, but in that instance, you'd probably want to create a "seeded" wallet and then sweep your Armory private keys rather than importing them. (NOTE: regardless of whether you want to import or sweep the keys, you should makes sure that you've moved all your BTC into a new Armory wallet prior to exporting the keys)
|
|
|
|
alomar
Member
Offline
Activity: 178
Merit: 10
|
|
May 29, 2018, 05:10:28 PM |
|
I think it is best to just find another wallet for BCH. Any Ideas?
If you mean for getting a BCH wallet... then your choices are pretty much: Full Node: Bitcoin ABC - Just be SUPER careful when installing and running it to make sure it doesn't overwrite all your Bitcoin Core install and data directory. SPV: ElectronCash I believe that it really comes down to want you want to access the BCH wallet for... HODLing or dumping? If you just want to get BCH to dump it, I'd recommend that you get ElectronCash, export your private keys from Armory, import them into ElectronCash and then you can send them to whatever exchange you want very easily. If you want to hold, then, in the long term, it might be worth the effort to get BitcoinABC up and running and then sweep the private keys into your BitcoinABC wallet. ElectronCash could also be used longterm, but in that instance, you'd probably want to create a "seeded" wallet and then sweep your Armory private keys rather than importing them. (NOTE: regardless of whether you want to import or sweep the keys, you should makes sure that you've moved all your BTC into a new Armory wallet prior to exporting the keys) Trezor is a good choice also.
|
|
|
|
justmyname
|
|
May 29, 2018, 08:42:08 PM |
|
Trezor can hold BCH, BTC and BTG. It's a good idea to put an extra pass phrase on each Trezor account before sending coins to Trezor. That way even if someone gets your seed words list or device they still can't get the coins. You also want to make sure it hasn't been tampered with. Generate you're own seed words and number phrase.
I bought mine off Amazon but it may be better to buy direct from Manufacture. If the device comes with a seed word and number pass phrase the device has been tampered with you need to wipe it clean and generate a new seed word- pass phrase.
|
|
|
|
Carlton Banks
Legendary
Offline
Activity: 3430
Merit: 3080
|
|
May 30, 2018, 10:35:13 PM |
|
Trezor can hold BCH, BTC and BTG. It's a good idea to put an extra pass phrase on each Trezor account before sending coins to Trezor. That way even if someone gets your seed words list or device they still can't get the coins. You also want to make sure it hasn't been tampered with. Generate you're own seed words and number phrase.
Apparently, that's a bad idea. There's a way of figuring out that passphrases exist for a given Trezor seed, whereas if you don't use a passphrase, then it can be proved that you don't have any passphrased accounts pertaining to the same seed mnemonic.
|
Vires in numeris
|
|
|
justanickname
|
|
May 31, 2018, 08:35:47 PM |
|
Great, thank you all.
Assuming i didn't touch my BCH since it was created.
If I just want to send a BCH offline transaction (let's say to my new wallet), Can I broadcast it with an offline node?
|
|
|
|
|