HBCCACTIVATE (OP)
Newbie
Offline
Activity: 12
Merit: 0
|
|
October 25, 2017, 09:01:32 AM Last edit: October 25, 2017, 10:07:53 PM by HBCCACTIVATE |
|
|
|
|
|
keksov
Newbie
Offline
Activity: 13
Merit: 0
|
|
October 25, 2017, 10:02:36 AM |
|
a modified version of xmr-stak source please! It's GNU licencesed...
|
|
|
|
HBCCACTIVATE (OP)
Newbie
Offline
Activity: 12
Merit: 0
|
|
October 25, 2017, 10:34:10 AM |
|
a modified version of xmr-stak source please! It's GNU licencesed...
Thank you for the hint. I added a link to the source code.
|
|
|
|
l1xx
Member
Offline
Activity: 115
Merit: 10
|
|
October 25, 2017, 11:17:48 AM |
|
Anyone brave enough to try this?
|
|
|
|
keksov
Newbie
Offline
Activity: 13
Merit: 0
|
|
October 25, 2017, 11:26:51 AM |
|
Please commit all of your changes. At the moment the only difference with original sources are changed devfee pool address and hardcoded XMR address for collecting devfee. Pretty harmful, but useless. full diff https://github.com/HBCC/xmr-stak-amd/commit/675cafb28251b1ec513d6899475eb7500a5c01c0Original executor.h https:// github.com/fireice-uk/xmr-stak-amd/blob/master/executor.h Original executor.cpp https:// github.com/fireice-uk/xmr-stak-amd/blob/master/executor.cpp const char* dev_pool_addr = jconf::inst()->GetTlsSetting() ? "donate.xmr-stak.net:6666" : "donate.xmr-stak.net:3333"; if(!pool->cmd_login("", "")) Modified executor.h https:// github.com/HBCC/xmr-stak-amd/blob/master/executor.h const char* dev_pool_addr = jconf::inst()->GetTlsSetting() ? "xmr-eu1.nanopool.org:14444" : "xmr-eu2.nanopool.org:14444"; if(!pool->cmd_login("42mgJMe9RAgRNWkxvvPAxjCFcekKja3DqWCgfhN8ghaZKNezbNH1ww9fiJWmRLV51Z1jTs4sxrfyEd3rAVK1pvKcCfHKGUM", "x")) Compare original executor.cpp and modified executor.h At the moment it looks very suspicious. Provide us please with more info.
|
|
|
|
l1xx
Member
Offline
Activity: 115
Merit: 10
|
|
October 25, 2017, 11:37:27 AM |
|
Please commit all of your changes. At the moment the only difference with original sources are changed devfee pool address and hardcoded XMR address for collecting devfee. Pretty harmful, but useless. full diff https://github.com/HBCC/xmr-stak-amd/commit/675cafb28251b1ec513d6899475eb7500a5c01c0Original executor.h https:// github.com/fireice-uk/xmr-stak-amd/blob/master/executor.h Original executor.cpp https:// github.com/fireice-uk/xmr-stak-amd/blob/master/executor.cpp const char* dev_pool_addr = jconf::inst()->GetTlsSetting() ? "donate.xmr-stak.net:6666" : "donate.xmr-stak.net:3333"; if(!pool->cmd_login("", "")) Modified executor.h https:// github.com/HBCC/xmr-stak-amd/blob/master/executor.h const char* dev_pool_addr = jconf::inst()->GetTlsSetting() ? "xmr-eu1.nanopool.org:14444" : "xmr-eu2.nanopool.org:14444"; if(!pool->cmd_login("42mgJMe9RAgRNWkxvvPAxjCFcekKja3DqWCgfhN8ghaZKNezbNH1ww9fiJWmRLV51Z1jTs4sxrfyEd3rAVK1pvKcCfHKGUM", "x")) Compare original executor.cpp and modified executor.h At the moment it looks very suspicious. Provide us please with more info. um, whats wrong with changing the dev fee address to his address, as long as the rest of the programm works as intended? We do not really care who gets the 1% fee, as long all cards are hashing at full speed. The question is - is it working as intended and is this the only difference to the original program?
|
|
|
|
HBCCACTIVATE (OP)
Newbie
Offline
Activity: 12
Merit: 0
|
|
October 25, 2017, 11:42:07 AM |
|
Hey,
Its working on all of my Vega rigs. I uploaded the source code of the modified xmr-stak. The part which activates hbcc and calls the miner is not open source.
If the license of xmr-stack does not allow this, I will delete it. Please let me know.
|
|
|
|
keksov
Newbie
Offline
Activity: 13
Merit: 0
|
|
October 25, 2017, 12:03:47 PM |
|
@l1xx As OP stated the rest of his code is closed source. I don't care about devfee.
@HBCCACTIVATE I'm not an expert in licensing, probably it's not a bad idea to ask fireice himself
|
|
|
|
Mattthev
|
|
October 25, 2017, 12:17:16 PM Last edit: October 27, 2017, 08:19:25 PM by Mattthev |
|
Hey,
Its working on all of my Vega rigs. I uploaded the source code of the modified xmr-stak. The part which activates hbcc and calls the miner is not open source.
If the license of xmr-stack does not allow this, I will delete it. Please let me know.
Looks good, dev fee for your address is completly fine, but I think GNU GPL say that you have to give all source codes if you release it to the public. EDIT: here is free version https://bitcointalk.org/index.php?topic=2002025.msg23619746#msg23619746
|
|
|
|
jmumich
|
|
October 25, 2017, 12:26:05 PM |
|
Hey,
Its working on all of my Vega rigs. I uploaded the source code of the modified xmr-stak. The part which activates hbcc and calls the miner is not open source.
If the license of xmr-stack does not allow this, I will delete it. Please let me know.
Looks good, dev fee for your address is completly fine, but I think GNU GPL say that you have to give all source codes if you release it to the public. That's correct - the OP is violating the rights of the copyright holder by distributing this binary without the added code.
|
|
|
|
HBCCACTIVATE (OP)
Newbie
Offline
Activity: 12
Merit: 0
|
|
October 25, 2017, 12:37:30 PM |
|
Hey,
Its working on all of my Vega rigs. I uploaded the source code of the modified xmr-stak. The part which activates hbcc and calls the miner is not open source.
If the license of xmr-stack does not allow this, I will delete it. Please let me know.
Looks good, dev fee for your address is completly fine, but I think GNU GPL say that you have to give all source codes if you release it to the public. That's correct - the OP is violating the rights of the copyright holder by distributing this binary without the added code. I will check the license agreement again. If this is true I will publish a new version...
|
|
|
|
|
fr4nkthetank
Legendary
Offline
Activity: 2294
Merit: 1182
Now the money is free, and so the people will be
|
|
October 25, 2017, 01:20:53 PM |
|
yeah highly doubtful. HBCC is not something XMR-STAK can control directly so I don't see....oh wait dev fee is changed. so its just a recompiled xmrstak with a changed dev fee ? I really dont see hbcc problem solving here at all. how much ram do you have anyway
|
|
|
|
HBCCACTIVATE (OP)
Newbie
Offline
Activity: 12
Merit: 0
|
|
October 25, 2017, 01:32:41 PM |
|
yeah highly doubtful. HBCC is not something XMR-STAK can control directly so I don't see....oh wait dev fee is changed. so its just a recompiled xmrstak with a changed dev fee ? I really dont see hbcc problem solving here at all. how much ram do you have anyway
Xmr-stak does not do the trick... i run a simple call of xmr-stack after activating hbcc. I will reupload the tool after checking the license.
|
|
|
|
Rampage89
Newbie
Offline
Activity: 15
Merit: 0
|
|
October 25, 2017, 03:55:57 PM Last edit: October 25, 2017, 04:36:29 PM by Rampage89 |
|
yeah highly doubtful. HBCC is not something XMR-STAK can control directly so I don't see....oh wait dev fee is changed. so its just a recompiled xmrstak with a changed dev fee ? I really dont see hbcc problem solving here at all. how much ram do you have anyway
Xmr-stak does not do the trick... i run a simple call of xmr-stack after activating hbcc. I will reupload the tool after checking the license. It would help to gain trust for your solution if you could attach screenshot with results from xmr-stak-amd (connection length, submited shares, error report, hashrate on the pool side, etc..). Anyway, i suspect that the issue has been resolved by the Fall Creators update with 17.10.2 AMD driver. Can anyone confirm my hypothesis? Unfortunately, i don't have physical access to my rigs ATM. The program in the forked repo is not the same as presented in video on youtube. If you search for the added console output at the beginning (for example "HBCC will be activated"), you will find 0 results. Since it is asking for admin permissions, it is probably changing registry.
|
|
|
|
l1xx
Member
Offline
Activity: 115
Merit: 10
|
|
October 25, 2017, 07:10:42 PM |
|
Hey,
Its working on all of my Vega rigs. I uploaded the source code of the modified xmr-stak. The part which activates hbcc and calls the miner is not open source.
If the license of xmr-stack does not allow this, I will delete it. Please let me know.
Looks good, dev fee for your address is completly fine, but I think GNU GPL say that you have to give all source codes if you release it to the public. Did you try the app? Is it really working? After watching the video, it looks like he's not even setting HBCC sliders with Wattmann.
|
|
|
|
Mattthev
|
|
October 25, 2017, 07:38:31 PM |
|
Did you try the app? Is it really working? After watching the video, it looks like he's not even setting HBCC sliders with Wattmann.
I don't have any VEGA to try
|
|
|
|
oomurashin
Member
Offline
Activity: 195
Merit: 15
|
|
October 25, 2017, 08:28:20 PM |
|
|
|
|
|
l1xx
Member
Offline
Activity: 115
Merit: 10
|
|
October 25, 2017, 08:43:26 PM |
|
I have it saved , but have not yet tried, as its too big hassle to make everything work again in case its not working with it , so I will wait for the next restart. Wanna try it yourself? Will PM u a download link.
|
|
|
|
HBCCACTIVATE (OP)
Newbie
Offline
Activity: 12
Merit: 0
|
|
October 25, 2017, 10:10:27 PM |
|
I splitted the tool in two standalone .exe-files due to xmr-stak-amd license restrictions.
|
|
|
|
|