[ANNOUNCE] New Solidcoin Client Fully Open-Source!

[jackjack]

This fork uses SolidCoin 1.03 and fixes all the recent problems in the code
Here's Soldcoin (SLC) 1.04:
https://github.com/jackjack-jj/soldcoin


diff solidcoin1.03 soldcoin1.04:

Code:

$ diff solidcoin-source-103/src soldcoin-source-104/src
Les sous-répertoires solidcoin-source-103/src/cryptopp et soldcoin-source-104/src/cryptopp sont identiques.
diff solidcoin-source-103/src/init.cpp soldcoin-source-104/src/init.cpp
323c323
<             HWND hwndPrev = FindWindowA("wxWindowNR", "SolidCoin 1.03");
---
>             HWND hwndPrev = FindWindowA("wxWindowNR", "SoldCoin 1.04");
Les sous-répertoires solidcoin-source-103/src/json et soldcoin-source-104/src/json sont identiques.
diff solidcoin-source-103/src/main.cpp soldcoin-source-104/src/main.cpp
424a425
>         {
425a427
>         }
1241,1247d1242
<     // Get prev block index
<     map<uint256, CBlockIndex*>::iterator mi = mapBlockIndex.find(hashPrevBlock);
<     if (mi == mapBlockIndex.end())
<         return error("AcceptBlock() : prev block not found");
<     CBlockIndex* pindexPrev = (*mi).second;
<     int nHeight = pindexPrev->nHeight+1;
< 
1258a1254,1260
>     // Get prev block index
>     map<uint256, CBlockIndex*>::iterator mi = mapBlockIndex.find(hashPrevBlock);
>     if (mi == mapBlockIndex.end())
>         return true;
>     CBlockIndex* pindexPrev = (*mi).second;
>     int nHeight = pindexPrev->nHeight+1;
> 
1296c1298
<         return error("AcceptBlock() : prev block not found");
---
>         return true;
1374,1379c1376,1378
<         mapOrphanBlocks.insert(make_pair(hash, pblock2));
<         mapOrphanBlocksByPrev.insert(make_pair(pblock2->hashPrevBlock, pblock2));
< 
<         // Ask this guy to fill in what we're missing
<         if (pfrom)
<             pfrom->PushGetBlocks(pindexBest, GetOrphanRoot(pblock2));
---
>         /*mapOrphanBlocks.insert(make_pair(hash, pblock2));
>         mapOrphanBlocksByPrev.insert(make_pair(pblock2->hashPrevBlock, pblock2));*/
>         if (pfrom)  pfrom->PushGetBlocks(pindexBest, GetOrphanRoot(pblock2));   // Ask this guy to fill in what we're missing
1382,1385c1381,1383
< 
<     // Store to disk
<     if (!pblock->AcceptBlock())
<         return error("ProcessBlock() : AcceptBlock FAILED");
---
>      // Store to disk
>      if (!pblock->AcceptBlock())
>          return error("ProcessBlock() : AcceptBlock FAILED");
2092,2093c2090
<                 // When this block is requested, we'll send an inv that'll make them
<                 // getblocks the next batch of inventory.
---
>                 // When this block is requested, we'll send an inv that'll make them getblocks the next batch of inventory.
2185c2182,2183
<             printf("storing orphan tx %s\n", inv.hash.ToString().substr(0,10).c_str());
---
>             pfrom->nShitSent++;
>             printf("got sent orphan tx %s from %s\n", inv.hash.ToString().substr(0,10).c_str(), pfrom->addr.ToString().c_str());
2187a2186,2194
>         else
>         {
>             printf("got sent badtx from %s\n",pfrom->addr.ToString().c_str());
>             pfrom->nBadtxsent+=5;
>         }
>         if(pfrom->nBadtxsent>10)
>         {
>             pfrom->fDisconnect=true;
>         }
diff solidcoin-source-103/src/net.h soldcoin-source-104/src/net.h
519a520
>     int nBadtxsent;
580a582
>         nBadtxsent=0;
Les sous-répertoires solidcoin-source-103/src/test et soldcoin-source-104/src/test sont identiques.
diff solidcoin-source-103/src/uibase.cpp soldcoin-source-104/src/uibase.cpp
595c595
< 	m_staticTextMain = new wxStaticText( this, wxID_ANY, _("Copyright (c) 2011 SolidCoin Developers\n\nThis is software based on bitcoin, improving the network performance and security whilst\nalso making connecting to the SolidCoin network easier for businesses and users.\n\nThis product includes software developed by the OpenSSL Project for use in the \nOpenSSL Toolkit (http://www.openssl.org/) and cryptographic software written by \nEric Young (eay@cryptsoft.com) and UPnP software written by Thomas Bernard."), wxDefaultPosition, wxDefaultSize, 0 );
---
> 	m_staticTextMain = new wxStaticText( this, wxID_ANY, _("Copyright (c) 2011 SoldCoin Developers\n\nThis is software based on bitcoin, trying but failing to improve the network performance and security whilst\nalso making connecting to the SoldCoin network easier for businesses and users.\n\nThis product includes software developed by the OpenSSL Project for use in the \nOpenSSL Toolkit (http://www.openssl.org/) and cryptographic software written by \nEric Young (eay@cryptsoft.com) and UPnP software written by Thomas Bernard."), wxDefaultPosition, wxDefaultSize, 0 );
diff solidcoin-source-103/src/uibase.h soldcoin-source-104/src/uibase.h
132c132
< 		CMainFrameBase( wxWindow* parent, wxWindowID id = wxID_MAINFRAME, const wxString& title = _("SolidCoin 1.03"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 723,484 ), long style = wxDEFAULT_FRAME_STYLE|wxRESIZE_BORDER|wxTAB_TRAVERSAL );
---
> 		CMainFrameBase( wxWindow* parent, wxWindowID id = wxID_MAINFRAME, const wxString& title = _("SoldCoin 1.04"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 723,484 ), long style = wxDEFAULT_FRAME_STYLE|wxRESIZE_BORDER|wxTAB_TRAVERSAL );
diff solidcoin-source-103/src/ui.cpp soldcoin-source-104/src/ui.cpp
2022c2022
<     m_staticTextVersion->SetLabel(strprintf(_("version 1.03"), FormatFullVersion().c_str()));
---
>     m_staticTextVersion->SetLabel(strprintf(_("version 1.04"), FormatFullVersion().c_str()));
diff solidcoin-source-103/src/wallet.cpp soldcoin-source-104/src/wallet.cpp
1002,1005d1001
< 
<     unsigned int nTxSize = ::GetSerializeSize(wtxNew, SER_NETWORK);
<     if(nTxSize>MAX_TX_SIZE) return false;   //new size limits on transactions
< 

[1714891694]

1714891694

[1714891694]

1714891694

[1714891694]

1714891694

[1714891694]

1714891694

[Bobnova]

Code:

~/soldcoin/src$ make -f ../build/makefile.unix solidcoind
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/util.o util.cpp
Assembler messages:
Fatal error: can't create ../obj/nogui/util.o: No such file or directory
make: *** [../obj/nogui/util.o] Error 1

[sd]

This fork uses SolidCoin 1.03 and fixes all the recent problems in the code
Here's Soldcoin (SLC) 1.04:
https://github.com/jackjack-jj/soldcoin
...

I just said in another thread someone should fork the 1.03 version. It looks like you had the same idea.

Nice work. So nice I'm going to send you a 0.50BTC donation which at the current exchange rate should buy you a beverage or two of your choice.

[smoothie]

Can you compile it? For some reason I'm getting same errors as above.

[jackjack]

This fork uses SolidCoin 1.03 and fixes all the recent problems in the code
Here's Soldcoin (SLC) 1.04:
https://github.com/jackjack-jj/soldcoin
...

I just said in another thread someone should fork the 1.03 version. It looks like you had the same idea.

Nice work. So nice I'm going to send you a 0.50BTC donation which at the current exchange rate should buy you a beverage or two of your choice.

Nope, I read your post where you said that and then downloaded, diff'd, modified, saved and git'd the files in a hurry
But thanks


As for the binaries, I can provide Linux ones soon
Windows binaries will come a bit later

Edit: I didn't modify the makefile so the problem must be in the solidcoin makefile, I'll try to correct that soon

[smoothie]

This fork uses SolidCoin 1.03 and fixes all the recent problems in the code
Here's Soldcoin (SLC) 1.04:
https://github.com/jackjack-jj/soldcoin
...

I just said in another thread someone should fork the 1.03 version. It looks like you had the same idea.

Nice work. So nice I'm going to send you a 0.50BTC donation which at the current exchange rate should buy you a beverage or two of your choice.

Nope, I read your post where you said that and then downloaded, diff'd, modified, saved and git'd the files in a hurry



As for the binaries, I can provide Linux ones soon
Windows binaries will come a bit later

Edit: I didn't modify the makefile so the problem must be in the solidcoin makefile, I'll try to correct that soon

Well that definitely gives an advantage to linux users. Why don't you just release both at the same time.

[jackjack]

Weird,

Code:

soldcoin-source-104/src$ make -f ../build/makefile.unix solidcoind

fully works here
Investigating...

@smoothie: I don't think it's a problem because right now there's nearly zero difference between solidcoin 1.04 and SLC 1.04
But if it's a problem ok I'll release them at the same time

[Bobnova]

I'd live Linux binaries.
That would make me very happy.

EDIT:
Jackjack, does your system have anything in the obj directory in soldocoin?  I gitted the git and it has no such things.

[smoothie]

Weird,

Code:

soldcoin-source-104/src$ make -f ../build/makefile.unix solidcoind

fully works here

@smoothie: I don't think it's a problem because right now there's nearly zero difference between solidcoin 1.04 and SLC 1.04
But if it's a problem ok I'll release them at the same time

Thanks!

[jackjack]

I'd live Linux binaries.
That would make me very happy.

EDIT:
Jackjack, does your system have anything in the obj directory in soldocoin?  I gitted the git and it has no such things.

I managed to reproduce the problem: I fixed it by creating an empty "obj" directory, then creating empty "nogui", "gui" and "crypto" directories inside it

Please tell me if it works

[Bobnova]

Gets further, craps out at upnp now. 

Code:

make -f ../build/makefile.unix solidcoind
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/util.o util.cpp
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/script.o script.cpp
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/db.o db.cpp
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/net.o net.cpp
net.cpp: In function ‘void ThreadMapPort2(void*)’:
net.cpp:1085:63: error: too few arguments to function ‘UPNPDev* upnpDiscover(int, const char*, const char*, int, int, int*)’
/usr/include/miniupnpc/miniupnpc.h:53:1: note: declared here
net.cpp:1100:72: error: too few arguments to function ‘int UPNP_AddPortMapping(const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*)’
/usr/include/miniupnpc/upnpcommands.h:117:1: note: declared here
make: *** [../obj/nogui/net.o] Error 1

I'll try reinstalling miniupnp or whatever it is.

[joulesbeef]

soo is this a new chain? or just a new client? will my coins work here?

[jackjack]

Gets further, craps out at upnp now. 

Code:

make -f ../build/makefile.unix solidcoind
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/util.o util.cpp
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/script.o script.cpp
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/db.o db.cpp
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DUSE_SSL -DUSE_UPNP=0 -o ../obj/nogui/net.o net.cpp
net.cpp: In function ‘void ThreadMapPort2(void*)’:
net.cpp:1085:63: error: too few arguments to function ‘UPNPDev* upnpDiscover(int, const char*, const char*, int, int, int*)’
/usr/include/miniupnpc/miniupnpc.h:53:1: note: declared here
net.cpp:1100:72: error: too few arguments to function ‘int UPNP_AddPortMapping(const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*)’
/usr/include/miniupnpc/upnpcommands.h:117:1: note: declared here
make: *** [../obj/nogui/net.o] Error 1

I'll try reinstalling miniupnp or whatever it is.

Try:

Code:

make -f ../build/makefile.unix solidcoind USE_UPNP=

Also, please note that I edited my previous post: to compile solidcoind, obj/nogui is needed

soo is this a new chain? or just a new client? will my coins work here?

No, yes, yes

[Bobnova]

Added that myself and turned off miniupnp in the makefile, now it compiles!
On run it ran into the .solidcoin from the previous client and borked, deleted that and now it runs, and I assume is downloading about five billion blocks.

[jackjack]

The new version in github now automatically creates the needed directories

[gw4tt]

Not a fork then just a client, title is misleading.

[smoothie]

Not a fork then just a client, title is misleading.

Yeah definitely misleading, why else would I need a recompile of the client unless it was a fork?

[jackjack]

Not a fork then just a client, title is misleading.

Absolutely, thanks for pointing that out

[Bobnova]

Aww, that's less exciting.
Fork it!  Make it Soldcoin just like the github directory

[smoothie]

Aww, that's less exciting.
Fork it!  Make it Soldcoin just like the github directory

+1000 AGREED