Bitcoin Forum
January 23, 2017, 02:49:29 PM *
News: Latest stable version of Bitcoin Core: 0.13.2  [Torrent]. (New!)
 
   Home   Help Search Donate Login Register  
Pages: « 1 [2]  All
  Print  
Author Topic: [bitcoind] Transaction fees: One annoying shit i have stumbled upon  (Read 2845 times)
2112
Legendary
*
Offline Offline

Activity: 1750



View Profile
September 22, 2011, 04:10:53 PM
 #21

Can you please point me to the exact source (line of code) ?
I will also remove it from my fork.

I didn't know that fee-skimming scams got so serious these days.
Sorry, no. Please compare 0.3.24 to 0.3.23. The example of the bug:
You have 10.0007 in the wallet and configure it to pay 0.0005 fee. You send 10 plus 0.0005 fee
and expect the wallet to retain the remaining 0.0002. Psych! It went to the miners and your wallet is empty.

The "serious" part mostly pertains to the "conspiracy" part. Traditionally, charges of conspiracy were made when the people involved modified the off-the-shelf accounting software. When "off-the-shelf" really means "off-the-sourceforge" the conspiracy charges are an easy add-on for the plaintiff lawyers.

Please comment, critique, criticize or ridicule BIP 2112: https://bitcointalk.org/index.php?topic=54382.0
Long-term mining prognosis: https://bitcointalk.org/index.php?topic=91101.0
1485182969
Hero Member
*
Offline Offline

Posts: 1485182969

View Profile Personal Message (Offline)

Ignore
1485182969
Reply with quote  #2

1485182969
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
2112
Legendary
*
Offline Offline

Activity: 1750



View Profile
September 22, 2011, 04:14:33 PM
 #22

The "change is too small to go to wallet, let's send it to the miner" thing on itself wasn't a bug.

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.
I apologise for the misrepresentation. I misunderstood somebody's else description. I never looked at the 0.3.24 code. I went straight from 0.3.23 to 0.4rc2. Sorry.

Please comment, critique, criticize or ridicule BIP 2112: https://bitcointalk.org/index.php?topic=54382.0
Long-term mining prognosis: https://bitcointalk.org/index.php?topic=91101.0
ShadowOfHarbringer
Legendary
*
Offline Offline

Activity: 1470


Bringing Legendary Har® to you since 1952


View Profile
September 22, 2011, 04:20:51 PM
 #23

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.

Can you point me to the particular piece of code ?

Pieter Wuille
Legendary
*
qt
Offline Offline

Activity: 1036


View Profile WWW
September 22, 2011, 04:26:22 PM
 #24

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.

Can you point me to the particular piece of code ?

This commit fixes it: https://github.com/bitcoin/bitcoin/commit/b6d19aefa0cf455dca57ca74eeb75e158a9390d0.

aka sipa, core dev team

Tips and donations: 1KwDYMJMS4xq3ZEWYfdBRwYG2fHwhZsipa
ShadowOfHarbringer
Legendary
*
Offline Offline

Activity: 1470


Bringing Legendary Har® to you since 1952


View Profile
September 22, 2011, 06:30:34 PM
 #25

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.

Can you point me to the particular piece of code ?

This commit fixes it: https://github.com/bitcoin/bitcoin/commit/b6d19aefa0cf455dca57ca74eeb75e158a9390d0.


Excellent, thanks.
I will merge it into my fork.

Hopefully, it won't be too difficult for me to merge it into older versions also (< 0.3.24).

Update:
I checked and my forked version already contains this patch, but thanks nevertheless.

Edit2:
I will now try to apply it from trunk into nftf-0.3.24 branch and older versions.

Edit3:
I successfully merged the patch into following branches:

https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.21
https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.22
https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.23 (was already patched)
https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.24

I added proper announcement:
https://bitcointalk.org/index.php?topic=22434.40

Pages: « 1 [2]  All
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!